Re: [U-Boot] [PATCH v2 01/12] x86: coreboot: Set up timer base correctly

2015-01-05 Thread Simon Glass
On 5 January 2015 at 08:27, Bin Meng bmeng...@gmail.com wrote:
 If coreboot is built with CONFIG_COLLECT_TIMESTAMPS, use the value
 of base_time in coreboot's timestamp table as our timer base,
 otherwise TSC counter value will be used.

 Sometimes even coreboot is built with CONFIG_COLLECT_TIMESTAMPS,
 the value of base_time in the timestamp table is still zero, so
 we must exclude this case too (this is currently seen on booting
 coreboot in qemu).

 Signed-off-by: Bin Meng bmeng...@gmail.com

 ---

 Changes in v2:
 - Fix the CONFIG_COLLECT_TIMESTAMPS typo in the comment block
   and commit message

Acked-by: Simon Glass s...@chromium.org
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v2 01/12] x86: coreboot: Set up timer base correctly

2015-01-05 Thread Bin Meng
If coreboot is built with CONFIG_COLLECT_TIMESTAMPS, use the value
of base_time in coreboot's timestamp table as our timer base,
otherwise TSC counter value will be used.

Sometimes even coreboot is built with CONFIG_COLLECT_TIMESTAMPS,
the value of base_time in the timestamp table is still zero, so
we must exclude this case too (this is currently seen on booting
coreboot in qemu).

Signed-off-by: Bin Meng bmeng...@gmail.com

---

Changes in v2:
- Fix the CONFIG_COLLECT_TIMESTAMPS typo in the comment block
  and commit message

 arch/x86/cpu/coreboot/timestamp.c | 33 -
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/arch/x86/cpu/coreboot/timestamp.c 
b/arch/x86/cpu/coreboot/timestamp.c
index bd3558a..0edee6b 100644
--- a/arch/x86/cpu/coreboot/timestamp.c
+++ b/arch/x86/cpu/coreboot/timestamp.c
@@ -3,18 +3,7 @@
  *
  * Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA, 02110-1301 USA
+ * SPDX-License-Identifier:GPL-2.0+
  */
 
 #include common.h
@@ -38,9 +27,27 @@ static struct timestamp_table *ts_table  
__attribute__((section(.data)));
 
 void timestamp_init(void)
 {
+#ifdef CONFIG_SYS_X86_TSC_TIMER
+   uint64_t base_time;
+#endif
+
ts_table = lib_sysinfo.tstamp_table;
 #ifdef CONFIG_SYS_X86_TSC_TIMER
-   timer_set_base(ts_table-base_time);
+   /*
+* If coreboot is built with CONFIG_COLLECT_TIMESTAMPS, use the value
+* of base_time in coreboot's timestamp table as our timer base,
+* otherwise TSC counter value will be used.
+*
+* Sometimes even coreboot is built with CONFIG_COLLECT_TIMESTAMPS,
+* the value of base_time in the timestamp table is still zero, so
+* we must exclude this case too (this is currently seen on booting
+* coreboot in qemu)
+*/
+   if (ts_table  ts_table-base_time)
+   base_time = ts_table-base_time;
+   else
+   base_time = rdtsc();
+   timer_set_base(base_time);
 #endif
timestamp_add_now(TS_U_BOOT_INITTED);
 }
-- 
1.8.2.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot