Re: [U-Boot] [PATCH v2 04/25] net: cosmetic: Name ethaddr variables consistently

2015-04-08 Thread Simon Glass
On 8 April 2015 at 06:46, Simon Glass  wrote:
> On 8 April 2015 at 00:41, Joe Hershberger  wrote:
>> Use "_ethaddr" at the end of variables and drop CamelCase.
>> Make constant values actually 'const'.
>>
>> Signed-off-by: Joe Hershberger 
>> ---
>>
>> Changes in v2: None
>
> Acked-by: Simon Glass 

Applied to u-boot-dm/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 04/25] net: cosmetic: Name ethaddr variables consistently

2015-04-08 Thread Simon Glass
On 8 April 2015 at 00:41, Joe Hershberger  wrote:
> Use "_ethaddr" at the end of variables and drop CamelCase.
> Make constant values actually 'const'.
>
> Signed-off-by: Joe Hershberger 
> ---
>
> Changes in v2: None

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v2 04/25] net: cosmetic: Name ethaddr variables consistently

2015-04-07 Thread Joe Hershberger
Use "_ethaddr" at the end of variables and drop CamelCase.
Make constant values actually 'const'.

Signed-off-by: Joe Hershberger 
---

Changes in v2: None

 arch/arm/mach-davinci/misc.c   |  2 +-
 arch/powerpc/cpu/mpc8260/ether_fcc.c   | 14 +--
 arch/powerpc/cpu/mpc8xx/fec.c  |  6 ++---
 board/BuR/common/common.c  |  4 ++--
 board/ait/cam_enc_4xx/cam_enc_4xx.c|  2 +-
 board/alphaproject/ap_sh4a_4a/ap_sh4a_4a.c |  2 +-
 board/bct-brettl2/bct-brettl2.c|  2 +-
 board/bf518f-ezbrd/bf518f-ezbrd.c  |  4 ++--
 board/bf526-ezbrd/bf526-ezbrd.c|  4 ++--
 board/bf527-ezkit/bf527-ezkit.c|  4 ++--
 board/bf537-minotaur/bf537-minotaur.c  |  2 +-
 board/bf537-pnav/bf537-pnav.c  |  2 +-
 board/bf537-srv1/bf537-srv1.c  |  2 +-
 board/bf537-stamp/bf537-stamp.c|  4 ++--
 board/birdland/bav335x/board.c |  4 ++--
 board/buffalo/lsxl/lsxl.c  |  2 +-
 board/cm-bf527/cm-bf527.c  |  4 ++--
 board/cm-bf537e/cm-bf537e.c|  2 +-
 board/cm-bf537u/cm-bf537u.c|  2 +-
 board/compulab/cm_fx6/cm_fx6.c |  2 +-
 board/compulab/cm_t335/cm_t335.c   |  2 +-
 board/compulab/cm_t35/cm_t35.c |  2 +-
 board/compulab/cm_t3517/cm_t3517.c |  4 ++--
 board/compulab/cm_t54/cm_t54.c |  4 ++--
 board/davinci/da8xxevm/da850evm.c  |  6 ++---
 board/dnp5370/dnp5370.c|  4 ++--
 board/gumstix/pepper/board.c   |  2 +-
 board/ifm/ac14xx/ac14xx.c  |  2 +-
 board/ip04/ip04.c  |  2 +-
 board/isee/igep0033/board.c|  2 +-
 board/phytec/pcm051/board.c|  2 +-
 board/renesas/r0p7734/r0p7734.c|  2 +-
 board/siemens/common/factoryset.c  |  4 ++--
 board/siemens/pxm2/board.c |  2 +-
 board/silica/pengwyn/board.c   |  2 +-
 board/tcm-bf518/tcm-bf518.c|  4 ++--
 board/tcm-bf537/tcm-bf537.c|  2 +-
 board/ti/am335x/board.c|  6 ++---
 board/ti/am43xx/board.c|  4 ++--
 board/ti/beagle_x15/board.c|  4 ++--
 board/ti/dra7xx/evm.c  |  4 ++--
 board/ti/ti814x/evm.c  |  2 +-
 doc/README.enetaddr|  2 +-
 drivers/net/cpsw.c | 13 +-
 drivers/net/dm9000x.c  |  4 ++--
 drivers/net/e1000.c|  2 +-
 drivers/net/fec_mxc.c  |  2 +-
 drivers/net/ftmac110.c |  2 +-
 drivers/net/macb.c |  2 +-
 drivers/net/netconsole.c   |  4 ++--
 drivers/usb/eth/smsc95xx.c |  2 +-
 drivers/usb/gadget/ether.c |  8 +++
 include/net.h  | 38 +++---
 net/arp.c  |  8 +++
 net/bootp.c| 19 ---
 net/cdp.c  |  8 +++
 net/dns.c  |  4 ++--
 net/eth.c  | 22 -
 net/link_local.c   | 18 +++---
 net/net.c  | 24 +--
 net/nfs.c  |  4 ++--
 net/ping.c |  2 +-
 net/rarp.c |  8 +++
 net/sntp.c |  4 ++--
 net/tftp.c |  6 ++---
 65 files changed, 171 insertions(+), 173 deletions(-)

diff --git a/arch/arm/mach-davinci/misc.c b/arch/arm/mach-davinci/misc.c
index e18bdfc..e699d61 100644
--- a/arch/arm/mach-davinci/misc.c
+++ b/arch/arm/mach-davinci/misc.c
@@ -49,7 +49,7 @@ int dvevm_read_mac_address(uint8_t *buf)
goto i2cerr;
 
/* Check that MAC address is valid. */
-   if (!is_valid_ether_addr(buf))
+   if (!is_valid_ethaddr(buf))
goto err;
 
return 1; /* Found */
diff --git a/arch/powerpc/cpu/mpc8260/ether_fcc.c 
b/arch/powerpc/cpu/mpc8260/ether_fcc.c
index f777ba1..240e7ae 100644
--- a/arch/powerpc/cpu/mpc8260/ether_fcc.c
+++ b/arch/powerpc/cpu/mpc8260/ether_fcc.c
@@ -637,7 +637,7 @@ eth_loopback_test (void)
 
puts ("FCC Ethernet External loopback test\n");
 
-   eth_getenv_enetaddr("ethaddr", NetOurEther);
+   eth_getenv_enetaddr("ethaddr", net_ethaddr);
 
/*
 * global initialisations for all FCC channels
@@ -721,7 +721,7 @@ eth_loopback_test (void)
BD_ENET_TX_LAST | BD_ENET_TX_TC;
 
memset ((void *)bp, patbytes[i], ELBT_BUFSZ);
-   NetSetEther (bp, NetBcastAddr, 0x8000);
+   NetSetEther(bp, net_bcast_ethaddr,