[U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Jason Liu
fix saveenv or env save command not work on mx51evk board.
with this patch, we can use savenv or env save to
store enviroments to mmc card slot 0

Signed-off-by: Jason Liu r64...@freescale.com

---
Changes for v2:
  - Change MMC env size to 8KiB for the consideration for quick boot
---
 include/configs/mx51evk.h |7 ---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
index f98438d..b4e5738 100644
--- a/include/configs/mx51evk.h
+++ b/include/configs/mx51evk.h
@@ -216,8 +216,9 @@
  */
 #define CONFIG_SYS_NO_FLASH
 
-#define CONFIG_ENV_SECT_SIZE(128 * 1024)
-#define CONFIG_ENV_SIZECONFIG_ENV_SECT_SIZE
-#define CONFIG_ENV_IS_NOWHERE
+#define CONFIG_ENV_OFFSET  (6 * 64 * 1024)
+#define CONFIG_ENV_SIZE(8 * 1024)
+#define CONFIG_ENV_IS_IN_MMC
+#define CONFIG_SYS_MMC_ENV_DEV 0
 
 #endif
-- 
1.7.0.4


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Stefano Babic
On 11/17/2010 09:01 AM, Jason Liu wrote:
 fix saveenv or env save command not work on mx51evk board.
 with this patch, we can use savenv or env save to
 store enviroments to mmc card slot 0
 
 Signed-off-by: Jason Liu r64...@freescale.com
 
 ---
 Changes for v2:
   - Change MMC env size to 8KiB for the consideration for quick boot
 ---
  include/configs/mx51evk.h |7 ---
  1 files changed, 4 insertions(+), 3 deletions(-)

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Wolfgang Denk
Dear Jason Liu,

In message 1289980878-31714-1-git-send-email-r64...@freescale.com you wrote:
 fix saveenv or env save command not work on mx51evk board.
 with this patch, we can use savenv or env save to
 store enviroments to mmc card slot 0
 
 Signed-off-by: Jason Liu r64...@freescale.com
 
 ---
 Changes for v2:
   - Change MMC env size to 8KiB for the consideration for quick boot
 ---
  include/configs/mx51evk.h |7 ---
  1 files changed, 4 insertions(+), 3 deletions(-)
 
 diff --git a/include/configs/mx51evk.h b/include/configs/mx51evk.h
 index f98438d..b4e5738 100644
 --- a/include/configs/mx51evk.h
 +++ b/include/configs/mx51evk.h
 @@ -216,8 +216,9 @@
   */
  #define CONFIG_SYS_NO_FLASH
  
 -#define CONFIG_ENV_SECT_SIZE(128 * 1024)
 -#define CONFIG_ENV_SIZE  CONFIG_ENV_SECT_SIZE
 -#define CONFIG_ENV_IS_NOWHERE
 +#define CONFIG_ENV_OFFSET  (6 * 64 * 1024)
 +#define CONFIG_ENV_SIZE(8 * 1024)
 +#define CONFIG_ENV_IS_IN_MMC
 +#define CONFIG_SYS_MMC_ENV_DEV 0

The suggested env size was 16 KiB.

And I think you should add a comment where the 6 * 64 * 1024 is coming
from and why exactly this values is considered to be a good one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Open the pod bay doors, HAL.- Dave Bowman, 2001
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Wolfgang Denk
Dear Stefano Babic,

In message 4ce395a0.7060...@denx.de you wrote:
 On 11/17/2010 09:01 AM, Jason Liu wrote:
  fix saveenv or env save command not work on mx51evk board.
  with this patch, we can use savenv or env save to
  store enviroments to mmc card slot 0
  
  Signed-off-by: Jason Liu r64...@freescale.com
  
  ---
  Changes for v2:
- Change MMC env size to 8KiB for the consideration for quick boot
  ---
   include/configs/mx51evk.h |7 ---
   1 files changed, 4 insertions(+), 3 deletions(-)
 
 Applied to u-boot-imx, thanks.

Arghh... Please allow others at least a few minutes for review.
Better a few days.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
(null cookie; hope that's ok)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 1/1] mx51evk: savenv or env save command does not work

2010-11-17 Thread Stefano Babic
On 11/17/2010 02:04 PM, Wolfgang Denk wrote:
 Dear Stefano Babic,
 
 In message 4ce395a0.7060...@denx.de you wrote:
 On 11/17/2010 09:01 AM, Jason Liu wrote:
 fix saveenv or env save command not work on mx51evk board.
 with this patch, we can use savenv or env save to
 store enviroments to mmc card slot 0

 Signed-off-by: Jason Liu r64...@freescale.com

 ---
 Changes for v2:
   - Change MMC env size to 8KiB for the consideration for quick boot
 ---
  include/configs/mx51evk.h |7 ---
  1 files changed, 4 insertions(+), 3 deletions(-)

 Applied to u-boot-imx, thanks.
 
 Arghh... Please allow others at least a few minutes for review.
 Better a few days.

Sorry, it seemed to me there is a general agreement about the point and
8Kib, even if it less as suggested, is suitable in most cases. At least,
this is what I thought, but I was too fast.

I will be not so hurried in future.

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot