Re: [U-Boot] [PATCH v2 1/2] Exynos5420: Introduce support for the Peach-Pit board
Hi Simon, Hi Akshay, On 26 May 2014 03:33, Akshay Saraswat aksha...@samsung.com wrote: Hi Simon, Hi Akshay, On 21 May 2014 23:23, Akshay Saraswat aksha...@samsung.com wrote: While the Exynos5420 chip is used in both Smdk5420 and in the Peach-Pit line of devices, there could be other boards using the same chip, so a common configuration file is being added (exynos5420.h) as well as two common device tree files (exynos54xx.dtsi exynos5420.dtsi). The peach board as declared in boards.cfg is a copy of smdk5420 declaration. The configuration files are similar, but define different default device trees, console serial ports and prompts. The device tree files for smdk5420 and peach-pit inherit from the same common file. Signed-off-by: Vadim Bendebury vben...@chromium.org Signed-off-by: Akshay Saraswat aksha...@samsung.com Acked-by: Simon Glass s...@chromium.org This looks good to me. I think you might have an extra space in the last column of your boards.cfg addition, and CONFIG_CHROMEOS_PEACH might not be needed. Will fix these in the next version. But I can't get pit to boot with these patches - it hangs in SPL. Do you know what is going on? For me, these patches are working fine. I have tested them over three different pit boards. I am not sure what could be wrong. I will try over more of those boards, if I witness something like this I will update. I am not actually using the latest Pit hardware, although what I have works fine with the Chromium tree. I suppose it could be a BL1 problems, also I am using 'crosfw' (and thus cros_bundle_firmware) to write to the board. If you have any ideas let me know, but it shouldn't hold up your patches. It just prevents me from adding 'Tested-by' to your patches. I tested over variety of pit boards. And also, I am using the same BL1 what we used for chromebooks. Definitely, this abnormal boot behaviour is not because of that. But yes I am not doing emerge and I am not using 'crosfw' because I think it will need few other changes. So probably, this is why these patches are not booting. I just did make peach-pit_config make -j32. Regards, Simon Regards, Akshay Saraswat ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] Exynos5420: Introduce support for the Peach-Pit board
Hi Simon, Hi Akshay, On 21 May 2014 23:23, Akshay Saraswat aksha...@samsung.com wrote: While the Exynos5420 chip is used in both Smdk5420 and in the Peach-Pit line of devices, there could be other boards using the same chip, so a common configuration file is being added (exynos5420.h) as well as two common device tree files (exynos54xx.dtsi exynos5420.dtsi). The peach board as declared in boards.cfg is a copy of smdk5420 declaration. The configuration files are similar, but define different default device trees, console serial ports and prompts. The device tree files for smdk5420 and peach-pit inherit from the same common file. Signed-off-by: Vadim Bendebury vben...@chromium.org Signed-off-by: Akshay Saraswat aksha...@samsung.com Acked-by: Simon Glass s...@chromium.org This looks good to me. I think you might have an extra space in the last column of your boards.cfg addition, and CONFIG_CHROMEOS_PEACH might not be needed. Will fix these in the next version. But I can't get pit to boot with these patches - it hangs in SPL. Do you know what is going on? For me, these patches are working fine. I have tested them over three different pit boards. I am not sure what could be wrong. I will try over more of those boards, if I witness something like this I will update. 9276cf9 (HEAD, try-pit) Exynos5420: DMC: Add software read leveling 7706877 DMC: exynos5420: Gate CLKM to when reading PHY_CON13 0bc31a0 Exynos5420: Remove code for enabling read leveling cc36404 Exynos5: DMC: Modify the definition of ddr3_mem_ctrl_init 4544c39 Exynos: Make sure ps_hold gets set in the SPL f08ba9d Exynos5420: Let macros be used for exynos5420 5620192 Exynos5420: Introduce support for the Peach-Pit board 73e3bea (samsung/master) ARM: exynos5420: removed undefined gpio structure Regards, Simon Regards, Akshay Saraswat ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] Exynos5420: Introduce support for the Peach-Pit board
Hi Akshay, On 26 May 2014 03:33, Akshay Saraswat aksha...@samsung.com wrote: Hi Simon, Hi Akshay, On 21 May 2014 23:23, Akshay Saraswat aksha...@samsung.com wrote: While the Exynos5420 chip is used in both Smdk5420 and in the Peach-Pit line of devices, there could be other boards using the same chip, so a common configuration file is being added (exynos5420.h) as well as two common device tree files (exynos54xx.dtsi exynos5420.dtsi). The peach board as declared in boards.cfg is a copy of smdk5420 declaration. The configuration files are similar, but define different default device trees, console serial ports and prompts. The device tree files for smdk5420 and peach-pit inherit from the same common file. Signed-off-by: Vadim Bendebury vben...@chromium.org Signed-off-by: Akshay Saraswat aksha...@samsung.com Acked-by: Simon Glass s...@chromium.org This looks good to me. I think you might have an extra space in the last column of your boards.cfg addition, and CONFIG_CHROMEOS_PEACH might not be needed. Will fix these in the next version. But I can't get pit to boot with these patches - it hangs in SPL. Do you know what is going on? For me, these patches are working fine. I have tested them over three different pit boards. I am not sure what could be wrong. I will try over more of those boards, if I witness something like this I will update. I am not actually using the latest Pit hardware, although what I have works fine with the Chromium tree. I suppose it could be a BL1 problems, also I am using 'crosfw' (and thus cros_bundle_firmware) to write to the board. If you have any ideas let me know, but it shouldn't hold up your patches. It just prevents me from adding 'Tested-by' to your patches. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] Exynos5420: Introduce support for the Peach-Pit board
Hi Akshay, On 21 May 2014 23:23, Akshay Saraswat aksha...@samsung.com wrote: While the Exynos5420 chip is used in both Smdk5420 and in the Peach-Pit line of devices, there could be other boards using the same chip, so a common configuration file is being added (exynos5420.h) as well as two common device tree files (exynos54xx.dtsi exynos5420.dtsi). The peach board as declared in boards.cfg is a copy of smdk5420 declaration. The configuration files are similar, but define different default device trees, console serial ports and prompts. The device tree files for smdk5420 and peach-pit inherit from the same common file. Signed-off-by: Vadim Bendebury vben...@chromium.org Signed-off-by: Akshay Saraswat aksha...@samsung.com Acked-by: Simon Glass s...@chromium.org This looks good to me. I think you might have an extra space in the last column of your boards.cfg addition, and CONFIG_CHROMEOS_PEACH might not be needed. But I can't get pit to boot with these patches - it hangs in SPL. Do you know what is going on? 9276cf9 (HEAD, try-pit) Exynos5420: DMC: Add software read leveling 7706877 DMC: exynos5420: Gate CLKM to when reading PHY_CON13 0bc31a0 Exynos5420: Remove code for enabling read leveling cc36404 Exynos5: DMC: Modify the definition of ddr3_mem_ctrl_init 4544c39 Exynos: Make sure ps_hold gets set in the SPL f08ba9d Exynos5420: Let macros be used for exynos5420 5620192 Exynos5420: Introduce support for the Peach-Pit board 73e3bea (samsung/master) ARM: exynos5420: removed undefined gpio structure Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 1/2] Exynos5420: Introduce support for the Peach-Pit board
While the Exynos5420 chip is used in both Smdk5420 and in the Peach-Pit
line of devices, there could be other boards using the same chip, so a
common configuration file is being added (exynos5420.h) as well
as two common device tree files (exynos54xx.dtsi exynos5420.dtsi).
The peach board as declared in boards.cfg is a copy of smdk5420
declaration. The configuration files are similar, but define different
default device trees, console serial ports and prompts.
The device tree files for smdk5420 and peach-pit inherit from the same
common file.
Signed-off-by: Vadim Bendebury vben...@chromium.org
Signed-off-by: Akshay Saraswat aksha...@samsung.com
Acked-by: Simon Glass s...@chromium.org
---
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/exynos5420-peach-pit.dts | 127
arch/arm/dts/exynos5420-smdk5420.dts | 23 +-
arch/arm/dts/exynos5420.dtsi | 70
arch/arm/dts/exynos54xx.dtsi | 151 ++
boards.cfg| 1 +
include/configs/exynos5420.h | 46 +++
include/configs/peach-pit.h | 27 ++
include/configs/smdk5420.h| 49 ++-
9 files changed, 364 insertions(+), 133 deletions(-)
create mode 100644 arch/arm/dts/exynos5420-peach-pit.dts
delete mode 100644 arch/arm/dts/exynos5420.dtsi
create mode 100644 arch/arm/dts/exynos54xx.dtsi
create mode 100644 include/configs/exynos5420.h
create mode 100644 include/configs/peach-pit.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 5554615..933a464 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -6,7 +6,8 @@ dtb-$(CONFIG_EXYNOS4) += exynos4210-origen.dtb \
dtb-$(CONFIG_EXYNOS5) += exynos5250-arndale.dtb \
exynos5250-snow.dtb \
exynos5250-smdk5250.dtb \
- exynos5420-smdk5420.dtb
+ exynos5420-smdk5420.dtb \
+ exynos5420-peach-pit.dtb
dtb-$(CONFIG_MX6) += imx6q-sabreauto.dtb
dtb-$(CONFIG_TEGRA) += tegra20-harmony.dtb \
tegra20-medcom-wide.dtb \
diff --git a/arch/arm/dts/exynos5420-peach-pit.dts
b/arch/arm/dts/exynos5420-peach-pit.dts
new file mode 100644
index 000..8d148af
--- /dev/null
+++ b/arch/arm/dts/exynos5420-peach-pit.dts
@@ -0,0 +1,127 @@
+/*
+ * SAMSUNG/GOOGLE Peach-Pit board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+/dts-v1/;
+/include/ exynos54xx.dtsi
+
+/ {
+ model = Samsung/Google Peach Pit board based on Exynos5420;
+
+ compatible = google,pit-rev#, google,pit,
+ google,peach, samsung,exynos5420, samsung,exynos5;
+
+ config {
+ google,bad-wake-gpios = gpio 0x56 0; /* gpx0-6 */
+ hwid = PIT TEST A-A 7848;
+ lazy-init = 1;
+ };
+
+ aliases {
+ serial0 = /serial@12C3;
+ console = /serial@12C3;
+ pmic = /i2c@12ca;
+ };
+
+ dmc {
+ mem-manuf = samsung;
+ mem-type = ddr3;
+ clock-frequency = 8;
+ arm-frequency = 17;
+ };
+
+ tmu@1006 {
+ samsung,min-temp= 25;
+ samsung,max-temp= 125;
+ samsung,start-warning = 95;
+ samsung,start-tripping = 105;
+ samsung,hw-tripping = 110;
+ samsung,efuse-min-value = 40;
+ samsung,efuse-value = 55;
+ samsung,efuse-max-value = 100;
+ samsung,slope = 274761730;
+ samsung,dc-value= 25;
+ };
+
+ /* MAX77802 is on i2c bus 4 */
+ i2c@12ca {
+ clock-frequency = 40;
+ power-regulator@9 {
+ compatible = maxim,max77802-pmic;
+ reg = 0x9;
+ };
+ };
+
+ i2c@12cd { /* i2c7 */
+ clock-frequency = 10;
+ soundcodec@20 {
+ reg = 0x20;
+ compatible = maxim,max98090-codec;
+ };
+ };
+
+sound@383 {
+samsung,codec-type = max98090;
+};
+
+ i2c@12e1 { /* i2c9 */
+ clock-frequency = 40;
+tpm@20 {
+compatible = infineon,slb9645-tpm;
+reg = 0x20;
+ };
+ };
+
+ spi@12d3 { /* spi1 */
+ spi-max-frequency = 5000;
+ firmware_storage_spi: flash@0 {
+ reg = 0;
+
+ /*
+* A region for the kernel to store a panic event
+* which the firmware will add to the log.
+ */
+ elog-panic-event-offset = 0x01e0 0x10;
+
