Re: [U-Boot] [PATCH v2 1/2] warp7: configs: enable CONFIG_CMD_FS_GENERIC

2018-03-31 Thread TEXIER Pierre-Jean 
Hi Bryan,

2018-04-01 0:21 GMT+02:00 Bryan O'Donoghue :

>
>
> On 28/03/18 21:27, Pierre-Jean TEXIER wrote:
>
>> This enable generic file system commands (load, ls).
>>
>> Signed-off-by: Pierre-Jean TEXIER 
>> ---
>> Changes for v2:
>> - None
>>
>>   configs/warp7_defconfig| 1 +
>>   configs/warp7_secure_defconfig | 1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
>> index 29c4512..3856918 100644
>> --- a/configs/warp7_defconfig
>> +++ b/configs/warp7_defconfig
>> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
>>   CONFIG_CMD_EXT4=y
>>   CONFIG_CMD_EXT4_WRITE=y
>>   CONFIG_CMD_FAT=y
>> +CONFIG_CMD_FS_GENERIC=y
>>   CONFIG_NET_RANDOM_ETHADDR=y
>>   CONFIG_DFU_MMC=y
>>   CONFIG_USB=y
>> diff --git a/configs/warp7_secure_defconfig
>> b/configs/warp7_secure_defconfig
>> index 7310855..e894578 100644
>> --- a/configs/warp7_secure_defconfig
>> +++ b/configs/warp7_secure_defconfig
>> @@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
>>   CONFIG_CMD_EXT4=y
>>   CONFIG_CMD_EXT4_WRITE=y
>>   CONFIG_CMD_FAT=y
>> +CONFIG_CMD_FS_GENERIC=y
>>   CONFIG_DFU_MMC=y
>>   CONFIG_USB=y
>>   CONFIG_USB_EHCI_HCD=y
>>
>>
> Pierre,
>
> Myself and Fabio have discussed dropping warp7_secure_defconfig. I've
> tested your change and it works well for the patchset I have in flight.
>
> https://patchwork.ozlabs.org/patch/893882/
>
> Could you drop the part of this patch for warp7_secure_defconfig - in a v3
> ?
>

No problem, I will send a v3.

>
> That way my patch and your patch can apply independently and in any order
>
> Acked-by: Bryan O'Donoghue 
>
> ---
> bod
>

---
Pierre-Jean
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/2] warp7: configs: enable CONFIG_CMD_FS_GENERIC

2018-03-31 Thread Bryan O'Donoghue 



On 28/03/18 21:27, Pierre-Jean TEXIER wrote:

This enable generic file system commands (load, ls).

Signed-off-by: Pierre-Jean TEXIER 
---
Changes for v2:
- None

  configs/warp7_defconfig| 1 +
  configs/warp7_secure_defconfig | 1 +
  2 files changed, 2 insertions(+)

diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
index 29c4512..3856918 100644
--- a/configs/warp7_defconfig
+++ b/configs/warp7_defconfig
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
  CONFIG_CMD_EXT4=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
  CONFIG_NET_RANDOM_ETHADDR=y
  CONFIG_DFU_MMC=y
  CONFIG_USB=y
diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig
index 7310855..e894578 100644
--- a/configs/warp7_secure_defconfig
+++ b/configs/warp7_secure_defconfig
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
  CONFIG_CMD_EXT4=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
  CONFIG_DFU_MMC=y
  CONFIG_USB=y
  CONFIG_USB_EHCI_HCD=y



Pierre,

Myself and Fabio have discussed dropping warp7_secure_defconfig. I've 
tested your change and it works well for the patchset I have in flight.


https://patchwork.ozlabs.org/patch/893882/

Could you drop the part of this patch for warp7_secure_defconfig - in a v3 ?

That way my patch and your patch can apply independently and in any order

Acked-by: Bryan O'Donoghue 

---
bod
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/2] warp7: configs: enable CONFIG_CMD_FS_GENERIC

2018-03-28 Thread Fabio Estevam 
On Wed, Mar 28, 2018 at 5:27 PM, Pierre-Jean TEXIER
 wrote:
> This enable generic file system commands (load, ls).
>
> Signed-off-by: Pierre-Jean TEXIER 

Reviewed-by: Fabio Estevam 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 1/2] warp7: configs: enable CONFIG_CMD_FS_GENERIC

2018-03-28 Thread Pierre-Jean TEXIER 
This enable generic file system commands (load, ls).

Signed-off-by: Pierre-Jean TEXIER 
---
Changes for v2:
- None

 configs/warp7_defconfig| 1 +
 configs/warp7_secure_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/warp7_defconfig b/configs/warp7_defconfig
index 29c4512..3856918 100644
--- a/configs/warp7_defconfig
+++ b/configs/warp7_defconfig
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
diff --git a/configs/warp7_secure_defconfig b/configs/warp7_secure_defconfig
index 7310855..e894578 100644
--- a/configs/warp7_secure_defconfig
+++ b/configs/warp7_secure_defconfig
@@ -26,6 +26,7 @@ CONFIG_CMD_EXT2=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
 CONFIG_DFU_MMC=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot