Re: [U-Boot] [PATCH v2 1/3] ARM: at91: clock: add PLLB enable/disable functions

2016-01-26 Thread Yang, Wenyou 
Hello Heiko,

Thank you for your test.

> -Original Message-
> From: Heiko Schocher [mailto:h...@denx.de]
> Sent: 2016年1月27日 14:31
> To: Yang, Wenyou <wenyou.y...@atmel.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>
> Subject: Re: [U-Boot] [PATCH v2 1/3] ARM: at91: clock: add PLLB enable/disable
> functions
> 
> Hello Wenyou,
> 
> Am 27.01.2016 um 03:04 schrieb Wenyou Yang:
> > To avoid the duplicated code, add the PLLB handle functions.
> >
> > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
> > Reviewed-by: Andreas Bießmann <andreas.de...@googlemail.com>
> > ---
> >
> > Changes in v2: None
> >
> >   arch/arm/mach-at91/arm926ejs/clock.c  |   38
> +
> >   arch/arm/mach-at91/include/mach/clk.h |2 ++
> >   2 files changed, 40 insertions(+)
> 
> Tested on the smartweb board, so:
> 
> Tested-by: Heiko Schocher <h...@denx.de>
> 
> bye,
> Heiko
> 
> [1] testlog
> http://xeidos.ddns.net/buildbot/builders/smartweb_dfu/builds/48/steps/shell/logs/tb
> otlog
> 
> >
> > diff --git a/arch/arm/mach-at91/arm926ejs/clock.c
> > b/arch/arm/mach-at91/arm926ejs/clock.c
> > index c8b5e10..c8d24ae 100644
> > --- a/arch/arm/mach-at91/arm926ejs/clock.c
> > +++ b/arch/arm/mach-at91/arm926ejs/clock.c
> > @@ -18,6 +18,8 @@
> >   # error You need to define CONFIG_AT91FAMILY in your board config!
> >   #endif
> >
> > +#define EN_PLLB_TIMEOUT500
> > +
> >   DECLARE_GLOBAL_DATA_PTR;
> >
> >   static unsigned long at91_css_to_rate(unsigned long css) @@ -242,3
> > +244,39 @@ void at91_mck_init(u32 mckr)
> > while (!(readl(>sr) & AT91_PMC_MCKRDY))
> > ;
> >   }
> > +
> > +int at91_pllb_clk_enable(u32 pllbr)
> > +{
> > +   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
> > +   ulong start_time, tmp_time;
> > +
> > +   start_time = get_timer(0);
> > +   writel(pllbr, >pllbr);
> > +   while ((readl(>sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB) {
> > +   tmp_time = get_timer(0);
> > +   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
> > +   printf("ERROR: failed to enable PLLB\n");
> > +   return -1;
> > +   }
> > +   }
> > +
> > +   return 0;
> > +}
> > +
> > +int at91_pllb_clk_disable(void)
> > +{
> > +   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
> > +   ulong start_time, tmp_time;
> > +
> > +   start_time = get_timer(0);
> > +   writel(0, >pllbr);
> > +   while ((readl(>sr) & AT91_PMC_LOCKB) != 0) {
> > +   tmp_time = get_timer(0);
> > +   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
> > +   printf("ERROR: failed to disable PLLB\n");
> > +   return -1;
> > +   }
> > +   }
> > +
> > +   return 0;
> > +}
> > diff --git a/arch/arm/mach-at91/include/mach/clk.h
> > b/arch/arm/mach-at91/include/mach/clk.h
> > index b2604ef..64dec52 100644
> > --- a/arch/arm/mach-at91/include/mach/clk.h
> > +++ b/arch/arm/mach-at91/include/mach/clk.h
> > @@ -133,5 +133,7 @@ void at91_system_clk_disable(int sys_clk);
> >   int at91_upll_clk_enable(void);
> >   int at91_upll_clk_disable(void);
> >   void at91_usb_clk_init(u32 value);
> > +int at91_pllb_clk_enable(u32 pllbr);
> > +int at91_pllb_clk_disable(void);
> >
> >   #endif /* __ASM_ARM_ARCH_CLK_H__ */
> >
> 
> --
> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Best Regards,
Wenyou Yang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/3] ARM: at91: clock: add PLLB enable/disable functions

2016-01-26 Thread Heiko Schocher 

Hello Wenyou,

Am 27.01.2016 um 03:04 schrieb Wenyou Yang:

To avoid the duplicated code, add the PLLB handle functions.

Signed-off-by: Wenyou Yang 
Reviewed-by: Andreas Bießmann 
---

Changes in v2: None

  arch/arm/mach-at91/arm926ejs/clock.c  |   38 +
  arch/arm/mach-at91/include/mach/clk.h |2 ++
  2 files changed, 40 insertions(+)


Tested on the smartweb board, so:

Tested-by: Heiko Schocher 

bye,
Heiko

[1] testlog
http://xeidos.ddns.net/buildbot/builders/smartweb_dfu/builds/48/steps/shell/logs/tbotlog



diff --git a/arch/arm/mach-at91/arm926ejs/clock.c 
b/arch/arm/mach-at91/arm926ejs/clock.c
index c8b5e10..c8d24ae 100644
--- a/arch/arm/mach-at91/arm926ejs/clock.c
+++ b/arch/arm/mach-at91/arm926ejs/clock.c
@@ -18,6 +18,8 @@
  # error You need to define CONFIG_AT91FAMILY in your board config!
  #endif

+#define EN_PLLB_TIMEOUT500
+
  DECLARE_GLOBAL_DATA_PTR;

  static unsigned long at91_css_to_rate(unsigned long css)
@@ -242,3 +244,39 @@ void at91_mck_init(u32 mckr)
while (!(readl(>sr) & AT91_PMC_MCKRDY))
;
  }
+
+int at91_pllb_clk_enable(u32 pllbr)
+{
+   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
+   ulong start_time, tmp_time;
+
+   start_time = get_timer(0);
+   writel(pllbr, >pllbr);
+   while ((readl(>sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB) {
+   tmp_time = get_timer(0);
+   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
+   printf("ERROR: failed to enable PLLB\n");
+   return -1;
+   }
+   }
+
+   return 0;
+}
+
+int at91_pllb_clk_disable(void)
+{
+   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
+   ulong start_time, tmp_time;
+
+   start_time = get_timer(0);
+   writel(0, >pllbr);
+   while ((readl(>sr) & AT91_PMC_LOCKB) != 0) {
+   tmp_time = get_timer(0);
+   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
+   printf("ERROR: failed to disable PLLB\n");
+   return -1;
+   }
+   }
+
+   return 0;
+}
diff --git a/arch/arm/mach-at91/include/mach/clk.h 
b/arch/arm/mach-at91/include/mach/clk.h
index b2604ef..64dec52 100644
--- a/arch/arm/mach-at91/include/mach/clk.h
+++ b/arch/arm/mach-at91/include/mach/clk.h
@@ -133,5 +133,7 @@ void at91_system_clk_disable(int sys_clk);
  int at91_upll_clk_enable(void);
  int at91_upll_clk_disable(void);
  void at91_usb_clk_init(u32 value);
+int at91_pllb_clk_enable(u32 pllbr);
+int at91_pllb_clk_disable(void);

  #endif /* __ASM_ARM_ARCH_CLK_H__ */



--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 1/3] ARM: at91: clock: add PLLB enable/disable functions

2016-01-26 Thread Wenyou Yang 
To avoid the duplicated code, add the PLLB handle functions.

Signed-off-by: Wenyou Yang 
Reviewed-by: Andreas Bießmann 
---

Changes in v2: None

 arch/arm/mach-at91/arm926ejs/clock.c  |   38 +
 arch/arm/mach-at91/include/mach/clk.h |2 ++
 2 files changed, 40 insertions(+)

diff --git a/arch/arm/mach-at91/arm926ejs/clock.c 
b/arch/arm/mach-at91/arm926ejs/clock.c
index c8b5e10..c8d24ae 100644
--- a/arch/arm/mach-at91/arm926ejs/clock.c
+++ b/arch/arm/mach-at91/arm926ejs/clock.c
@@ -18,6 +18,8 @@
 # error You need to define CONFIG_AT91FAMILY in your board config!
 #endif
 
+#define EN_PLLB_TIMEOUT500
+
 DECLARE_GLOBAL_DATA_PTR;
 
 static unsigned long at91_css_to_rate(unsigned long css)
@@ -242,3 +244,39 @@ void at91_mck_init(u32 mckr)
while (!(readl(>sr) & AT91_PMC_MCKRDY))
;
 }
+
+int at91_pllb_clk_enable(u32 pllbr)
+{
+   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
+   ulong start_time, tmp_time;
+
+   start_time = get_timer(0);
+   writel(pllbr, >pllbr);
+   while ((readl(>sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB) {
+   tmp_time = get_timer(0);
+   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
+   printf("ERROR: failed to enable PLLB\n");
+   return -1;
+   }
+   }
+
+   return 0;
+}
+
+int at91_pllb_clk_disable(void)
+{
+   struct at91_pmc *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
+   ulong start_time, tmp_time;
+
+   start_time = get_timer(0);
+   writel(0, >pllbr);
+   while ((readl(>sr) & AT91_PMC_LOCKB) != 0) {
+   tmp_time = get_timer(0);
+   if ((tmp_time - start_time) > EN_PLLB_TIMEOUT) {
+   printf("ERROR: failed to disable PLLB\n");
+   return -1;
+   }
+   }
+
+   return 0;
+}
diff --git a/arch/arm/mach-at91/include/mach/clk.h 
b/arch/arm/mach-at91/include/mach/clk.h
index b2604ef..64dec52 100644
--- a/arch/arm/mach-at91/include/mach/clk.h
+++ b/arch/arm/mach-at91/include/mach/clk.h
@@ -133,5 +133,7 @@ void at91_system_clk_disable(int sys_clk);
 int at91_upll_clk_enable(void);
 int at91_upll_clk_disable(void);
 void at91_usb_clk_init(u32 value);
+int at91_pllb_clk_enable(u32 pllbr);
+int at91_pllb_clk_disable(void);
 
 #endif /* __ASM_ARM_ARCH_CLK_H__ */
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot