Re: [U-Boot] [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-boot lds files

2018-08-28 Thread Bin Meng 
On Tue, Aug 28, 2018 at 6:50 PM Jagdish Gediya  wrote:
>
> Hi Bin,
>
> > -Original Message-
> > From: Bin Meng 
> > Sent: Tuesday, August 28, 2018 2:46 PM
> > To: Jagdish Gediya 
> > Cc: U-Boot Mailing List ; Prabhakar Kushwaha
> > ; York Sun ; Poonam
> > Aggrwal ; Simon Glass ;
> > Tom Rini 
> > Subject: Re: [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-
> > boot lds files
> >
> > On Tue, Aug 28, 2018 at 11:53 AM Jagdish Gediya 
> > wrote:
> > >
> > > 'board_fdt_blob_setup' function sets up fdt blob at '&_end' so define
> > > '_end' symbol in mpc85xx lds files.
> > >
> > > Signed-off-by: Jagdish Gediya 
> > > ---
> > > Changes for v2:
> > > - Defined '_end' symbol in lds file instead of defining new
> > >   'board_fdt_blob_setup' function using existing '_init_end' 
> > > symbol.
> > >
> > >  arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 +
> > >  arch/powerpc/cpu/mpc85xx/u-boot.lds  | 1 +
> > >  2 files changed, 2 insertions(+)
> > >
> >
> > This only updates 2 lds files. Can you update all mpc85xx lds files so that 
> > they
> > are consistent?
>
> Remaining are spl lds files and I think '_end' symbol is not needed there.

But if you look at other targets, the spl version lds has the _end
symbol. Adding _end there does not cause any problem, no?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-boot lds files

2018-08-28 Thread Jagdish Gediya 
Hi Bin,

> -Original Message-
> From: Bin Meng 
> Sent: Tuesday, August 28, 2018 2:46 PM
> To: Jagdish Gediya 
> Cc: U-Boot Mailing List ; Prabhakar Kushwaha
> ; York Sun ; Poonam
> Aggrwal ; Simon Glass ;
> Tom Rini 
> Subject: Re: [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-
> boot lds files
> 
> On Tue, Aug 28, 2018 at 11:53 AM Jagdish Gediya 
> wrote:
> >
> > 'board_fdt_blob_setup' function sets up fdt blob at '&_end' so define
> > '_end' symbol in mpc85xx lds files.
> >
> > Signed-off-by: Jagdish Gediya 
> > ---
> > Changes for v2:
> > - Defined '_end' symbol in lds file instead of defining new
> >   'board_fdt_blob_setup' function using existing '_init_end' symbol.
> >
> >  arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 +
> >  arch/powerpc/cpu/mpc85xx/u-boot.lds  | 1 +
> >  2 files changed, 2 insertions(+)
> >
> 
> This only updates 2 lds files. Can you update all mpc85xx lds files so that 
> they
> are consistent?

Remaining are spl lds files and I think '_end' symbol is not needed there.

Thanks,
Jagdish
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-boot lds files

2018-08-28 Thread Bin Meng 
On Tue, Aug 28, 2018 at 11:53 AM Jagdish Gediya  wrote:
>
> 'board_fdt_blob_setup' function sets up fdt blob at '&_end' so
> define '_end' symbol in mpc85xx lds files.
>
> Signed-off-by: Jagdish Gediya 
> ---
> Changes for v2:
> - Defined '_end' symbol in lds file instead of defining new
>   'board_fdt_blob_setup' function using existing '_init_end' symbol.
>
>  arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 +
>  arch/powerpc/cpu/mpc85xx/u-boot.lds  | 1 +
>  2 files changed, 2 insertions(+)
>

This only updates 2 lds files. Can you update all mpc85xx lds files so
that they are consistent?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 1/8] powerpc/dts: Define '_end' symbol in mpc85xx u-boot lds files

2018-08-27 Thread Jagdish Gediya 
'board_fdt_blob_setup' function sets up fdt blob at '&_end' so
define '_end' symbol in mpc85xx lds files.

Signed-off-by: Jagdish Gediya 
---
Changes for v2:
- Defined '_end' symbol in lds file instead of defining new
  'board_fdt_blob_setup' function using existing '_init_end' symbol.

 arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 1 +
 arch/powerpc/cpu/mpc85xx/u-boot.lds  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/powerpc/cpu/mpc85xx/u-boot-nand.lds 
b/arch/powerpc/cpu/mpc85xx/u-boot-nand.lds
index 6db6da1..75b0285 100644
--- a/arch/powerpc/cpu/mpc85xx/u-boot-nand.lds
+++ b/arch/powerpc/cpu/mpc85xx/u-boot-nand.lds
@@ -74,6 +74,7 @@ SECTIONS
   .data.init : { *(.data.init) }
   . = ALIGN(256);
   __init_end = .;
+  _end = .;
 
   .bootpg ADDR(.text) - 0x1000 :
   {
diff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds 
b/arch/powerpc/cpu/mpc85xx/u-boot.lds
index 14c31be..22bbac5 100644
--- a/arch/powerpc/cpu/mpc85xx/u-boot.lds
+++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds
@@ -81,6 +81,7 @@ SECTIONS
   .data.init : { *(.data.init) }
   . = ALIGN(256);
   __init_end = .;
+  _end = .;
 
 #ifdef CONFIG_SYS_MPC85XX_NO_RESETVEC
   .bootpg ADDR(.text) - 0x1000 :
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot