Re: [U-Boot] [PATCH v2 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC

[Lukasz Majewski]

On Wed, 13 Feb 2019 17:46:40 +0100
Krzysztof Kozlowski  wrote:

> When stopping the ADC_V2_CON1_STC_EN should be cleared.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  drivers/adc/exynos-adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
> index d33e3d632afc..12c49fc8cefb 100644
> --- a/drivers/adc/exynos-adc.c
> +++ b/drivers/adc/exynos-adc.c
> @@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev)
>  
>   /* Stop conversion */
>   cfg = readl(®s->con1);
> - cfg |= ~ADC_V2_CON1_STC_EN;
> + cfg &= ~ADC_V2_CON1_STC_EN;
>  
>   writel(cfg, ®s->con1);
>  

Reviewed-by: Lukasz Majewski 


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de


pgppIqc1MlEfc.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC

[Krzysztof Kozlowski]

When stopping the ADC_V2_CON1_STC_EN should be cleared.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/adc/exynos-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
index d33e3d632afc..12c49fc8cefb 100644
--- a/drivers/adc/exynos-adc.c
+++ b/drivers/adc/exynos-adc.c
@@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev)
 
/* Stop conversion */
cfg = readl(®s->con1);
-   cfg |= ~ADC_V2_CON1_STC_EN;
+   cfg &= ~ADC_V2_CON1_STC_EN;
 
writel(cfg, ®s->con1);
 
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot