Re: [U-Boot] [PATCH v2 2/2] arm: remove unneeded symbol offsets and _TEXT_BASE

2013-11-08 Thread Benoît Thébaudeau
Hi Albert,

On Thursday, November 7, 2013 3:15:04 PM, Albert ARIBAUD wrote:
 Remove the last uses of symbol offsets in ARM U-Boot.
 Remove some needless uses of _TEXT_BASE.
 Remove all _TEXT_BASE definitions.
 
 Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net

Reviewed-by: Benoît Thébaudeau benoit.thebaud...@advansee.com

Best regards,
Benoît
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v2 2/2] arm: remove unneeded symbol offsets and _TEXT_BASE

2013-11-07 Thread Albert ARIBAUD
Remove the last uses of symbol offsets in ARM U-Boot.
Remove some needless uses of _TEXT_BASE.
Remove all _TEXT_BASE definitions.

Signed-off-by: Albert ARIBAUD albert.u.b...@aribaud.net
---
Changes in v2:
- fixed use of _rel_dyn_end instead of _end

 README  |  6 --
 arch/arm/cpu/arm1136/start.S| 27 ---
 arch/arm/cpu/arm1176/start.S| 27 ---
 arch/arm/cpu/arm720t/start.S| 26 --
 arch/arm/cpu/arm920t/start.S| 26 --
 arch/arm/cpu/arm926ejs/at91/lowlevel_init.S | 14 +-
 arch/arm/cpu/arm926ejs/mxs/start.S  | 27 ---
 arch/arm/cpu/arm926ejs/start.S  | 27 ---
 arch/arm/cpu/arm946es/start.S   | 26 --
 arch/arm/cpu/arm_intcm/start.S  | 26 --
 arch/arm/cpu/armv7/omap3/lowlevel_init.S|  3 ---
 arch/arm/cpu/armv7/start.S  | 23 ---
 arch/arm/cpu/ixp/start.S| 26 --
 arch/arm/cpu/pxa/start.S| 27 ---
 arch/arm/cpu/sa1100/start.S | 26 --
 arch/arm/lib/board.c| 12 ++--
 board/armltd/integrator/lowlevel_init.S |  2 +-
 board/cm4008/flash.c|  2 +-
 board/cm41xx/flash.c|  2 +-
 board/mpl/vcma9/lowlevel_init.S |  5 +
 board/mx1ads/lowlevel_init.S|  4 
 board/samsung/goni/lowlevel_init.S  |  3 ---
 board/samsung/smdk2410/lowlevel_init.S  |  5 +
 board/samsung/smdk5250/lowlevel_init.S  |  5 +
 board/samsung/smdkc100/lowlevel_init.S  |  3 ---
 board/ti/omap5912osk/lowlevel_init.S|  4 
 board/ti/omap730p2/lowlevel_init.S  |  3 ---
 common/board_f.c| 14 +++---
 common/board_r.c|  4 ++--
 include/asm-generic/sections.h  | 26 +++---
 30 files changed, 25 insertions(+), 406 deletions(-)

diff --git a/README b/README
index 09662a4..67bc2aa 100644
--- a/README
+++ b/README
@@ -3532,12 +3532,6 @@ Configuration Settings:
its config.mk file). If you find problems enabling this option on
your board please report the problem and send patches!
 
-- CONFIG_SYS_SYM_OFFSETS
-   This is set by architectures that use offsets for link symbols
-   instead of absolute values. So bss_start is obtained using an
-   offset _bss_start_ofs from CONFIG_SYS_TEXT_BASE, rather than
-   directly. You should not need to touch this setting.
-
 - CONFIG_OMAP_PLATFORM_RESET_TIME_MAX_USEC (OMAP only)
This is set by OMAP boards for the max time that reset should
be asserted. See doc/README.omap-reset-time for details on how
diff --git a/arch/arm/cpu/arm1136/start.S b/arch/arm/cpu/arm1136/start.S
index 00d1b30..3e2358e 100644
--- a/arch/arm/cpu/arm1136/start.S
+++ b/arch/arm/cpu/arm1136/start.S
@@ -70,32 +70,6 @@ _end_vect:
  *
  */
 
-.globl _TEXT_BASE
-_TEXT_BASE:
-#if defined(CONFIG_SPL_BUILD)  defined(CONFIG_SPL_TEXT_BASE)
-   .word   CONFIG_SPL_TEXT_BASE
-#else
-   .word   CONFIG_SYS_TEXT_BASE
-#endif
-
-/*
- * These are defined in the board-specific linker script.
- * Subtracting _start from them lets the linker put their
- * relative position in the executable instead of leaving
- * them null.
- */
-.globl _bss_start_ofs
-_bss_start_ofs:
-   .word __bss_start - _start
-
-.globl _bss_end_ofs
-_bss_end_ofs:
-   .word __bss_end - _start
-
-.globl _end_ofs
-_end_ofs:
-   .word _end - _start
-
 #ifdef CONFIG_USE_IRQ
 /* IRQ stack memory (calculated at run-time) */
 .globl IRQ_STACK_START
@@ -295,7 +269,6 @@ cpu_init_crit:
 #ifdef CONFIG_SPL_BUILD
.align  5
 do_hang:
-   ldr sp, _TEXT_BASE  /* use 32 words about stack */
bl  hang/* hang and never return */
 #else  /* !CONFIG_SPL_BUILD */
.align  5
diff --git a/arch/arm/cpu/arm1176/start.S b/arch/arm/cpu/arm1176/start.S
index ffd7dd0..ce62011 100644
--- a/arch/arm/cpu/arm1176/start.S
+++ b/arch/arm/cpu/arm1176/start.S
@@ -77,33 +77,6 @@ _end_vect:
  *
  */
 
-.globl _TEXT_BASE
-_TEXT_BASE:
-#if defined(CONFIG_SPL_BUILD)  defined(CONFIG_SPL_TEXT_BASE)
-   .word   CONFIG_SPL_TEXT_BASE
-#else
-   .word   CONFIG_SYS_TEXT_BASE
-#endif
-
-/*
- * These are defined in the board-specific linker script.
- * Subtracting _start from them lets the linker put their
- * relative position in the executable instead of leaving
- * them null.
- */
-
-.globl _bss_start_ofs