[U-Boot] [PATCH v2 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM

2014-09-10 Thread Ye . Li
Set all switches APS mode in normal and PFM mode in standby. So when
mx6 entering DSM mode, the power number can be decreased. There is
no impact for mx6 in run mode.

Changes for boards:
-mx6 sabreauto
-mx6 sabresd
-mx6slevk
-mx6sxsabresd

Signed-off-by: Ye.Li b37...@freescale.com
---
Changes since v1:
- Correct the return code per Fabio's comments.

 board/freescale/mx6qsabreauto/mx6qsabreauto.c |   36 +
 board/freescale/mx6sabresd/mx6sabresd.c   |   36 +
 board/freescale/mx6slevk/mx6slevk.c   |   36 +
 board/freescale/mx6sxsabresd/mx6sxsabresd.c   |   36 +
 4 files changed, 144 insertions(+), 0 deletions(-)

diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c 
b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
index 76b024b..9e79915 100644
--- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
+++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
@@ -263,6 +263,37 @@ int board_init(void)
return 0;
 }
 
+/* set all switches APS in normal and PFM mode in standby */
+static int pfuze_setup_mode(struct pmic *p, int chip)
+{
+   unsigned char offset, i, switch_num, value;
+
+   if (!chip) {
+   /* pfuze100 */
+   switch_num = 6;
+   offset = 0x31;
+   } else {
+   /* pfuze200 */
+   switch_num = 4;
+   offset = 0x38;
+   }
+
+   value = 0xc;
+   if (pmic_reg_write(p, 0x23, value)) {
+   printf(Set SW1AB mode error!\n);
+   return -1;
+   }
+
+   for (i = 0; i  switch_num - 1; i++) {
+   if (pmic_reg_write(p, offset + i * 7, value)) {
+   printf(Set switch%x mode error!\n, offset);
+   return -1;
+   }
+   }
+
+   return 0;
+}
+
 static int pfuze_init(void)
 {
struct pmic *p;
@@ -281,6 +312,11 @@ static int pfuze_init(void)
pmic_reg_read(p, PFUZE100_DEVICEID, reg);
printf(PMIC:  PFUZE100 ID=0x%02x\n, reg);
 
+   if (pfuze_setup_mode(p, (reg  0xf))) {
+   printf(setup pfuze mode error!\n);
+   return -1;
+   }
+
/* Set SW1AB stanby volage to 0.975V */
pmic_reg_read(p, PFUZE100_SW1ABSTBY, reg);
reg = ~0x3f;
diff --git a/board/freescale/mx6sabresd/mx6sabresd.c 
b/board/freescale/mx6sabresd/mx6sabresd.c
index 72d6562..810fe13 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -456,6 +456,37 @@ int board_init(void)
return 0;
 }
 
+/* set all switches APS in normal and PFM mode in standby */
+static int pfuze_setup_mode(struct pmic *p, int chip)
+{
+   unsigned char offset, i, switch_num, value;
+
+   if (!chip) {
+   /* pfuze100 */
+   switch_num = 6;
+   offset = 0x31;
+   } else {
+   /* pfuze200 */
+   switch_num = 4;
+   offset = 0x38;
+   }
+
+   value = 0xc;
+   if (pmic_reg_write(p, 0x23, value)) {
+   printf(Set SW1AB mode error!\n);
+   return -1;
+   }
+
+   for (i = 0; i  switch_num - 1; i++) {
+   if (pmic_reg_write(p, offset + i * 7, value)) {
+   printf(Set switch%x mode error!\n, offset);
+   return -1;
+   }
+   }
+
+   return 0;
+}
+
 static int pfuze_init(void)
 {
struct pmic *p;
@@ -475,6 +506,11 @@ static int pfuze_init(void)
printf(PMIC:  PFUZE%s ID=0x%02x\n,
((reg  0xf) == 0) ? 100 : 200, reg);
 
+   if (pfuze_setup_mode(p, (reg  0xf))) {
+   printf(setup pfuze mode error!\n);
+   return -1;
+   }
+
/* Increase VGEN3 from 2.5 to 2.8V */
pmic_reg_read(p, PFUZE100_VGEN3VOL, reg);
reg = ~0xf;
diff --git a/board/freescale/mx6slevk/mx6slevk.c 
b/board/freescale/mx6slevk/mx6slevk.c
index 8b6a79c..fe5e37d 100644
--- a/board/freescale/mx6slevk/mx6slevk.c
+++ b/board/freescale/mx6slevk/mx6slevk.c
@@ -195,6 +195,37 @@ int board_init(void)
return 0;
 }
 
+/* set all switches APS in normal and PFM mode in standby */
+static int pfuze_setup_mode(struct pmic *p, int chip)
+{
+   unsigned char offset, i, switch_num, value;
+
+   if (!chip) {
+   /* pfuze100 */
+   switch_num = 6;
+   offset = 0x31;
+   } else {
+   /* pfuze200 */
+   switch_num = 4;
+   offset = 0x38;
+   }
+
+   value = 0xc;
+   if (pmic_reg_write(p, 0x23, value)) {
+   printf(Set SW1AB mode error!\n);
+   return -1;
+   }
+
+   for (i = 0; i  switch_num - 1; i++) {
+   if (pmic_reg_write(p, offset + i * 7, value)) {
+   printf(Set switch%x mode error!\n, offset);
+   return -1;
+   }
+   }
+
+   return 0;

Re: [U-Boot] [PATCH v2 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM

2014-09-10 Thread Fabio Estevam
On Wed, Sep 10, 2014 at 11:25 PM, Ye.Li b37...@freescale.com wrote:
 Set all switches APS mode in normal and PFM mode in standby. So when
 mx6 entering DSM mode, the power number can be decreased. There is
 no impact for mx6 in run mode.

 Changes for boards:
 -mx6 sabreauto
 -mx6 sabresd
 -mx6slevk
 -mx6sxsabresd

 Signed-off-by: Ye.Li b37...@freescale.com
 ---
 Changes since v1:
 - Correct the return code per Fabio's comments.

Are you sure about that?

I still see a lot of return -1 in this patch ;-)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v2 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM

2014-09-10 Thread Li Ye-B37916

On 9/11/2014 10:28 AM, Fabio Estevam wrote:
 On Wed, Sep 10, 2014 at 11:25 PM, Ye.Li b37...@freescale.com wrote:
 Set all switches APS mode in normal and PFM mode in standby. So when
 mx6 entering DSM mode, the power number can be decreased. There is
 no impact for mx6 in run mode.

 Changes for boards:
 -mx6 sabreauto
 -mx6 sabresd
 -mx6slevk
 -mx6sxsabresd

 Signed-off-by: Ye.Li b37...@freescale.com
 ---
 Changes since v1:
 - Correct the return code per Fabio's comments.
 Are you sure about that?

 I still see a lot of return -1 in this patch ;-)
Sorry, my fault. Send out v3 soon.

Best regards,
Ye Li
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot