Re: [U-Boot] [PATCH v2 4/5] riscv: dts: hifive-unleashed-a00: Add -u-boot.dtsi

2019-10-29 Thread Bin Meng
On Wed, Oct 16, 2019 at 10:58 PM Jagan Teki  wrote:
>
> Add u-boot specific dts file for hifive-unleashed-a00, this

nits: U-Boot

> would help to add u-boot specific properties and other node

ditto

> changes without touching the base dts(i) files which are easy
> to sync from Linux.
>
> Added spi2 alias for qspi2 as an initial u-boot specific
> property change.
>
> spi probing in current dm model is very much rely on aliases
> numbering. even though the qspi2 can't comes under any associated

nits: even -> Even, comes -> come

> spi nor flash it would require to specify the same to make proper
> binding happen for other spi slaves.
>
> Signed-off-by: Jagan Teki 
> ---
>  arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++
>  1 file changed, 10 insertions(+)
>  create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
>

Other than above,
Reviewed-by: Bin Meng 

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v2 4/5] riscv: dts: hifive-unleashed-a00: Add -u-boot.dtsi

2019-10-16 Thread Jagan Teki
Add u-boot specific dts file for hifive-unleashed-a00, this
would help to add u-boot specific properties and other node
changes without touching the base dts(i) files which are easy
to sync from Linux.

Added spi2 alias for qspi2 as an initial u-boot specific
property change.

spi probing in current dm model is very much rely on aliases
numbering. even though the qspi2 can't comes under any associated
spi nor flash it would require to specify the same to make proper
binding happen for other spi slaves.

Signed-off-by: Jagan Teki 
---
 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi | 10 ++
 1 file changed, 10 insertions(+)
 create mode 100644 arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi

diff --git a/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi 
b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
new file mode 100644
index 00..25ec8265a5
--- /dev/null
+++ b/arch/riscv/dts/hifive-unleashed-a00-u-boot.dtsi
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Jagan Teki 
+ */
+
+/ {
+   aliases {
+   spi2 = &qspi2;
+   };
+};
-- 
2.18.0.321.gffc6fa0e3

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot