Re: [U-Boot] [PATCH v2 5/5] tpm: add more missing va_end()

2017-11-17 Thread sjg 
On 3 October 2017 at 09:55, André Draszik  wrote:
> From: André Draszik 
>
> While commit 36d35345b1f6 ("tpm: add missing va_end") added
> some missing calls to va_end(), it missed a few places.
>
> Signed-off-by: André Draszik 
> ---
>  lib/tpm.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)

Acked-by: Simon Glass 

Applied to u-boot-dm thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 5/5] tpm: add more missing va_end()

2017-11-17 Thread Simon Glass 
On 3 October 2017 at 09:55, André Draszik  wrote:
> From: André Draszik 
>
> While commit 36d35345b1f6 ("tpm: add missing va_end") added
> some missing calls to va_end(), it missed a few places.
>
> Signed-off-by: André Draszik 
> ---
>  lib/tpm.c | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 5/5] tpm: add more missing va_end()

2017-10-03 Thread André Draszik 
From: André Draszik 

While commit 36d35345b1f6 ("tpm: add missing va_end") added
some missing calls to va_end(), it missed a few places.

Signed-off-by: André Draszik 
---
 lib/tpm.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/tpm.c b/lib/tpm.c
index 42a6591f81..f461e639e0 100644
--- a/lib/tpm.c
+++ b/lib/tpm.c
@@ -92,6 +92,7 @@ int pack_byte_string(uint8_t *str, size_t size, const char 
*format, ...)
break;
default:
debug("Couldn't recognize format string\n");
+   va_end(args);
return -1;
}
 
@@ -170,8 +171,10 @@ int unpack_byte_string(const uint8_t *str, size_t size, 
const char *format, ...)
return -1;
}
 
-   if (offset + length > size)
+   if (offset + length > size) {
+   va_end(args);
return -1;
+   }
 
switch (*format) {
case 'b':
-- 
2.14.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot