Re: [U-Boot] [PATCH v3] i2c: muxes: pca954x: Add support for GPIO reset line

[Heiko Schocher]

Hello Moritz,

Am 12.09.2017 um 15:46 schrieb Moritz Fischer:

This commit adds support for GPIO reset lines matching the
common linux "reset-gpios" devicetree binding.

Signed-off-by: Moritz Fischer 
Reviewed-by: Heiko Schocher 
Reviewed-by: Simon Glass 
---

Changes from v2:
-  Removed ifdef that would break build as suggested by Simon
-  Added Simon's and Heko's Reviewed-by

Changes from v1:
- Simon's feedback on ifdef vs IS_ENABLED()

Cheers,
Moritz

---
  drivers/i2c/muxes/pca954x.c | 40 +++-
  1 file changed, 39 insertions(+), 1 deletion(-)


Applied to u-booti2c.git

Thanks!

bye,
Heiko

--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3] i2c: muxes: pca954x: Add support for GPIO reset line

[Moritz Fischer]

This commit adds support for GPIO reset lines matching the
common linux "reset-gpios" devicetree binding.

Signed-off-by: Moritz Fischer 
Reviewed-by: Heiko Schocher 
Reviewed-by: Simon Glass 
---

Changes from v2:
-  Removed ifdef that would break build as suggested by Simon
-  Added Simon's and Heko's Reviewed-by

Changes from v1:
- Simon's feedback on ifdef vs IS_ENABLED()

Cheers,
Moritz

---
 drivers/i2c/muxes/pca954x.c | 40 +++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/muxes/pca954x.c b/drivers/i2c/muxes/pca954x.c
index 383f72f552..01ca1ff48d 100644
--- a/drivers/i2c/muxes/pca954x.c
+++ b/drivers/i2c/muxes/pca954x.c
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2015 - 2016 Xilinx, Inc.
+ * Copyright (C) 2017 National Instruments Corp
  * Written by Michal Simek
  *
  * SPDX-License-Identifier:GPL-2.0+
@@ -9,7 +10,8 @@
 #include 
 #include 
 #include 
-#include 
+
+#include 
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -30,6 +32,7 @@ struct chip_desc {
 struct pca954x_priv {
u32 addr; /* I2C mux address */
u32 width; /* I2C mux width - number of busses */
+   struct gpio_desc gpio_mux_reset;
 };
 
 static const struct chip_desc chips[] = {
@@ -105,10 +108,45 @@ static int pca954x_ofdata_to_platdata(struct udevice *dev)
return 0;
 }
 
+static int pca954x_probe(struct udevice *dev)
+{
+   if (IS_ENABLED(CONFIG_DM_GPIO)) {
+   struct pca954x_priv *priv = dev_get_priv(dev);
+   int err;
+
+   err = gpio_request_by_name(dev, "reset-gpios", 0,
+   >gpio_mux_reset, GPIOD_IS_OUT);
+
+   /* it's optional so only bail if we get a real error */
+   if (err && (err != -ENOENT))
+   return err;
+
+   /* dm will take care of polarity */
+   if (dm_gpio_is_valid(>gpio_mux_reset))
+   dm_gpio_set_value(>gpio_mux_reset, 0);
+   }
+
+   return 0;
+}
+
+static int pca954x_remove(struct udevice *dev)
+{
+   if (IS_ENABLED(CONFIG_DM_GPIO)) {
+   struct pca954x_priv *priv = dev_get_priv(dev);
+
+   if (dm_gpio_is_valid(>gpio_mux_reset))
+   dm_gpio_free(dev, >gpio_mux_reset);
+   }
+
+   return 0;
+}
+
 U_BOOT_DRIVER(pca954x) = {
.name = "pca954x",
.id = UCLASS_I2C_MUX,
.of_match = pca954x_ids,
+   .probe = pca954x_probe,
+   .remove = pca954x_remove,
.ops = _ops,
.ofdata_to_platdata = pca954x_ofdata_to_platdata,
.priv_auto_alloc_size = sizeof(struct pca954x_priv),
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot