Re: [U-Boot] [PATCH v3] rpi: Enable USB keyboard support

[Tom Rini]

On Thu, Aug 31, 2017 at 08:52:34PM +0800, Simon Glass wrote:
> Hi Alex,
> 
> On 28 August 2017 at 18:10, Alexander Graf  wrote:
> >
> >
> >> Am 26.08.2017 um 19:43 schrieb Simon Glass :
> >>
> >> This is currently disabled, so USB keyboards are not detected in U-Boot.
> >> Enable this option to fix that.
> >>
> >> Signed-off-by: Simon Glass 
> >> Tested-by: Jonathan Gray 
> >> Reviewed-by: Bin Meng 
> >> Tested-by: Paul Barker 
> >
> > When did the default behavior on kbd usb support change? I'd be inclined to 
> > say that we should restore the exact same functionality scope as before for 
> > all affected boards, not just a few well tested ones ;).
> >
> > In fact, wouldn't it make sense to imply usb kbd support in kconfig always 
> > when usb (and gfx?) is present?
> 
> Well I think it is odd to have to enable this option separately when
> you already have decided to use the keyboard. I'm not sure what to do
> in the interim, but once everything is using DM, we will drop
> CONFIG_DM_KEYBOARD. So this is really just an interim state.
> 
> I don't have strong views either way.

If someone wants to cook up a patch to add 'imply USB_KEYBOARD' in the
right places we can do it that way for now certainly.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3] rpi: Enable USB keyboard support

[Simon Glass]

Hi Alex,

On 28 August 2017 at 18:10, Alexander Graf  wrote:
>
>
>> Am 26.08.2017 um 19:43 schrieb Simon Glass :
>>
>> This is currently disabled, so USB keyboards are not detected in U-Boot.
>> Enable this option to fix that.
>>
>> Signed-off-by: Simon Glass 
>> Tested-by: Jonathan Gray 
>> Reviewed-by: Bin Meng 
>> Tested-by: Paul Barker 
>
> When did the default behavior on kbd usb support change? I'd be inclined to 
> say that we should restore the exact same functionality scope as before for 
> all affected boards, not just a few well tested ones ;).
>
> In fact, wouldn't it make sense to imply usb kbd support in kconfig always 
> when usb (and gfx?) is present?

Well I think it is odd to have to enable this option separately when
you already have decided to use the keyboard. I'm not sure what to do
in the interim, but once everything is using DM, we will drop
CONFIG_DM_KEYBOARD. So this is really just an interim state.

I don't have strong views either way.

>
> That said, this patch itself is good either way, just maybe not reaching far 
> enough ;).
>
>
> Alex
>
>

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3] rpi: Enable USB keyboard support

[Alexander Graf]

> Am 26.08.2017 um 19:43 schrieb Simon Glass :
> 
> This is currently disabled, so USB keyboards are not detected in U-Boot.
> Enable this option to fix that.
> 
> Signed-off-by: Simon Glass 
> Tested-by: Jonathan Gray 
> Reviewed-by: Bin Meng 
> Tested-by: Paul Barker 

When did the default behavior on kbd usb support change? I'd be inclined to say 
that we should restore the exact same functionality scope as before for all 
affected boards, not just a few well tested ones ;).

In fact, wouldn't it make sense to imply usb kbd support in kconfig always when 
usb (and gfx?) is present?

That said, this patch itself is good either way, just maybe not reaching far 
enough ;).


Alex


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3] rpi: Enable USB keyboard support

[Tom Rini]

On Sat, Aug 26, 2017 at 11:43:44AM -0600, Simon Glass wrote:

> This is currently disabled, so USB keyboards are not detected in U-Boot.
> Enable this option to fix that.
> 
> Signed-off-by: Simon Glass 
> Tested-by: Jonathan Gray 
> Reviewed-by: Bin Meng 
> Tested-by: Paul Barker 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3] rpi: Enable USB keyboard support

[Simon Glass]

This is currently disabled, so USB keyboards are not detected in U-Boot.
Enable this option to fix that.

Signed-off-by: Simon Glass 
Tested-by: Jonathan Gray 
Reviewed-by: Bin Meng 
Tested-by: Paul Barker 
---

Changes in v3:
- Add missing review/test tags

Changes in v2:
- Fix U_Boot typo

 configs/rpi_2_defconfig | 1 +
 configs/rpi_3_32b_defconfig | 1 +
 configs/rpi_3_defconfig | 1 +
 configs/rpi_defconfig   | 1 +
 4 files changed, 4 insertions(+)

diff --git a/configs/rpi_2_defconfig b/configs/rpi_2_defconfig
index 63d1e4042d..5150eed79c 100644
--- a/configs/rpi_2_defconfig
+++ b/configs/rpi_2_defconfig
@@ -15,6 +15,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_BCM2835=y
diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig
index 343cb197a1..caceb85b07 100644
--- a/configs/rpi_3_32b_defconfig
+++ b/configs/rpi_3_32b_defconfig
@@ -16,6 +16,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_BCM2835=y
diff --git a/configs/rpi_3_defconfig b/configs/rpi_3_defconfig
index 6c9f2e32b5..e3dd1b9124 100644
--- a/configs/rpi_3_defconfig
+++ b/configs/rpi_3_defconfig
@@ -16,6 +16,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_BCM2835=y
diff --git a/configs/rpi_defconfig b/configs/rpi_defconfig
index 6b3cec5ce0..eaf9bb9189 100644
--- a/configs/rpi_defconfig
+++ b/configs/rpi_defconfig
@@ -15,6 +15,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_MMC=y
 CONFIG_CMD_USB=y
+CONFIG_DM_KEYBOARD=y
 CONFIG_DM_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_BCM2835=y
-- 
2.14.1.342.g6490525c54-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot