Re: [U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout
Hi, On 27 January 2015 at 08:44, Przemyslaw Marczak p.marc...@samsung.com wrote: Hello, On 01/27/2015 04:38 PM, Simon Glass wrote: Hi, On 27 January 2015 at 05:36, Przemyslaw Marczak p.marc...@samsung.com wrote: If no device is connected to I2C bus, the i2c probe command can take a lot of time for probe each address. This commit reduces the busy timeout to 10ms for standard and high speed modes. This doesn't break the transmission an also allow for properly probe the devices. Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Simon Glass s...@chromium.org This patch looks OK but I'd like to get other comments if possible. [cut] Ok, that's fine. I tested this on Trats2 and Odroid XU3 and it works fine. Well, as this patch has not attracted any comments, and seems to work for me, I'll pick it up. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout
On 6 February 2015 at 13:48, Simon Glass s...@chromium.org wrote: Hi, On 27 January 2015 at 08:44, Przemyslaw Marczak p.marc...@samsung.com wrote: Hello, On 01/27/2015 04:38 PM, Simon Glass wrote: Hi, On 27 January 2015 at 05:36, Przemyslaw Marczak p.marc...@samsung.com wrote: If no device is connected to I2C bus, the i2c probe command can take a lot of time for probe each address. This commit reduces the busy timeout to 10ms for standard and high speed modes. This doesn't break the transmission an also allow for properly probe the devices. Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Simon Glass s...@chromium.org This patch looks OK but I'd like to get other comments if possible. [cut] Ok, that's fine. I tested this on Trats2 and Odroid XU3 and it works fine. Well, as this patch has not attracted any comments, and seems to work for me, I'll pick it up. Regards, Simon Applied to u-boot-dm, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout
If no device is connected to I2C bus, the i2c probe command can take a lot of time for probe each address. This commit reduces the busy timeout to 10ms for standard and high speed modes. This doesn't break the transmission an also allow for properly probe the devices. Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Changes v3: - new commit, after split the next one --- drivers/i2c/s3c24x0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index fd328f0..3129c7f 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -111,9 +111,9 @@ #define I2C_START_STOP 0x20/* START / STOP */ #define I2C_TXRX_ENA 0x10/* I2C Tx/Rx enable */ -#define I2C_TIMEOUT_MS 1000/* 1 second */ +#define I2C_TIMEOUT_MS 10 /* 10 ms */ -#defineHSI2C_TIMEOUT_US 10 /* 100 ms, finer granularity */ +#defineHSI2C_TIMEOUT_US 1 /* 10 ms, finer granularity */ /* To support VCMA9 boards and other who dont define max_i2c_num */ -- 1.9.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout
Hi, On 27 January 2015 at 05:36, Przemyslaw Marczak p.marc...@samsung.com wrote: If no device is connected to I2C bus, the i2c probe command can take a lot of time for probe each address. This commit reduces the busy timeout to 10ms for standard and high speed modes. This doesn't break the transmission an also allow for properly probe the devices. Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Simon Glass s...@chromium.org This patch looks OK but I'd like to get other comments if possible. Changes v3: - new commit, after split the next one --- drivers/i2c/s3c24x0_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index fd328f0..3129c7f 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -111,9 +111,9 @@ #define I2C_START_STOP 0x20/* START / STOP */ #define I2C_TXRX_ENA 0x10/* I2C Tx/Rx enable */ -#define I2C_TIMEOUT_MS 1000/* 1 second */ +#define I2C_TIMEOUT_MS 10 /* 10 ms */ -#defineHSI2C_TIMEOUT_US 10 /* 100 ms, finer granularity */ +#defineHSI2C_TIMEOUT_US 1 /* 10 ms, finer granularity */ /* To support VCMA9 boards and other who dont define max_i2c_num */ -- 1.9.1 Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 08/12] i2c: s3c24x0: reduce transmission status timeout
Hello, On 01/27/2015 04:38 PM, Simon Glass wrote: Hi, On 27 January 2015 at 05:36, Przemyslaw Marczak p.marc...@samsung.com wrote: If no device is connected to I2C bus, the i2c probe command can take a lot of time for probe each address. This commit reduces the busy timeout to 10ms for standard and high speed modes. This doesn't break the transmission an also allow for properly probe the devices. Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com Tested-by: Simon Glass s...@chromium.org This patch looks OK but I'd like to get other comments if possible. [cut] Ok, that's fine. I tested this on Trats2 and Odroid XU3 and it works fine. Best regards, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
