Re: [U-Boot] [PATCH v3 1/4] exynos: Properly zero initialize host in s5p_sdhci_init()

[Minkyu Kang]

On 05/10/15 20:47, Tobias Jakobi wrote:
> This makes sure that setting the host_caps in s5p_sdhci_core_init()
> doesn't operate on potentially uninitialized memory.
> 
> Acked-by: Lukasz Majewski 
> Signed-off-by: Tobias Jakobi 
> ---
>  drivers/mmc/s5p_sdhci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v3 1/4] exynos: Properly zero initialize host in s5p_sdhci_init()

[Tobias Jakobi]

This makes sure that setting the host_caps in s5p_sdhci_core_init()
doesn't operate on potentially uninitialized memory.

Acked-by: Lukasz Majewski 
Signed-off-by: Tobias Jakobi 
---
 drivers/mmc/s5p_sdhci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
index 4db51d6..911e7a8 100644
--- a/drivers/mmc/s5p_sdhci.c
+++ b/drivers/mmc/s5p_sdhci.c
@@ -84,9 +84,9 @@ static int s5p_sdhci_core_init(struct sdhci_host *host)
 
 int s5p_sdhci_init(u32 regbase, int index, int bus_width)
 {
-   struct sdhci_host *host = malloc(sizeof(struct sdhci_host));
+   struct sdhci_host *host = calloc(1, sizeof(struct sdhci_host));
if (!host) {
-   printf("sdhci__host malloc fail!\n");
+   printf("sdhci__host allocation fail!\n");
return 1;
}
host->ioaddr = (void *)regbase;
-- 
2.0.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot