Re: [U-Boot] [PATCH v3 3/3] A320: Add support for Faraday A320 evaluation board
Dear Po-Yu Chuang, In message you wrote: > > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -680,6 +680,10 @@ Sergey Lapin > >> > >> afeb9260ARM926EJS (AT91> SAM9260 SoC) > >> > >> +Po-Yu Chuang > >> + > >> + a320FA526 (ARM> v4/reuse arm920t source) faraday SoC > > > > Please keep list of maintainers alphabetically sorted. > > What is the key for sorting? I cannot figure it out. The key is the last name of the maintainer. I just notice that the "afeb9260" entry is wrong. Will send a patch to fix this. > >> +a320_config : unconfig > >> + @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday fa> raday > > > > This is a arm920t processor, so please add it in "ARM720T Systems" > > section. > > > >> +###> > >> ## > >> ## ARM720T Systems > >> ##> > >> ### > > 720t? Sorry, I meant "ARM92xT Systems" section. > How about integrator section? Many 920t boards are there. I don't think your board is an "integrator" board, or is it? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The amount of time between slipping on the peel and landing on the pavement is precisely 1 bananosecond. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/3] A320: Add support for Faraday A320 evaluation board
Dear Wolfgang Denk,
2009/7/9 Wolfgang Denk :
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -680,6 +680,10 @@ Sergey Lapin
>>
>> afeb9260 ARM926EJS (AT91SAM9260 SoC)
>>
>> +Po-Yu Chuang
>> +
>> + a320 FA526 (ARMv4/reuse arm920t source) faraday SoC
>
> Please keep list of maintainers alphabetically sorted.
What is the key for sorting? I cannot figure it out.
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -2991,6 +2991,13 @@ B2_config : unconfig
>> @$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave
>>
>> #
>> +## Faraday A320 Systems
>> +#
>
> We don't add such big headers for all vendors.
OK, removed.
>> +a320_config : unconfig
>> + @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday faraday
>
> This is a arm920t processor, so please add it in "ARM720T Systems"
> section.
>
>> +#
>> ## ARM720T Systems
>> #
720t?
How about integrator section? Many 920t boards are there.
## ARM Integrator boards - see doc/README-integrator for more info.
>> diff --git a/board/faraday/a320/a320.c b/board/faraday/a320/a320.c
>> new file mode 100644
>> index 000..f9cca4f
>> --- /dev/null
>> +++ b/board/faraday/a320/a320.c
...
>> +int dram_init (void)
>> +{
>> + gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> + gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +
>> + return 0;
>> +}
>
> Would it be possible to use get_ram_size() for auto-sizing and memory
> testing?
OK, I'll try.
>> diff --git a/board/faraday/a320/lowlevel_init.S
>> b/board/faraday/a320/lowlevel_init.S
>> new file mode 100644
>> index 000..2adb9ef
>> --- /dev/null
>> +++ b/board/faraday/a320/lowlevel_init.S
...
>> +copy_code:
>> + ldr r0, =ROM_DEFAULT_BASE /* r0 <- source address */
>> + ldr r1, =SDRAM_DEFAULT_BASE /* r1 <- target address */
>> +
>> + ldr r2, .LC5
>> + ldr r3, .LC6
>> + sub r2, r3, r2 /* r2 <- size of armboot */
>
> Please use TABs for vertical alignment.
>
Spaces removed.
>> diff --git a/cpu/arm920t/faraday/timer.c b/cpu/arm920t/faraday/timer.c
>> new file mode 100644
>> index 000..7762012
>> --- /dev/null
>> +++ b/cpu/arm920t/faraday/timer.c
...
>> +#undef DEBUG
>
> Please do not add dead code.
>
removed
...
>> +static volatile struct fttmr010 *tmr = (struct fttmr010
>> *)CONFIG_SYS_TIMERBASE;
>> +static volatile struct ftpmu010 *pmu = (struct ftpmu010
>> *)CONFIG_SYS_FTPMU_BASE;
>
> Bad formatting here?
I will use git send-email next time to avoid this. Thanks.
best regards,
Po-Yu Chuang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/3] A320: Add support for Faraday A320 evaluation board
Dear Po-Yu Chuang,
In message you
wrote:
> This patch adds support for A320 development board from Faraday. This board
> uses FA526 processor by default and has 512kB and 32MB NOR flash, 64M RAM.
> FA526 is an ARMv4 processor and uses the ARM920T source in this patch.
...
...
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -680,6 +680,10 @@ Sergey Lapin
>
> afeb9260ARM926EJS (AT91SAM9260 SoC)
>
> +Po-Yu Chuang
> +
> + a320FA526 (ARMv4/reuse arm920t source) faraday SoC
Please keep list of maintainers alphabetically sorted.
> --- a/Makefile
> +++ b/Makefile
> @@ -2991,6 +2991,13 @@ B2_config : unconfig
> @$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave
>
> #
> +## Faraday A320 Systems
> +#
We don't add such big headers for all vendors.
> +a320_config : unconfig
> + @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday faraday
This is a arm920t processor, so please add it in "ARM720T Systems"
section.
> +#
> ## ARM720T Systems
> #
> diff --git a/board/faraday/a320/a320.c b/board/faraday/a320/a320.c
> new file mode 100644
> index 000..f9cca4f
> --- /dev/null
> +++ b/board/faraday/a320/a320.c
> @@ -0,0 +1,64 @@
> +/*
> + * (C) Copyright 2009 Faraday Technology
> + * Po-Yu Chuang
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + */
> +
> +#include
> +#include
> +#include
> +#include
> +
> +#include
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +/*
> + * Miscellaneous platform dependent initialisations
> + */
> +
> +int board_init (void)
> +{
> + gd->bd->bi_arch_number = MACH_TYPE_FARADAY;
> +
> + ftsmc020_init (); /* initialize Flash */
> + rtc_reset (); /* enable RTC */
> + return 0;
> +}
> +
> +int dram_init (void)
> +{
> + gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> + gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +
> + return 0;
> +}
Would it be possible to use get_ram_size() for auto-sizing and memory
testing?
> diff --git a/board/faraday/a320/lowlevel_init.S
> b/board/faraday/a320/lowlevel_init.S
> new file mode 100644
> index 000..2adb9ef
> --- /dev/null
> +++ b/board/faraday/a320/lowlevel_init.S
...
> +.globl lowlevel_init
> +lowlevel_init:
> + mov r11, lr
> +
> + led 0x0
> +
> + /* if REMAP bit is set -> memory had been initialzed */
> +
> + ldr r0, =CONFIG_SYS_AHBC_BASE
> + ldr r1, [r0, #FTAHBC020_OFFSET_ICR]
> + tst r1, #FTAHBC020_ICR_REMAP@ test REMAP bit
> + bne skip_remap
> +
> + led 0x1
> +
> + bl init_sdmc
> +
> + led 0x2
> +
> + /*
> + * copy U-Boot to RAM
> + */
> +copy_code:
> + ldr r0, =ROM_DEFAULT_BASE /* r0 <- source address */
> + ldr r1, =SDRAM_DEFAULT_BASE /* r1 <- target address */
> +
> + ldr r2, .LC5
> + ldr r3, .LC6
> + sub r2, r3, r2 /* r2 <- size of armboot*/
Please use TABs for vertical alignment.
> diff --git a/cpu/arm920t/faraday/timer.c b/cpu/arm920t/faraday/timer.c
> new file mode 100644
> index 000..7762012
> --- /dev/null
> +++ b/cpu/arm920t/faraday/timer.c
> @@ -0,0 +1,194 @@
> +/*
> + * (C) Copyright 2009 Faraday Technology
> + * Po-Yu Chuang
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + */
> +
> +#undef DEBUG
Pleas
[U-Boot] [PATCH v3 3/3] A320: Add support for Faraday A320 evaluation board
This patch adds support for A320 development board from Faraday. This board uses FA526 processor by default and has 512kB and 32MB NOR flash, 64M RAM. FA526 is an ARMv4 processor and uses the ARM920T source in this patch. Signed-off-by: Po-Yu Chuang --- MAINTAINERS |4 + MAKEALL |1 + Makefile |7 + board/faraday/a320/Makefile | 51 +++ board/faraday/a320/a320.c| 64 board/faraday/a320/config.mk | 35 + board/faraday/a320/lowlevel_init.S | 191 cpu/arm920t/faraday/Makefile | 46 ++ cpu/arm920t/faraday/ftsmc020.c | 52 +++ cpu/arm920t/faraday/timer.c | 194 include/asm-arm/arch-faraday/ftahbc020.h | 71 + include/asm-arm/arch-faraday/ftpmu010.h | 190 include/asm-arm/arch-faraday/ftsdmc020.h | 103 + include/asm-arm/arch-faraday/ftsmc020.h | 79 ++ include/asm-arm/arch-faraday/fttmr010.h | 73 + include/configs/a320.h | 239 ++ 16 files changed, 1400 insertions(+), 0 deletions(-) create mode 100644 board/faraday/a320/Makefile create mode 100644 board/faraday/a320/a320.c create mode 100644 board/faraday/a320/config.mk create mode 100644 board/faraday/a320/lowlevel_init.S create mode 100644 cpu/arm920t/faraday/Makefile create mode 100644 cpu/arm920t/faraday/ftsmc020.c create mode 100644 cpu/arm920t/faraday/timer.c create mode 100644 include/asm-arm/arch-faraday/ftahbc020.h create mode 100644 include/asm-arm/arch-faraday/ftpmu010.h create mode 100644 include/asm-arm/arch-faraday/ftsdmc020.h create mode 100644 include/asm-arm/arch-faraday/ftsmc020.h create mode 100644 include/asm-arm/arch-faraday/fttmr010.h create mode 100644 include/configs/a320.h diff --git a/MAINTAINERS b/MAINTAINERS index b0e370f..ed41b3a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -680,6 +680,10 @@ Sergey Lapin afeb9260ARM926EJS (AT91SAM9260 SoC) +Po-Yu Chuang + + a320FA526 (ARMv4/reuse arm920t source) faraday SoC + - Unknown / orphaned boards: diff --git a/MAKEALL b/MAKEALL index 027207d..530a253 100755 --- a/MAKEALL +++ b/MAKEALL @@ -498,6 +498,7 @@ LIST_ARM7=" \ # LIST_ARM9="\ + a320\ ap920t \ ap922_XA10 \ ap926ejs\ diff --git a/Makefile b/Makefile index 0ae1d36..f99e9d4 100644 --- a/Makefile +++ b/Makefile @@ -2991,6 +2991,13 @@ B2_config: unconfig @$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave # +## Faraday A320 Systems +# + +a320_config: unconfig + @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday faraday + +# ## ARM720T Systems # diff --git a/board/faraday/a320/Makefile b/board/faraday/a320/Makefile new file mode 100644 index 000..ef053c2 --- /dev/null +++ b/board/faraday/a320/Makefile @@ -0,0 +1,51 @@ +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB= $(obj)lib$(BOARD).a + +COBJS := a320.o +SOBJS := lowlevel_init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(obj).depend $(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak $(obj).depend + +# + +# defines $
