Re: [U-Boot] [PATCH v3 3/3] configs: sopine-baseboard: Enable SPI-FLASH

2019-10-21 Thread Jagan Teki 
On Sun, Oct 20, 2019 at 11:54 AM Vasily Khoruzhick  wrote:
>
> On Wed, Oct 16, 2019 at 9:23 AM Jagan Teki  wrote:
> >
> > SoPine has winbond SPI-FLASH, so enable the same in defconfig
> > and add aliases for spi0 in -u-boot.dtsi
> >
> > Signed-off-by: Jagan Teki 
> > ---
> > Changes for v3:
> > - none
> >
> >  arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi | 12 
> >  configs/sopine_baseboard_defconfig   |  1 +
> >  2 files changed, 13 insertions(+)
> >  create mode 100644 arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
> >
> > diff --git a/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi 
> > b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
> > new file mode 100644
> > index 00..02b1ae046e
> > --- /dev/null
> > +++ b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
> > @@ -0,0 +1,12 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * Copyright (C) 2018 Jagan Teki 
> > + */
> > +
> > +#include "sunxi-u-boot.dtsi"
> > +
> > +/ {
> > +   aliases {
> > +   spi0 = &spi0;
> > +   };
> > +};
> > diff --git a/configs/sopine_baseboard_defconfig 
> > b/configs/sopine_baseboard_defconfig
> > index 5833234b63..c9123fd7ee 100644
> > --- a/configs/sopine_baseboard_defconfig
> > +++ b/configs/sopine_baseboard_defconfig
> > @@ -10,6 +10,7 @@ CONFIG_DRAM_ZQ=3881949
> >  CONFIG_MMC0_CD_PIN=""
> >  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
> >  CONFIG_SPL_SPI_SUNXI=y
> > +CONFIG_SPI_FLASH_WINBOND=y
>
> You also need to set CONFIG_SPI_FLASH since it's not set by default
> and CONFIG_SPI_FLASH_WINBOND depends on CONFIG_SPI_FLASH.

SPI_FLASH would select if DM_SPI_FLASH set. we have a patch on ML.

Winbond seems to boards specific flash, so I've mark it to board config itself.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v3 3/3] configs: sopine-baseboard: Enable SPI-FLASH

2019-10-19 Thread Vasily Khoruzhick 
On Wed, Oct 16, 2019 at 9:23 AM Jagan Teki  wrote:
>
> SoPine has winbond SPI-FLASH, so enable the same in defconfig
> and add aliases for spi0 in -u-boot.dtsi
>
> Signed-off-by: Jagan Teki 
> ---
> Changes for v3:
> - none
>
>  arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi | 12 
>  configs/sopine_baseboard_defconfig   |  1 +
>  2 files changed, 13 insertions(+)
>  create mode 100644 arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
>
> diff --git a/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi 
> b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
> new file mode 100644
> index 00..02b1ae046e
> --- /dev/null
> +++ b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2018 Jagan Teki 
> + */
> +
> +#include "sunxi-u-boot.dtsi"
> +
> +/ {
> +   aliases {
> +   spi0 = &spi0;
> +   };
> +};
> diff --git a/configs/sopine_baseboard_defconfig 
> b/configs/sopine_baseboard_defconfig
> index 5833234b63..c9123fd7ee 100644
> --- a/configs/sopine_baseboard_defconfig
> +++ b/configs/sopine_baseboard_defconfig
> @@ -10,6 +10,7 @@ CONFIG_DRAM_ZQ=3881949
>  CONFIG_MMC0_CD_PIN=""
>  CONFIG_MMC_SUNXI_SLOT_EXTRA=2
>  CONFIG_SPL_SPI_SUNXI=y
> +CONFIG_SPI_FLASH_WINBOND=y

You also need to set CONFIG_SPI_FLASH since it's not set by default
and CONFIG_SPI_FLASH_WINBOND depends on CONFIG_SPI_FLASH.




>  # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
>  CONFIG_USE_PREBOOT=y
>  CONFIG_SYS_SPI_U_BOOT_OFFS=0x8000
> --
> 2.18.0.321.gffc6fa0e3
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v3 3/3] configs: sopine-baseboard: Enable SPI-FLASH

2019-10-16 Thread Jagan Teki 
SoPine has winbond SPI-FLASH, so enable the same in defconfig
and add aliases for spi0 in -u-boot.dtsi

Signed-off-by: Jagan Teki 
---
Changes for v3:
- none

 arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi | 12 
 configs/sopine_baseboard_defconfig   |  1 +
 2 files changed, 13 insertions(+)
 create mode 100644 arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi

diff --git a/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi 
b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
new file mode 100644
index 00..02b1ae046e
--- /dev/null
+++ b/arch/arm/dts/sun50i-a64-sopine-baseboard-u-boot.dtsi
@@ -0,0 +1,12 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018 Jagan Teki 
+ */
+
+#include "sunxi-u-boot.dtsi"
+
+/ {
+   aliases {
+   spi0 = &spi0;
+   };
+};
diff --git a/configs/sopine_baseboard_defconfig 
b/configs/sopine_baseboard_defconfig
index 5833234b63..c9123fd7ee 100644
--- a/configs/sopine_baseboard_defconfig
+++ b/configs/sopine_baseboard_defconfig
@@ -10,6 +10,7 @@ CONFIG_DRAM_ZQ=3881949
 CONFIG_MMC0_CD_PIN=""
 CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_SPL_SPI_SUNXI=y
+CONFIG_SPI_FLASH_WINBOND=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_USE_PREBOOT=y
 CONFIG_SYS_SPI_U_BOOT_OFFS=0x8000
-- 
2.18.0.321.gffc6fa0e3

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot