Re: [U-Boot] [PATCH v3 3/4] imx: mx6sabresd: Add clear print for pfuze200

2014-09-12 Thread Stefano Babic
Hi Ye,

On 11/09/2014 05:13, Ye.Li wrote:
 Add clear print log to show pfuze200 or pfuze100 found on mx6sabresd.
 
 Signed-off-by: Ye.Li b37...@freescale.com
 ---
 Changes since v1:
 - None
 
 Changes since v2:
 - None
 
  board/freescale/mx6sabresd/mx6sabresd.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/board/freescale/mx6sabresd/mx6sabresd.c 
 b/board/freescale/mx6sabresd/mx6sabresd.c
 index 5f65f1b..72d6562 100644
 --- a/board/freescale/mx6sabresd/mx6sabresd.c
 +++ b/board/freescale/mx6sabresd/mx6sabresd.c
 @@ -472,7 +472,8 @@ static int pfuze_init(void)
   return ret;
  
   pmic_reg_read(p, PFUZE100_DEVICEID, reg);
 - printf(PMIC:  PFUZE100 ID=0x%02x\n, reg);
 + printf(PMIC:  PFUZE%s ID=0x%02x\n,
 + ((reg  0xf) == 0) ? 100 : 200, reg);
  
   /* Increase VGEN3 from 2.5 to 2.8V */
   pmic_reg_read(p, PFUZE100_VGEN3VOL, reg);
 

This is completely unrelated to the series - it can be applied
independently from the other patches. You do not need to resend this one
but please send in future patches belonging to the same series if they
are related to the same issue or to the same set of issues. This
simplifies review and merging - thanks !

Acked-by: Stefano Babic sba...@denx.de

Best regards,
Stefano Babic

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v3 3/4] imx: mx6sabresd: Add clear print for pfuze200

2014-09-12 Thread Li Ye-B37916
Hi Stefano,

On 9/12/2014 6:13 PM, Stefano Babic wrote:
 Hi Ye,

 On 11/09/2014 05:13, Ye.Li wrote:
 Add clear print log to show pfuze200 or pfuze100 found on mx6sabresd.

 Signed-off-by: Ye.Li b37...@freescale.com
 ---
 Changes since v1:
 - None

 Changes since v2:
 - None

  board/freescale/mx6sabresd/mx6sabresd.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

 diff --git a/board/freescale/mx6sabresd/mx6sabresd.c 
 b/board/freescale/mx6sabresd/mx6sabresd.c
 index 5f65f1b..72d6562 100644
 --- a/board/freescale/mx6sabresd/mx6sabresd.c
 +++ b/board/freescale/mx6sabresd/mx6sabresd.c
 @@ -472,7 +472,8 @@ static int pfuze_init(void)
  return ret;
  
  pmic_reg_read(p, PFUZE100_DEVICEID, reg);
 -printf(PMIC:  PFUZE100 ID=0x%02x\n, reg);
 +printf(PMIC:  PFUZE%s ID=0x%02x\n,
 +((reg  0xf) == 0) ? 100 : 200, reg);
  
  /* Increase VGEN3 from 2.5 to 2.8V */
  pmic_reg_read(p, PFUZE100_VGEN3VOL, reg);

 This is completely unrelated to the series - it can be applied
 independently from the other patches. You do not need to resend this one
 but please send in future patches belonging to the same series if they
 are related to the same issue or to the same set of issues. This
 simplifies review and merging - thanks !

 Acked-by: Stefano Babic sba...@denx.de

 Best regards,
 Stefano Babic


Thanks for your comments. I feel this patch has somewhat relation with others, 
that in 4/4 the pfuze mode setup needs to consider the pfuze chip type. Of 
course, this patch can be applied independently.  I will be more careful about 
the patch set in future.

Best regards,
Ye Li
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v3 3/4] imx: mx6sabresd: Add clear print for pfuze200

2014-09-10 Thread Ye . Li
Add clear print log to show pfuze200 or pfuze100 found on mx6sabresd.

Signed-off-by: Ye.Li b37...@freescale.com
---
Changes since v1:
- None

Changes since v2:
- None

 board/freescale/mx6sabresd/mx6sabresd.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c 
b/board/freescale/mx6sabresd/mx6sabresd.c
index 5f65f1b..72d6562 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -472,7 +472,8 @@ static int pfuze_init(void)
return ret;
 
pmic_reg_read(p, PFUZE100_DEVICEID, reg);
-   printf(PMIC:  PFUZE100 ID=0x%02x\n, reg);
+   printf(PMIC:  PFUZE%s ID=0x%02x\n,
+   ((reg  0xf) == 0) ? 100 : 200, reg);
 
/* Increase VGEN3 from 2.5 to 2.8V */
pmic_reg_read(p, PFUZE100_VGEN3VOL, reg);
-- 
1.7.4.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot