Re: [U-Boot] [PATCH v3 38/54] dm: power: Use debug() for errors in regulator uclass
On 1 July 2015 at 03:44, Przemyslaw Marczak p.marc...@samsung.com wrote: Hello Simon, On 06/23/2015 11:39 PM, Simon Glass wrote: To reduce unnecessary code size in an uncommon code path, use debug() where possible(). The driver returns an error which indicates failure. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None drivers/power/regulator/regulator-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c index a2d0b9f..12e141b 100644 --- a/drivers/power/regulator/regulator-uclass.c +++ b/drivers/power/regulator/regulator-uclass.c @@ -262,7 +262,7 @@ static int regulator_post_bind(struct udevice *dev) if (regulator_name_is_unique(dev, uc_pdata-name)) return 0; - error(\%s\ of dev: \%s\, has nonunique value: \%s\, + debug(\%s\ of dev: \%s\, has nonunique value: \%s\, property, dev-name, uc_pdata-name); return -EINVAL; Tested on: - Odroid U3 (odroid_defconfig) - Sandbox - ut pmic/regulator Tested-by: Przemyslaw Marczak p.marc...@samsung.com Acked-by: Przemyslaw Marczak p.marc...@samsung.com Best regards, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com Applied to u-boot-dm. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 38/54] dm: power: Use debug() for errors in regulator uclass
Hello Simon, On 06/23/2015 11:39 PM, Simon Glass wrote: To reduce unnecessary code size in an uncommon code path, use debug() where possible(). The driver returns an error which indicates failure. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None drivers/power/regulator/regulator-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c index a2d0b9f..12e141b 100644 --- a/drivers/power/regulator/regulator-uclass.c +++ b/drivers/power/regulator/regulator-uclass.c @@ -262,7 +262,7 @@ static int regulator_post_bind(struct udevice *dev) if (regulator_name_is_unique(dev, uc_pdata-name)) return 0; - error(\%s\ of dev: \%s\, has nonunique value: \%s\, + debug(\%s\ of dev: \%s\, has nonunique value: \%s\, property, dev-name, uc_pdata-name); return -EINVAL; Tested on: - Odroid U3 (odroid_defconfig) - Sandbox - ut pmic/regulator Tested-by: Przemyslaw Marczak p.marc...@samsung.com Acked-by: Przemyslaw Marczak p.marc...@samsung.com Best regards, -- Przemyslaw Marczak Samsung RD Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 38/54] dm: power: Use debug() for errors in regulator uclass
To reduce unnecessary code size in an uncommon code path, use debug() where possible(). The driver returns an error which indicates failure. Signed-off-by: Simon Glass s...@chromium.org --- Changes in v3: None Changes in v2: None drivers/power/regulator/regulator-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c index a2d0b9f..12e141b 100644 --- a/drivers/power/regulator/regulator-uclass.c +++ b/drivers/power/regulator/regulator-uclass.c @@ -262,7 +262,7 @@ static int regulator_post_bind(struct udevice *dev) if (regulator_name_is_unique(dev, uc_pdata-name)) return 0; - error(\%s\ of dev: \%s\, has nonunique value: \%s\, + debug(\%s\ of dev: \%s\, has nonunique value: \%s\, property, dev-name, uc_pdata-name); return -EINVAL; -- 2.4.3.573.g4eafbef ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
