Re: [U-Boot] [PATCH v4] misc: fs_loader: Add support for initializing block device

[Chee, Tien Fong]

On Fri, 2019-02-01 at 23:06 -0700, Simon Glass wrote:
On Thu, 31 Jan 2019 at 04:34, 
mailto:tien.fong.c...@intel.com>> wrote:
>
> From: Tien Fong Chee 
> mailto:tien.fong.c...@intel.com>>
>
> Firmware loader would encounter problem if the block device is accessed
> before initializing it. This patch would adding the support of probing
> block device and initializing block before the block device is accessed by
> firmware loader.
>
> Signed-off-by: Tien Fong Chee 
> mailto:tien.fong.c...@intel.com>>
>
> ---
>
> changes in v4
> - Removed header mmc.h
> - Dropped extra blank line
>
> changes in v3:
> - Initializing block device through probing the blk device
>
> changes in v2:
> - Initializing MMC through probing the blk device
> ---
>  drivers/misc/fs_loader.c | 23 +++
>  1 file changed, 23 insertions(+)

Reviewed-by: Simon Glass mailto:s...@chromium.org>>

(I'm not sure you need to check for DM being enabled, but OK)
Thanks. No strong opinion on this :) .
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v4] misc: fs_loader: Add support for initializing block device

[Simon Glass]

On Thu, 31 Jan 2019 at 04:34,  wrote:
>
> From: Tien Fong Chee 
>
> Firmware loader would encounter problem if the block device is accessed
> before initializing it. This patch would adding the support of probing
> block device and initializing block before the block device is accessed by
> firmware loader.
>
> Signed-off-by: Tien Fong Chee 
>
> ---
>
> changes in v4
> - Removed header mmc.h
> - Dropped extra blank line
>
> changes in v3:
> - Initializing block device through probing the blk device
>
> changes in v2:
> - Initializing MMC through probing the blk device
> ---
>  drivers/misc/fs_loader.c | 23 +++
>  1 file changed, 23 insertions(+)

Reviewed-by: Simon Glass 

(I'm not sure you need to check for DM being enabled, but OK)
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4] misc: fs_loader: Add support for initializing block device

[tien . fong . chee]

From: Tien Fong Chee 

Firmware loader would encounter problem if the block device is accessed
before initializing it. This patch would adding the support of probing
block device and initializing block before the block device is accessed by
firmware loader.

Signed-off-by: Tien Fong Chee 

---

changes in v4
- Removed header mmc.h
- Dropped extra blank line

changes in v3:
- Initializing block device through probing the blk device

changes in v2:
- Initializing MMC through probing the blk device
---
 drivers/misc/fs_loader.c | 23 +++
 1 file changed, 23 insertions(+)

diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
index 57a14a3..a2e3763 100644
--- a/drivers/misc/fs_loader.c
+++ b/drivers/misc/fs_loader.c
@@ -252,6 +252,29 @@ static int fs_loader_ofdata_to_platdata(struct udevice 
*dev)
 
 static int fs_loader_probe(struct udevice *dev)
 {
+#if CONFIG_IS_ENABLED(DM) && CONFIG_IS_ENABLED(BLK)
+   int ret;
+   struct device_platdata *plat = dev->platdata;
+
+   if (plat->phandlepart.phandle) {
+   ofnode node = ofnode_get_by_phandle(plat->phandlepart.phandle);
+   struct udevice *parent_dev = NULL;
+
+   ret = device_get_global_by_ofnode(node, &parent_dev);
+   if (!ret) {
+   struct udevice *dev;
+
+   ret = blk_get_from_parent(parent_dev, &dev);
+   if (ret) {
+   debug("fs_loader: No block device: %d\n",
+   ret);
+
+   return ret;
+   }
+   }
+   }
+#endif
+
return 0;
 };
 
-- 
2.2.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot