Re: [U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards
Am Donnerstag, den 14.02.2013, 14:03 -0700 schrieb Tom Warren: > This patchset adds device-tree support to the Tegra MMC driver. > All device config is done via properties in the DT files instead > of hard-coded config options/function arguments. > > I've tested this on my Seaboard and everything works fine, > including card detect. For the other T20 boards, I've used > the Linux kernel DTS files for the sdhci nodes where there > wasn't one already, or expanded the info that was already > there. Everything builds fine, but I haven't tested anything > but Seaboard. > > v2: Changes as per Stephen's & Simon's review > v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback > v4: Additional changes as per Stephen/Lucas/Thierry/Simon > > Tom Warren (4): > fdt: Add dts/dtsi file include paths to DTC command line > Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files > Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux > Tegra: MMC: Add DT support to MMC driver for all T20 boards > When applying, patches 2 and 3 should be swapped around to avoid intermediate breakage in the series. Regards, Lucas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards
On 02/14/2013 03:48 PM, Marc Dietrich wrote: > Hi Tom, > > On Thursday 14 February 2013 14:03:57 Tom Warren wrote: >> This patchset adds device-tree support to the Tegra MMC driver. >> All device config is done via properties in the DT files instead >> of hard-coded config options/function arguments. >> >> I've tested this on my Seaboard and everything works fine, >> including card detect. For the other T20 boards, I've used >> the Linux kernel DTS files for the sdhci nodes where there >> wasn't one already, or expanded the info that was already >> there. Everything builds fine, but I haven't tested anything >> but Seaboard. > > unfortunately, this is still no go on PAZ00. ... > # ext2ls mmc 1 ... > ** Bad device mmc 1 ** I see this too. I also see it on Harmony. I'm actively debugging it. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards
Marc, On Thu, Feb 14, 2013 at 3:48 PM, Marc Dietrich wrote: > Hi Tom, > > On Thursday 14 February 2013 14:03:57 Tom Warren wrote: >> This patchset adds device-tree support to the Tegra MMC driver. >> All device config is done via properties in the DT files instead >> of hard-coded config options/function arguments. >> >> I've tested this on my Seaboard and everything works fine, >> including card detect. For the other T20 boards, I've used >> the Linux kernel DTS files for the sdhci nodes where there >> wasn't one already, or expanded the info that was already >> there. Everything builds fine, but I haven't tested anything >> but Seaboard. > > unfortunately, this is still no go on PAZ00. > > U-Boot SPL 2013.01-00093-g206c157-dirty (Feb 14 2013 - 23:37:03) > > > U-Boot 2013.01-00093-g206c157-dirty (Feb 14 2013 - 23:37:03) > > TEGRA20 > Board: Compal Paz00 > DRAM: 512 MiB > MMC: tegra_mmc_init entry > tegra_mmc_init: count of sdhci nodes is 2 > process_nodes: count = 2 > mmc_get_config: node = 5772 > mmc_get_config: found controller at c8000600, width = 8, periph_id = 15 > do_mmc_init: index 0, bus width 8 pwr_gpio -1 cd_gpio -1 > do_mmc_init: bus width = 8 > mmc_get_config: node = 5244 > mmc_get_config: found controller at c800, width = 4, periph_id = 14 > do_mmc_init: index 1, bus width 4 pwr_gpio 169 cd_gpio 173 > Power GPIO name = power-gpios > CD GPIO name = cd-gpios > do_mmc_init: CD state = 0 > do_mmc_init: bus width = 4 > Tegra SD/MMC: 0, Tegra SD/MMC: 1 > tegra_mmc_getcd called, host->cd_gpio = 0x1FBCC044 > mmc_reset called > > ... so far so good > > # ext2ls mmc 1 > tegra_mmc_getcd called, host->cd_gpio = 0x1FBCC084 > mmc_reset called > mmc_core_init: host version = 0 > mmc_set_ios: bus_width: 1, clock: 375000 > mmc_change_clock called > mmc_change_clock: div = 8 > mmc_change_clock: clkcon = 0405 > mmc_set_ios: hostctl = > mmc_set_ios: bus_width: 1, clock: 375000 > mmc_change_clock called > mmc_change_clock: div = 8 > mmc_change_clock: clkcon = 0405 > mmc_set_ios: hostctl = > mmc_send_cmd: called > mmc_send_cmd_bounced called > mmc_send_cmd_bounced: cmd->arg: > mmc_send_cmd_bounced: cmd: 0 > mmc_send_cmd: called > mmc_send_cmd_bounced called > mmc_send_cmd_bounced: cmd->arg: 01aa > mmc_send_cmd_bounced: cmd: 8 > mmc_send_cmd_bounced: error: 010c8001 cmd 8 > mmc_send_cmd: called > mmc_send_cmd_bounced called > mmc_send_cmd_bounced: cmd->arg: > mmc_send_cmd_bounced: cmd: 55 > mmc_send_cmd_bounced: error: 010c8001 cmd 55 > mmc_send_cmd: called > mmc_send_cmd_bounced called > mmc_send_cmd_bounced: cmd->arg: > mmc_send_cmd_bounced: cmd: 2 > mmc_send_cmd_bounced: error: 00048001 cmd 2 > ** Bad device mmc 1 ** > > any ideas? I'm going to be gone for a few days, but I think Stephen agreed to look into it. He has a PAZ00 board. Thanks, Tom > > Marc > > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards
Hi Tom, On Thursday 14 February 2013 14:03:57 Tom Warren wrote: > This patchset adds device-tree support to the Tegra MMC driver. > All device config is done via properties in the DT files instead > of hard-coded config options/function arguments. > > I've tested this on my Seaboard and everything works fine, > including card detect. For the other T20 boards, I've used > the Linux kernel DTS files for the sdhci nodes where there > wasn't one already, or expanded the info that was already > there. Everything builds fine, but I haven't tested anything > but Seaboard. unfortunately, this is still no go on PAZ00. U-Boot SPL 2013.01-00093-g206c157-dirty (Feb 14 2013 - 23:37:03) U-Boot 2013.01-00093-g206c157-dirty (Feb 14 2013 - 23:37:03) TEGRA20 Board: Compal Paz00 DRAM: 512 MiB MMC: tegra_mmc_init entry tegra_mmc_init: count of sdhci nodes is 2 process_nodes: count = 2 mmc_get_config: node = 5772 mmc_get_config: found controller at c8000600, width = 8, periph_id = 15 do_mmc_init: index 0, bus width 8 pwr_gpio -1 cd_gpio -1 do_mmc_init: bus width = 8 mmc_get_config: node = 5244 mmc_get_config: found controller at c800, width = 4, periph_id = 14 do_mmc_init: index 1, bus width 4 pwr_gpio 169 cd_gpio 173 Power GPIO name = power-gpios CD GPIO name = cd-gpios do_mmc_init: CD state = 0 do_mmc_init: bus width = 4 Tegra SD/MMC: 0, Tegra SD/MMC: 1 tegra_mmc_getcd called, host->cd_gpio = 0x1FBCC044 mmc_reset called ... so far so good # ext2ls mmc 1 tegra_mmc_getcd called, host->cd_gpio = 0x1FBCC084 mmc_reset called mmc_core_init: host version = 0 mmc_set_ios: bus_width: 1, clock: 375000 mmc_change_clock called mmc_change_clock: div = 8 mmc_change_clock: clkcon = 0405 mmc_set_ios: hostctl = mmc_set_ios: bus_width: 1, clock: 375000 mmc_change_clock called mmc_change_clock: div = 8 mmc_change_clock: clkcon = 0405 mmc_set_ios: hostctl = mmc_send_cmd: called mmc_send_cmd_bounced called mmc_send_cmd_bounced: cmd->arg: mmc_send_cmd_bounced: cmd: 0 mmc_send_cmd: called mmc_send_cmd_bounced called mmc_send_cmd_bounced: cmd->arg: 01aa mmc_send_cmd_bounced: cmd: 8 mmc_send_cmd_bounced: error: 010c8001 cmd 8 mmc_send_cmd: called mmc_send_cmd_bounced called mmc_send_cmd_bounced: cmd->arg: mmc_send_cmd_bounced: cmd: 55 mmc_send_cmd_bounced: error: 010c8001 cmd 55 mmc_send_cmd: called mmc_send_cmd_bounced called mmc_send_cmd_bounced: cmd->arg: mmc_send_cmd_bounced: cmd: 2 mmc_send_cmd_bounced: error: 00048001 cmd 2 ** Bad device mmc 1 ** any ideas? Marc ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards
This patchset adds device-tree support to the Tegra MMC driver. All device config is done via properties in the DT files instead of hard-coded config options/function arguments. I've tested this on my Seaboard and everything works fine, including card detect. For the other T20 boards, I've used the Linux kernel DTS files for the sdhci nodes where there wasn't one already, or expanded the info that was already there. Everything builds fine, but I haven't tested anything but Seaboard. v2: Changes as per Stephen's & Simon's review v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback v4: Additional changes as per Stephen/Lucas/Thierry/Simon Tom Warren (4): fdt: Add dts/dtsi file include paths to DTC command line Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux Tegra: MMC: Add DT support to MMC driver for all T20 boards arch/arm/dts/tegra20.dtsi | 16 +- arch/arm/include/asm/arch-tegra/mmc.h |2 +- arch/arm/include/asm/arch-tegra/tegra_mmc.h | 13 +- board/avionic-design/common/tamonten.c| 19 +- board/avionic-design/dts/tegra20-medcom-wide.dts |3 +- board/avionic-design/dts/tegra20-plutux.dts |3 +- board/avionic-design/dts/tegra20-tamonten.dtsi| 489 + board/avionic-design/dts/tegra20-tec.dts |3 +- board/compal/dts/tegra20-paz00.dts| 19 +- board/compal/paz00/paz00.c| 26 +- board/compulab/dts/tegra20-trimslice.dts | 14 + board/compulab/trimslice/trimslice.c | 23 +- board/nvidia/common/board.c | 25 + board/nvidia/dts/tegra20-harmony.dts | 18 + board/nvidia/dts/tegra20-seaboard.dts | 10 +- board/nvidia/dts/tegra20-ventana.dts | 15 + board/nvidia/dts/tegra20-whistler.dts | 13 + board/nvidia/harmony/harmony.c| 26 +- board/nvidia/seaboard/seaboard.c | 25 +- board/nvidia/whistler/whistler.c | 30 +- board/toradex/colibri_t20_iris/colibri_t20_iris.c | 11 +- board/toradex/dts/tegra20-colibri_t20_iris.dts|7 + drivers/mmc/tegra_mmc.c | 256 +++ dts/Makefile |2 +- include/fdtdec.h |1 + lib/fdtdec.c |1 + 26 files changed, 810 insertions(+), 260 deletions(-) create mode 100644 board/avionic-design/dts/tegra20-tamonten.dtsi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
