Re: [U-Boot] [PATCH v4 3/4] stv0991: default + misc command configs enabled

2014-11-18 Thread vikasm

Hello Albert,

On 11/17/2014 11:29 PM, Albert ARIBAUD wrote:

Hello Vikas,

(nitpicking) can you replace '+' in the subject with 'and' ?


ok, i will submit the v5.



(nitpicking yet more) can you keep the action form for the subject
rather than action done, i.e., stv0991: enable default and misc
command configs


ok.



Amicalement,


Rgds,
Vikas
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v4 3/4] stv0991: default + misc command configs enabled

2014-11-17 Thread Vikas Manocha
Signed-off-by: Vikas Manocha vikas.mano...@st.com
---

Changes in v4: None

Changes in v3:
- removed period from commit message

Changes in v2: None

 include/configs/stv0991.h |   21 +++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/include/configs/stv0991.h b/include/configs/stv0991.h
index a316f63..f95de06 100644
--- a/include/configs/stv0991.h
+++ b/include/configs/stv0991.h
@@ -8,7 +8,6 @@
 #ifndef __CONFIG_STV0991_H
 #define __CONFIG_STV0991_H
 #define CONFIG_SYS_DCACHE_OFF
-#define CONFIG_SYS_ICACHE_OFF
 #define CONFIG_SYS_EXCEPTION_VECTORS_HIGH
 #define CONFIG_BOARD_EARLY_INIT_F
 
@@ -40,7 +39,7 @@
 
 /* user interface */
 #define CONFIG_SYS_PROMPT  STV0991 
-#define CONFIG_SYS_CBSIZE  256/* Console I/O Buffer Size */
+#define CONFIG_SYS_CBSIZE  1024
 #define CONFIG_SYS_PBSIZE  (CONFIG_SYS_CBSIZE \
+sizeof(CONFIG_SYS_PROMPT) + 16)
 
@@ -68,4 +67,22 @@
 #define CONFIG_CMD_PING
 #define CONFIG_PHY_RESET_DELAY 1   /* in usec */
 
+#include config_cmd_default.h
+#undef CONFIG_CMD_SAVEENV
+
+#define CONFIG_SYS_MEMTEST_START   0x
+#define CONFIG_SYS_MEMTEST_END 1024*1024
+#define CONFIG_CMD_MEMTEST
+
+/* Misc configuration */
+#define CONFIG_SYS_LONGHELP
+#define CONFIG_CMDLINE_EDITING
+
+#define CONFIG_BOOTDELAY   3
+#define CONFIG_BOOTCOMMAND go 0x4004
+#define CONFIG_AUTOBOOT_KEYED
+#define CONFIG_AUTOBOOT_STOP_STR
+#define CONFIG_AUTOBOOT_PROMPT \
+   Hit SPACE in %d seconds to stop autoboot.\n, bootdelay
+
 #endif /* __CONFIG_H */
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v4 3/4] stv0991: default + misc command configs enabled

2014-11-17 Thread Albert ARIBAUD
Hello Vikas,

(nitpicking) can you replace '+' in the subject with 'and' ?

(nitpicking yet more) can you keep the action form for the subject
rather than action done, i.e., stv0991: enable default and misc
command configs

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot