Re: [U-Boot] [PATCH v4 3/7] net: fec_mxc: Add support for Vybrid VF610

2013-06-03 Thread Stefano Babic 
On 28/05/2013 10:55, Alison Wang wrote:
 This patch adds FEC support for Vybrid VF610 platform.
 
 In function fec_open(), RCR register is only set as RGMII mode. But RCR
 register should be set as RMII mode for VF610 platform.
 This configuration is already done in fec_reg_setup(), so this piece of
 code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII /
 FEC_RCNTRL_MII_MODE bits.
 
 Signed-off-by: Alison Wang b18...@freescale.com
 Reviewed-by: Benoit Thebaudeau benoit.thebaud...@advansee.com
 ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v4 3/7] net: fec_mxc: Add support for Vybrid VF610

2013-05-28 Thread Alison Wang 
This patch adds FEC support for Vybrid VF610 platform.

In function fec_open(), RCR register is only set as RGMII mode. But RCR
register should be set as RMII mode for VF610 platform.
This configuration is already done in fec_reg_setup(), so this piece of
code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII /
FEC_RCNTRL_MII_MODE bits.

Signed-off-by: Alison Wang b18...@freescale.com
Reviewed-by: Benoit Thebaudeau benoit.thebaud...@advansee.com
---
Changes in v4: None

Changes in v3:
- Remove the changes for FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII / 
FEC_RCNTRL_MII_MODE bits, as they are already set in fec_reg_setup() 

Changes in v2:
- Use common FEC driver fec_mxc.c

 drivers/net/fec_mxc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 4dbcdca..da95e28 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -516,9 +516,7 @@ static int fec_open(struct eth_device *edev)
 #ifdef FEC_QUIRK_ENET_MAC
{
u32 ecr = readl(fec-eth-ecntrl)  ~FEC_ECNTRL_SPEED;
-   u32 rcr = (readl(fec-eth-r_cntrl) 
-   ~(FEC_RCNTRL_RMII | FEC_RCNTRL_RMII_10T)) |
-   FEC_RCNTRL_RGMII | FEC_RCNTRL_MII_MODE;
+   u32 rcr = readl(fec-eth-r_cntrl)  ~FEC_RCNTRL_RMII_10T;
if (speed == _1000BASET)
ecr |= FEC_ECNTRL_SPEED;
else if (speed != _100BASET)
-- 
1.8.0


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v4 3/7] net: fec_mxc: Add support for Vybrid VF610

2013-05-28 Thread Benoît Thébaudeau 
Hi Alison,

On Tuesday, May 28, 2013 10:55:43 AM, Alison Wang wrote:
 This patch adds FEC support for Vybrid VF610 platform.
 
 In function fec_open(), RCR register is only set as RGMII mode. But RCR
 register should be set as RMII mode for VF610 platform.
 This configuration is already done in fec_reg_setup(), so this piece of
 code could just leave untouched the FEC_RCNTRL_RGMII / FEC_RCNTRL_RMII /
 FEC_RCNTRL_MII_MODE bits.

[...]

Reviewed-by: Benoît Thébaudeau benoit.thebaud...@advansee.com

Best regards,
Benoît
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot