Re: [U-Boot] [PATCH v4 8/8] ata: ahci: Don't forget to clear upper address regs.

2019-10-12 Thread Tom Rini 
On Thu, Aug 22, 2019 at 12:26:56PM +0200, Frank Wunderlich wrote:

> From: Oleksandr Rybalko 
> 
> In 32bits mode upper bits need to be set to 0, otherwise controller will
> try to DMA into not existing memory and stops with error.
> 
> Tested-by: Frank Wunderlich 
> Signed-off-by: Frank Wunderlich 
> Signed-off-by: Oleksandr Rybalko 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v4 8/8] ata: ahci: Don't forget to clear upper address regs.

2019-08-22 Thread Frank Wunderlich 
From: Oleksandr Rybalko 

In 32bits mode upper bits need to be set to 0, otherwise controller will
try to DMA into not existing memory and stops with error.

Tested-by: Frank Wunderlich 
Signed-off-by: Frank Wunderlich 
Signed-off-by: Oleksandr Rybalko 
---
changes since v3: fix build warning on x86_64
changes since v2: none
---
 drivers/ata/ahci.c | 11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index e3135bb75f..3d782b0944 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -548,6 +548,7 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, u8 
port)
 {
struct ahci_ioports *pp = &(uc_priv->port[port]);
void __iomem *port_mmio = pp->port_mmio;
+   u64 dma_addr;
u32 port_status;
void __iomem *mem;
 
@@ -593,10 +594,12 @@ static int ahci_port_start(struct ahci_uc_priv *uc_priv, 
u8 port)
pp->cmd_tbl_sg =
(struct ahci_sg *)(uintptr_t)virt_to_phys((void *)mem);
 
-   writel_with_flush((unsigned long)pp->cmd_slot,
- port_mmio + PORT_LST_ADDR);
-
-   writel_with_flush(pp->rx_fis, port_mmio + PORT_FIS_ADDR);
+   dma_addr = (ulong)pp->cmd_slot;
+   writel_with_flush(dma_addr, port_mmio + PORT_LST_ADDR);
+   writel_with_flush(dma_addr >> 32, port_mmio + PORT_LST_ADDR_HI);
+   dma_addr = (ulong)pp->rx_fis;
+   writel_with_flush(dma_addr, port_mmio + PORT_FIS_ADDR);
+   writel_with_flush(dma_addr >> 32, port_mmio + PORT_FIS_ADDR_HI);
 
 #ifdef CONFIG_SUNXI_AHCI
sunxi_dma_init(port_mmio);
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot