Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Tue, Jun 19, 2018 at 8:33 PM, Vasily Khoruzhick wrote: > On Mon, Jun 18, 2018 at 11:56 PM, Jagan Teki wrote: >> >> This what[1] I changed on top of your changes, same issue. >> >> [1] https://paste.ubuntu.com/p/NjYyMk68P6/ > > It should be tested separately. Works for me, with md 0x01c11144 value as 0080 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Mon, Jun 18, 2018 at 11:56 PM, Jagan Teki wrote: > > This what[1] I changed on top of your changes, same issue. > > [1] https://paste.ubuntu.com/p/NjYyMk68P6/ It should be tested separately. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Tue, Jun 19, 2018 at 12:03 PM, Jagan Teki wrote: > On Tue, Jun 19, 2018 at 11:55 AM, Vasily Khoruzhick > wrote: >> On Mon, Jun 18, 2018 at 12:43 AM, Jagan Teki >> wrote: >>> >>> Don't have these hardware with me. >> >> Could you test this patch on your hardware when you get some time? >> >> https://github.com/anarsoul/u-boot-pine64/commit/a3f5d175a5ed0ece7a7720f1e665809c9f140850.patch > > On top of your changes or separately? This what[1] I changed on top of your changes, same issue. [1] https://paste.ubuntu.com/p/NjYyMk68P6/ ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Tue, Jun 19, 2018 at 11:55 AM, Vasily Khoruzhick wrote: > On Mon, Jun 18, 2018 at 12:43 AM, Jagan Teki wrote: >> >> Don't have these hardware with me. > > Could you test this patch on your hardware when you get some time? > > https://github.com/anarsoul/u-boot-pine64/commit/a3f5d175a5ed0ece7a7720f1e665809c9f140850.patch On top of your changes or separately? ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Mon, Jun 18, 2018 at 12:43 AM, Jagan Teki wrote: > > Don't have these hardware with me. Could you test this patch on your hardware when you get some time? https://github.com/anarsoul/u-boot-pine64/commit/a3f5d175a5ed0ece7a7720f1e665809c9f140850.patch It uses calibration without using new clock mode and it fixes eMMC on Pinebook for me as well. Also works fine on Pine64-LTS. If it works for you I'll clean it up and send it out. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Sat, Jun 16, 2018 at 11:15 PM, Vasily Khoruzhick wrote: > On Sat, Jun 16, 2018 at 2:47 AM, Jagan Teki wrote: >> On Wed, Jun 6, 2018 at 10:26 AM, Vasily Khoruzhick >> wrote: >>> eMMC seems to require new clocking mode and calibration on A64, >>> otherwise it is pretty unstable on some boards (e.g. Pinebook) >>> with some eMMCs. >>> >>> v2: - improve comment about calibration for eMMC on A64 >>> - simplify ifdef-s around configuring delays >>> v3: - fix fallout due to ifdef simplification in v2 >>> v4: - really fix ifdefs this time >>> v5: - add new option for SoCs without new mode switch in CCM >>> >>> Vasily Khoruzhick (3): >>> sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option >>> sunxi-mmc: use new mode on A64 >>> mmc: sunxi: run calibration on A64 >> >> I have still observing eMMC boot issue, this need to debug further > > It boots for me from eMMC on Pinebook and Pine64-LTS, thus I have no > hardware to debug it further. Don't have these hardware with me. > > Moreover, Linux also does calibration on A64 for eMMC, do you > experience any issues with eMMC in Linux? Yes I'm able to detect eMMC in Linux. So we need to investigate what makes failing mode. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Sat, Jun 16, 2018 at 2:47 AM, Jagan Teki wrote: > On Wed, Jun 6, 2018 at 10:26 AM, Vasily Khoruzhick wrote: >> eMMC seems to require new clocking mode and calibration on A64, >> otherwise it is pretty unstable on some boards (e.g. Pinebook) >> with some eMMCs. >> >> v2: - improve comment about calibration for eMMC on A64 >> - simplify ifdef-s around configuring delays >> v3: - fix fallout due to ifdef simplification in v2 >> v4: - really fix ifdefs this time >> v5: - add new option for SoCs without new mode switch in CCM >> >> Vasily Khoruzhick (3): >> sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option >> sunxi-mmc: use new mode on A64 >> mmc: sunxi: run calibration on A64 > > I have still observing eMMC boot issue, this need to debug further It boots for me from eMMC on Pinebook and Pine64-LTS, thus I have no hardware to debug it further. Moreover, Linux also does calibration on A64 for eMMC, do you experience any issues with eMMC in Linux? > U-Boot SPL 2018.07-rc1-00164-g117d5917d2 (Jun 16 2018 - 15:12:28 +0530) > DRAM: 1024 MiB > Trying to boot from MMC2 > unable to select a mode > mmc_load_image_raw_sector: mmc block read error > SPL: failed to boot from all boot devices > ### ERROR ### Please RESET the board ### > > Jagan. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Wed, Jun 6, 2018 at 10:26 AM, Vasily Khoruzhick wrote: > eMMC seems to require new clocking mode and calibration on A64, > otherwise it is pretty unstable on some boards (e.g. Pinebook) > with some eMMCs. > > v2: - improve comment about calibration for eMMC on A64 > - simplify ifdef-s around configuring delays > v3: - fix fallout due to ifdef simplification in v2 > v4: - really fix ifdefs this time > v5: - add new option for SoCs without new mode switch in CCM > > Vasily Khoruzhick (3): > sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option > sunxi-mmc: use new mode on A64 > mmc: sunxi: run calibration on A64 I have still observing eMMC boot issue, this need to debug further U-Boot SPL 2018.07-rc1-00164-g117d5917d2 (Jun 16 2018 - 15:12:28 +0530) DRAM: 1024 MiB Trying to boot from MMC2 unable to select a mode mmc_load_image_raw_sector: mmc block read error SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### Jagan. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
On Tue, Jun 05, 2018 at 09:56:26PM -0700, Vasily Khoruzhick wrote: > eMMC seems to require new clocking mode and calibration on A64, > otherwise it is pretty unstable on some boards (e.g. Pinebook) > with some eMMCs. > > v2: - improve comment about calibration for eMMC on A64 > - simplify ifdef-s around configuring delays > v3: - fix fallout due to ifdef simplification in v2 > v4: - really fix ifdefs this time > v5: - add new option for SoCs without new mode switch in CCM Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v5 0/3] sunxi: fix eMMC stability issues on A64
eMMC seems to require new clocking mode and calibration on A64, otherwise it is pretty unstable on some boards (e.g. Pinebook) with some eMMCs. v2: - improve comment about calibration for eMMC on A64 - simplify ifdef-s around configuring delays v3: - fix fallout due to ifdef simplification in v2 v4: - really fix ifdefs this time v5: - add new option for SoCs without new mode switch in CCM Vasily Khoruzhick (3): sunxi-mmc: introduce new MMC_SUNXI_HAS_NEW_MODE_SWITCH option sunxi-mmc: use new mode on A64 mmc: sunxi: run calibration on A64 arch/arm/include/asm/arch-sunxi/mmc.h | 6 +- arch/arm/mach-sunxi/Kconfig | 2 ++ drivers/mmc/Kconfig | 4 drivers/mmc/sunxi_mmc.c | 13 + 4 files changed, 24 insertions(+), 1 deletion(-) -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
