Re: [U-Boot] [PATCH v5 00/27] ARM: tegra: Miscalleneous improvements

2019-04-15 Thread Tom Warren
Thierry,

I tried applying your 27 v5 patchset series here to my local 
u-boot-tegra/master + uboot/master (on the assumption that Simon's FDT patches 
had made it to TomR's master), and it failed on the first patch w/git-am. Using 
'patch' allowed it to be applied w/minor fixups/fuzz. The rest of the patches 
then applied w/git-am OK.

I'm building locally now (64-bit and 32-bit Tegra) and if all is well I'll send 
a new master to Denx (minus the Nano CL, since we're not yet ready to provide 
all the collateral docs) for Stephen's testframe to pick up, and if it all 
passes I can send it all to TomR in a PR later this week.

Tom

-Original Message-
From: Thierry Reding  
Sent: Monday, April 15, 2019 2:32 AM
To: Tom Warren ; Simon Glass 
Cc: Jonathan Hunter ; Stephen Warren 
; u-boot@lists.denx.de
Subject: [PATCH v5 00/27] ARM: tegra: Miscalleneous improvements

From: Thierry Reding 

Hi Tom, Stephen,

this in the fifth installment of this series of miscellaneous improvements for 
Tegra support. The main changes since the last version
are:

  - Add two patches from the "framebuffer carveout" series since Simon
has already picked up the libfdt and fdtdec specific parts.
  - Fix the MAC address regression found by Stephen's test system. This
is done by writing the MAC address to U-Boot's control DTB rather
than storing it in the environment and thereby confusing Ethernet
drivers if more than one device are present in the system.
  - I've also added the Jetson Nano patch to the series since it has
changed slightly. The issue of the pinmux spreadsheet is still open,
so this isn't quite ready to be merged, but I wanted to solicit more
feedback, so that this is already reviewed by the time the pinmux
spreadsheet issue is resolved.

Simon,

I've included another patch for a new fdtdec function in this series because 
the first user is introduced here. It'd be great if you could provide an 
Acked-by on the first patch so that Tom can pick it up and send out as part of 
the PR for the entire series once it's been reviewed and passed Stephen's test 
system.

The second patch is also required later in the series. There's no explicit 
maintainer for lib/string.c, but you show up in the output for 
scripts/get_maintainer.pl for the second patch, so perhaps you could also give 
an Acked-by on that?

Alternatively you could pick up patches 1 and 2 so that Tom can base his PR on 
your tree (or master, later on), if that's what you guys prefer.
Actually, this might be better anyway, since there might be a tiny merge 
conflict between the fdtdec patch in this series and the other ones that I sent 
out earlier.

Thanks,
Thierry

Thierry Reding (27):
  fdtdec: Add fdtdec_set_ethernet_mac_address()
  lib: Implement strndup()
  ARM: tegra: Fix mux type for disp1 and disp2 clocks on Tegra210
  ARM: tegra: Remove disp1 clock initialization on Tegra210
  ARM: tegra: Use common header for PMU declarations
  ARM: tegra: Guard clock code with a Kconfig symbol
  ARM: tegra: Guard GP pad control code with a Kconfig symbol
  ARM: tegra: Guard memory controller code with a Kconfig symbol
  ARM: tegra: Guard pin controller code with a Kconfig symbol
  ARM: tegra: Guard powergate code with a Kconfig symbol
  ARM: tegra: Fix save_boot_params() prototype
  ARM: tegra: Allow boards to override boot target devices
  ARM: tegra: Support TZ-only access to PMC
  ARM: tegra: Workaround UDC boot issues only if necessary
  ARM: tegra: Restore DRAM bank count
  ARM: tegra: Unify Tegra186 builds
  ARM: tegra: Implement cboot_save_boot_params() in C
  ARM: tegra: Implement cboot_get_ethaddr()
  ARM: tegra: Import cbootargs value from cboot DTB
  ARM: tegra: Enable position independent build for 64-bit
  p2371-2180: Pass Ethernet MAC to the kernel
  p2771-: Pass Ethernet MAC to the kernel
  p2371-2180: Add support for framebuffer carveouts
  p2771-: Add support for framebuffer carveouts
  ARM: tegra: Rename pcie-controller to pcie
  ARM: tegra: Mark built-in Ethernet as default on Jetson TX2
  ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support

 arch/arm/dts/Makefile |   3 +-
 arch/arm/dts/tegra124-apalis.dts  |   2 +-
 arch/arm/dts/tegra124-cei-tk1-som.dts |   2 +-
 arch/arm/dts/tegra124-jetson-tk1.dts  |   2 +-
 arch/arm/dts/tegra124.dtsi|   2 +-
 arch/arm/dts/tegra186-p2771--000.dts  |   2 +-
 arch/arm/dts/tegra186-p2771--500.dts  |   2 +-
 arch/arm/dts/tegra186-p2771-.dtsi |   2 +
 arch/arm/dts/tegra186.dtsi|   2 +-
 arch/arm/dts/tegra20-harmony.dts  |   2 +-
 arch/arm/dts/tegra20-trimslice.dts|   2 +-
 arch/arm/dts/tegra20.dtsi |   2 +-
 arch/arm/dts/tegra210-p2371-2180.dts  |   2 +-
 arch/arm/dts/tegra210-p3450-.dts  | 135 
 arch/arm/dts/tegra210.dtsi|   2 +-
 arch/arm/dts/tegra30-apalis.dt

[U-Boot] [PATCH v5 00/27] ARM: tegra: Miscalleneous improvements

2019-04-15 Thread Thierry Reding
From: Thierry Reding 

Hi Tom, Stephen,

this in the fifth installment of this series of miscellaneous
improvements for Tegra support. The main changes since the last version
are:

  - Add two patches from the "framebuffer carveout" series since Simon
has already picked up the libfdt and fdtdec specific parts.
  - Fix the MAC address regression found by Stephen's test system. This
is done by writing the MAC address to U-Boot's control DTB rather
than storing it in the environment and thereby confusing Ethernet
drivers if more than one device are present in the system.
  - I've also added the Jetson Nano patch to the series since it has
changed slightly. The issue of the pinmux spreadsheet is still open,
so this isn't quite ready to be merged, but I wanted to solicit more
feedback, so that this is already reviewed by the time the pinmux
spreadsheet issue is resolved.

Simon,

I've included another patch for a new fdtdec function in this series
because the first user is introduced here. It'd be great if you could
provide an Acked-by on the first patch so that Tom can pick it up and
send out as part of the PR for the entire series once it's been reviewed
and passed Stephen's test system.

The second patch is also required later in the series. There's no
explicit maintainer for lib/string.c, but you show up in the output for
scripts/get_maintainer.pl for the second patch, so perhaps you could
also give an Acked-by on that?

Alternatively you could pick up patches 1 and 2 so that Tom can base his
PR on your tree (or master, later on), if that's what you guys prefer.
Actually, this might be better anyway, since there might be a tiny merge
conflict between the fdtdec patch in this series and the other ones that
I sent out earlier.

Thanks,
Thierry

Thierry Reding (27):
  fdtdec: Add fdtdec_set_ethernet_mac_address()
  lib: Implement strndup()
  ARM: tegra: Fix mux type for disp1 and disp2 clocks on Tegra210
  ARM: tegra: Remove disp1 clock initialization on Tegra210
  ARM: tegra: Use common header for PMU declarations
  ARM: tegra: Guard clock code with a Kconfig symbol
  ARM: tegra: Guard GP pad control code with a Kconfig symbol
  ARM: tegra: Guard memory controller code with a Kconfig symbol
  ARM: tegra: Guard pin controller code with a Kconfig symbol
  ARM: tegra: Guard powergate code with a Kconfig symbol
  ARM: tegra: Fix save_boot_params() prototype
  ARM: tegra: Allow boards to override boot target devices
  ARM: tegra: Support TZ-only access to PMC
  ARM: tegra: Workaround UDC boot issues only if necessary
  ARM: tegra: Restore DRAM bank count
  ARM: tegra: Unify Tegra186 builds
  ARM: tegra: Implement cboot_save_boot_params() in C
  ARM: tegra: Implement cboot_get_ethaddr()
  ARM: tegra: Import cbootargs value from cboot DTB
  ARM: tegra: Enable position independent build for 64-bit
  p2371-2180: Pass Ethernet MAC to the kernel
  p2771-: Pass Ethernet MAC to the kernel
  p2371-2180: Add support for framebuffer carveouts
  p2771-: Add support for framebuffer carveouts
  ARM: tegra: Rename pcie-controller to pcie
  ARM: tegra: Mark built-in Ethernet as default on Jetson TX2
  ARM: tegra: Add NVIDIA Jetson Nano Developer Kit support

 arch/arm/dts/Makefile |   3 +-
 arch/arm/dts/tegra124-apalis.dts  |   2 +-
 arch/arm/dts/tegra124-cei-tk1-som.dts |   2 +-
 arch/arm/dts/tegra124-jetson-tk1.dts  |   2 +-
 arch/arm/dts/tegra124.dtsi|   2 +-
 arch/arm/dts/tegra186-p2771--000.dts  |   2 +-
 arch/arm/dts/tegra186-p2771--500.dts  |   2 +-
 arch/arm/dts/tegra186-p2771-.dtsi |   2 +
 arch/arm/dts/tegra186.dtsi|   2 +-
 arch/arm/dts/tegra20-harmony.dts  |   2 +-
 arch/arm/dts/tegra20-trimslice.dts|   2 +-
 arch/arm/dts/tegra20.dtsi |   2 +-
 arch/arm/dts/tegra210-p2371-2180.dts  |   2 +-
 arch/arm/dts/tegra210-p3450-.dts  | 135 
 arch/arm/dts/tegra210.dtsi|   2 +-
 arch/arm/dts/tegra30-apalis.dts   |   2 +-
 arch/arm/dts/tegra30-beaver.dts   |   2 +-
 arch/arm/dts/tegra30-cardhu.dts   |   2 +-
 arch/arm/dts/tegra30.dtsi |   2 +-
 arch/arm/include/asm/arch-tegra/cboot.h   |  45 ++
 arch/arm/include/asm/arch-tegra/pmc.h |  20 +-
 .../asm/{arch-tegra20 => arch-tegra}/pmu.h|   6 +-
 arch/arm/include/asm/arch-tegra/tegra.h   |   6 +
 arch/arm/include/asm/arch-tegra114/pmu.h  |  12 -
 arch/arm/include/asm/arch-tegra124/pmu.h  |  13 -
 arch/arm/include/asm/arch-tegra210/pmu.h  |  13 -
 arch/arm/include/asm/arch-tegra30/pmu.h   |  12 -
 arch/arm/mach-tegra/Kconfig   |  32 +
 arch/arm/mach-tegra/Makefile  |  16 +-
 arch/arm/mach-tegra/board.c   |  41 +-
 arch/arm/mach-tegra/board186.c|  32 -
 arch/arm/mach-tegra/board2.c