Re: [U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox
Hi Heinrich, On 11 June 2018 at 23:38, Heinrich Schuchardt wrote: > On 06/12/2018 07:26 AM, Simon Glass wrote: >> This does not work at present and gives the following error: >> >> output: 'ld.bfd: read in flex scanner failed >> scripts/Makefile.lib:390: recipe for target >> 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed >> >> It may be possible to figure this out with suitable linker magic but it >> does not seem to be easy. Also, we will be able to run the tests on >> sandbox without using the miniapp. >> >> So for now at least, disable this option. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v5: >> - Add new patch to disallow CMD_BOOTEFI_SELFTEST on sandbox >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> lib/efi_selftest/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/efi_selftest/Kconfig b/lib/efi_selftest/Kconfig >> index 59f9f36801..b52696778d 100644 >> --- a/lib/efi_selftest/Kconfig >> +++ b/lib/efi_selftest/Kconfig >> @@ -1,6 +1,6 @@ >> config CMD_BOOTEFI_SELFTEST >> bool "Allow booting an EFI efi_selftest" >> - depends on CMD_BOOTEFI >> + depends on CMD_BOOTEFI && !SANDBOX > > It is sufficient to change the following line in > lib/efi_selftest/Makefile to exclude building of > efi_selftest_startimage_exit.o and > efi_selftest_startimage_return.o: > > -ifeq ($(CONFIG_X86_64),) > +ifeq ($(CONFIG_X86_64)$(SANDBOX),) > > This way we can run all other tests. It can build them but they don't work for me. I would like to leave this as future work as there have been plenty of changes to this long-running series already. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox
On 06/12/2018 07:26 AM, Simon Glass wrote: > This does not work at present and gives the following error: > > output: 'ld.bfd: read in flex scanner failed > scripts/Makefile.lib:390: recipe for target > 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed > > It may be possible to figure this out with suitable linker magic but it > does not seem to be easy. Also, we will be able to run the tests on > sandbox without using the miniapp. > > So for now at least, disable this option. > > Signed-off-by: Simon Glass > --- > > Changes in v5: > - Add new patch to disallow CMD_BOOTEFI_SELFTEST on sandbox > > Changes in v4: None > Changes in v3: None > Changes in v2: None > > lib/efi_selftest/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_selftest/Kconfig b/lib/efi_selftest/Kconfig > index 59f9f36801..b52696778d 100644 > --- a/lib/efi_selftest/Kconfig > +++ b/lib/efi_selftest/Kconfig > @@ -1,6 +1,6 @@ > config CMD_BOOTEFI_SELFTEST > bool "Allow booting an EFI efi_selftest" > - depends on CMD_BOOTEFI > + depends on CMD_BOOTEFI && !SANDBOX It is sufficient to change the following line in lib/efi_selftest/Makefile to exclude building of efi_selftest_startimage_exit.o and efi_selftest_startimage_return.o: -ifeq ($(CONFIG_X86_64),) +ifeq ($(CONFIG_X86_64)$(SANDBOX),) This way we can run all other tests. Best regards Heinrich > imply FAT > imply FAT_WRITE > help > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v5 01/13] efi: Don't allow CMD_BOOTEFI_SELFTEST on sandbox
This does not work at present and gives the following error: output: 'ld.bfd: read in flex scanner failed scripts/Makefile.lib:390: recipe for target 'lib/efi_selftest/efi_selftest_miniapp_return_efi.so' failed It may be possible to figure this out with suitable linker magic but it does not seem to be easy. Also, we will be able to run the tests on sandbox without using the miniapp. So for now at least, disable this option. Signed-off-by: Simon Glass --- Changes in v5: - Add new patch to disallow CMD_BOOTEFI_SELFTEST on sandbox Changes in v4: None Changes in v3: None Changes in v2: None lib/efi_selftest/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/efi_selftest/Kconfig b/lib/efi_selftest/Kconfig index 59f9f36801..b52696778d 100644 --- a/lib/efi_selftest/Kconfig +++ b/lib/efi_selftest/Kconfig @@ -1,6 +1,6 @@ config CMD_BOOTEFI_SELFTEST bool "Allow booting an EFI efi_selftest" - depends on CMD_BOOTEFI + depends on CMD_BOOTEFI && !SANDBOX imply FAT imply FAT_WRITE help -- 2.18.0.rc1.244.gcf134e6275-goog ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
