Re: [U-Boot] [PATCH v6 00/15] Add Support for eMMC in Am65x-evm
Hi, On 05/06/19 9:16 AM, Lokesh Vutla wrote: > > > On 04/06/19 11:57 PM, Andreas Dannenberg wrote: >> On Tue, Jun 04, 2019 at 09:32:21PM +0530, Lokesh Vutla wrote: >>> >>> >>> On 04/06/19 6:46 PM, Faiz Abbas wrote: Add Support for eMMC in TI's AM65x-evm. The series starts by syncing the sdhci0 node from the kernel. Then it adds APIs and changes to the driver required for handling the driver's integrated phy. The current maximum supported speed is DDR52. Higher speeds and tuning support will be added in a subsequent series. Changes in v6: 1. Squashed one more dependency for clk_200mhz from Andreas's patches[1] into patch 1. Patches now build without any help from the other series. 2. Improved line wrapping in patch 8. >>> >>> Thanks for the quick update. For the entire series: >>> >>> Tested-by: Lokesh Vutla >> >> Seems like the test coverage was limited. >> >> While eMMC (sdhci0) works when booting from SD card (sdhci1) the eMMC >> probe fails when booting from eMMC itself defeating the main purpose of >> a series adding eMMC support. > > Series talks about the eMMC support and not the eMMC boot support. So I did > verify what is claimed. Anyways it is a valid bug you pointed out. > > Faiz, > Can you please re post with the fix incorporated. > Sending one more version. Thanks, Faiz ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 00/15] Add Support for eMMC in Am65x-evm
On 04/06/19 11:57 PM, Andreas Dannenberg wrote:
> On Tue, Jun 04, 2019 at 09:32:21PM +0530, Lokesh Vutla wrote:
>>
>>
>> On 04/06/19 6:46 PM, Faiz Abbas wrote:
>>> Add Support for eMMC in TI's AM65x-evm. The series starts
>>> by syncing the sdhci0 node from the kernel. Then it adds APIs and
>>> changes to the driver required for handling the driver's integrated
>>> phy. The current maximum supported speed is DDR52. Higher speeds and
>>> tuning support will be added in a subsequent series.
>>>
>>> Changes in v6:
>>> 1. Squashed one more dependency for clk_200mhz from Andreas's patches[1]
>>>into patch 1. Patches now build without any help from the other series.
>>>
>>> 2. Improved line wrapping in patch 8.
>>
>> Thanks for the quick update. For the entire series:
>>
>> Tested-by: Lokesh Vutla
>
> Seems like the test coverage was limited.
>
> While eMMC (sdhci0) works when booting from SD card (sdhci1) the eMMC
> probe fails when booting from eMMC itself defeating the main purpose of
> a series adding eMMC support.
Series talks about the eMMC support and not the eMMC boot support. So I did
verify what is claimed. Anyways it is a valid bug you pointed out.
Faiz,
Can you please re post with the fix incorporated.
Thanks and regards,
Lokesh
>
> "sdhci@4f8 - probe failed: -22"
>
> I did some debugging and tracked this down to a missing drive strength
> setting on the R5 DTS file:
>
>
> $ git diff
> diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts
> b/arch/arm/dts/k3-am654-r5-base-board.dts
> index 2f178c8b07..b10df50ef9 100644
> --- a/arch/arm/dts/k3-am654-r5-base-board.dts
> +++ b/arch/arm/dts/k3-am654-r5-base-board.dts
> @@ -186,6 +186,7 @@
> clock-names = "clk_xin";
> clocks = <_200mhz>;
> /delete-property/ power-domains;
> + ti,driver-strength-ohm = <50>;
> };
>
> {
>
>
> Can we please have this added.
>
>
> With this change added and SYSFW loader series applied I can boot all
> the way to U-Boot prompt on AM654x EVM from eMMC.
>
> Also SYSFW loader series no longer applies on top of this; will re-post
> a rebased/refactored version to be used on top of this series.
>
>
> --
> Andreas Dannenberg
> Texas Instruments Inc
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 00/15] Add Support for eMMC in Am65x-evm
On Tue, Jun 04, 2019 at 09:32:21PM +0530, Lokesh Vutla wrote:
>
>
> On 04/06/19 6:46 PM, Faiz Abbas wrote:
> > Add Support for eMMC in TI's AM65x-evm. The series starts
> > by syncing the sdhci0 node from the kernel. Then it adds APIs and
> > changes to the driver required for handling the driver's integrated
> > phy. The current maximum supported speed is DDR52. Higher speeds and
> > tuning support will be added in a subsequent series.
> >
> > Changes in v6:
> > 1. Squashed one more dependency for clk_200mhz from Andreas's patches[1]
> >into patch 1. Patches now build without any help from the other series.
> >
> > 2. Improved line wrapping in patch 8.
>
> Thanks for the quick update. For the entire series:
>
> Tested-by: Lokesh Vutla
Seems like the test coverage was limited.
While eMMC (sdhci0) works when booting from SD card (sdhci1) the eMMC
probe fails when booting from eMMC itself defeating the main purpose of
a series adding eMMC support.
"sdhci@4f8 - probe failed: -22"
I did some debugging and tracked this down to a missing drive strength
setting on the R5 DTS file:
$ git diff
diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts
b/arch/arm/dts/k3-am654-r5-base-board.dts
index 2f178c8b07..b10df50ef9 100644
--- a/arch/arm/dts/k3-am654-r5-base-board.dts
+++ b/arch/arm/dts/k3-am654-r5-base-board.dts
@@ -186,6 +186,7 @@
clock-names = "clk_xin";
clocks = <_200mhz>;
/delete-property/ power-domains;
+ ti,driver-strength-ohm = <50>;
};
{
Can we please have this added.
With this change added and SYSFW loader series applied I can boot all
the way to U-Boot prompt on AM654x EVM from eMMC.
Also SYSFW loader series no longer applies on top of this; will re-post
a rebased/refactored version to be used on top of this series.
--
Andreas Dannenberg
Texas Instruments Inc
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v6 00/15] Add Support for eMMC in Am65x-evm
On 04/06/19 6:46 PM, Faiz Abbas wrote: > Add Support for eMMC in TI's AM65x-evm. The series starts > by syncing the sdhci0 node from the kernel. Then it adds APIs and > changes to the driver required for handling the driver's integrated > phy. The current maximum supported speed is DDR52. Higher speeds and > tuning support will be added in a subsequent series. > > Changes in v6: > 1. Squashed one more dependency for clk_200mhz from Andreas's patches[1] >into patch 1. Patches now build without any help from the other series. > > 2. Improved line wrapping in patch 8. Thanks for the quick update. For the entire series: Tested-by: Lokesh Vutla Thanks and regards, Lokesh ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v6 00/15] Add Support for eMMC in Am65x-evm
Add Support for eMMC in TI's AM65x-evm. The series starts by syncing the sdhci0 node from the kernel. Then it adds APIs and changes to the driver required for handling the driver's integrated phy. The current maximum supported speed is DDR52. Higher speeds and tuning support will be added in a subsequent series. Changes in v6: 1. Squashed one more dependency for clk_200mhz from Andreas's patches[1] into patch 1. Patches now build without any help from the other series. 2. Improved line wrapping in patch 8. Changes in v5: Patches were tested with Andreas's system firmware patches[1] but can now be independently merged cleanly on latest U-boot. Changes in v4: 1. Dropped the patch including regmap_read_poll_timeout() because that support was already added by someone else 2. Fixed a NULL pointer exception in patch 8. 3. Rebased on top of latest master 4. Added extra patches to support GPT partitions in user partition 5. Added Support for environment in eMMC by default Changes in v3: Patch 9: Got rid of variable ret Changes in v2: Patch 9: Fixed return value Patch 12: Fixed spacing [1] https://www.mail-archive.com/u-boot@lists.denx.de/msg325811.html Faiz Abbas (15): arm64: dts: k3: Sync sdhci0 node from kernel and change driver name mmc: am654_sdhci: Remove quirks regmap: Add API regmap_init_mem_index() mmc: sdhci: Add support for sdhci-caps-mask mmc: sdhci: Make sdhci_set_clock() non static arm: dts: k3: Add phy specific properties to SD card node mmc: sdhci: Make set_ios_post() return int mmc: am654_sdhci: Add Support for PHY configs: am65x_evm: Enable CONFIG_REGMAP mmc: am654_sdhci: Use f_max in mmc_config mmc: sdhci: Add support for HOST_CONTROL2 and setting UHS timings mmc: am654_sdhci: Add a platform specific set_control_reg() callback configs: am65x: Add configs to support environment in eMMC am65x_evm: Add Support for creating a filesystem GPT partition in eMMC configs: am65x_evm_a53: Add Support for creating GPT partitions arch/arm/dts/k3-am65-main.dtsi | 22 ++ arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 30 +- arch/arm/dts/k3-am654-base-board.dts | 28 ++ arch/arm/dts/k3-am654-r5-base-board.dts | 38 +++ configs/am65x_evm_a53_defconfig | 11 +- configs/am65x_evm_r5_defconfig | 4 +- drivers/core/regmap.c| 42 +++ drivers/mmc/Kconfig | 9 +- drivers/mmc/Makefile | 2 +- drivers/mmc/am654_sdhci.c| 333 +++ drivers/mmc/k3_arsan_sdhci.c | 109 -- drivers/mmc/sdhci.c | 47 ++- drivers/mmc/xenon_sdhci.c| 4 +- drivers/mmc/zynq_sdhci.c | 31 +- include/configs/am65x_evm.h | 19 +- include/regmap.h | 2 + include/sdhci.h | 22 +- 17 files changed, 568 insertions(+), 185 deletions(-) create mode 100644 drivers/mmc/am654_sdhci.c delete mode 100644 drivers/mmc/k3_arsan_sdhci.c -- 2.19.2 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
