Re: [U-Boot] [PATCH v7] Introduced btrfs file-system with btrload command

2013-03-15 Thread Tom Rini
On Thu, Mar 14, 2013 at 12:35:46PM +, Adnan Ali wrote:

> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.

OK, sorry for not doing this part sooner, but I compared the btrfs code
in syslinux to your code and there's a lot of whitespace problems in
fs/btrfs/btrfs.c that you:
trini@bill-the-cat:~/work/u-boot/u-boot$ ./tools/checkpatch.pl -f
fs/btrfs/btrfs.c  | grep ^ERROR | wc -l
320
trini@bill-the-cat:~/work/u-boot/u-boot$ ./tools/checkpatch.pl -f
~/work/syslinux/core/fs/btrfs/btrfs.c | grep ^ERR | wc -l
7

Please fix this, use whitespace consistent with the rest of the file for
the U-Boot specific functions you're adding and as Simon noted, 'char'
for a return type on btrfs_ls isn't really right (please follow fat or
ext* for examples).

Thanks and again, sorry for not noticing this sooner in the reviews.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v7] Introduced btrfs file-system with btrload command

2013-03-15 Thread Adnan Ali

Hi

On 15/03/13 00:00, Simon Glass wrote:

Hi,

On Thu, Mar 14, 2013 at 5:35 AM, Adnan Ali  wrote:

Introduces btrfs file-system to read file from
volume/sub-volumes with btrload command. This
implementation has read-only support.
This btrfs implementation is based on syslinux btrfs
code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.

v7: patch re-formated.
v6: patch re-formated.
v5: merged with master.
v4: btrls command added.

Signed-off-by: Adnan Ali 

This is close enough I think. You shouldn't have 'char' return values
on the fs.h interface functions, and no blank line after 'return'. I
will leave it to Tom to see if he is happy with the command
parameters.

Thanks.

Acked-by: Simon Glass 


   Thanks ;)





---
  Makefile   |1 +
  common/Makefile|1 +
  common/cmd_btr.c   |   65 +++
  fs/btrfs/Makefile  |   51 ++
  fs/btrfs/btrfs.c   | 1357 
  fs/fs.c|   10 +
  include/btrfs.h|  416 ++
  include/config_fallbacks.h |4 +
  include/crc.h  |8 +
  include/fs.h   |1 +
  lib/Makefile   |1 +
  lib/crc32_c.c  |   40 ++
  12 files changed, 1955 insertions(+)
  create mode 100644 common/cmd_btr.c
  create mode 100644 fs/btrfs/Makefile
  create mode 100644 fs/btrfs/btrfs.c
  create mode 100644 include/btrfs.h
  create mode 100644 lib/crc32_c.c



Thanks

Adnan Ali
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH v7] Introduced btrfs file-system with btrload command

2013-03-14 Thread Simon Glass
Hi,

On Thu, Mar 14, 2013 at 5:35 AM, Adnan Ali  wrote:
> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
>
> v7: patch re-formated.
> v6: patch re-formated.
> v5: merged with master.
> v4: btrls command added.
>
> Signed-off-by: Adnan Ali 

This is close enough I think. You shouldn't have 'char' return values
on the fs.h interface functions, and no blank line after 'return'. I
will leave it to Tom to see if he is happy with the command
parameters.

Thanks.

Acked-by: Simon Glass 

> ---
>  Makefile   |1 +
>  common/Makefile|1 +
>  common/cmd_btr.c   |   65 +++
>  fs/btrfs/Makefile  |   51 ++
>  fs/btrfs/btrfs.c   | 1357 
> 
>  fs/fs.c|   10 +
>  include/btrfs.h|  416 ++
>  include/config_fallbacks.h |4 +
>  include/crc.h  |8 +
>  include/fs.h   |1 +
>  lib/Makefile   |1 +
>  lib/crc32_c.c  |   40 ++
>  12 files changed, 1955 insertions(+)
>  create mode 100644 common/cmd_btr.c
>  create mode 100644 fs/btrfs/Makefile
>  create mode 100644 fs/btrfs/btrfs.c
>  create mode 100644 include/btrfs.h
>  create mode 100644 lib/crc32_c.c
>
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v7] Introduced btrfs file-system with btrload command

2013-03-14 Thread Adnan Ali
Introduces btrfs file-system to read file from
volume/sub-volumes with btrload command. This
implementation has read-only support.
This btrfs implementation is based on syslinux btrfs
code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.

v7: patch re-formated.
v6: patch re-formated.
v5: merged with master.
v4: btrls command added.

Signed-off-by: Adnan Ali 
---
 Makefile   |1 +
 common/Makefile|1 +
 common/cmd_btr.c   |   65 +++
 fs/btrfs/Makefile  |   51 ++
 fs/btrfs/btrfs.c   | 1357 
 fs/fs.c|   10 +
 include/btrfs.h|  416 ++
 include/config_fallbacks.h |4 +
 include/crc.h  |8 +
 include/fs.h   |1 +
 lib/Makefile   |1 +
 lib/crc32_c.c  |   40 ++
 12 files changed, 1955 insertions(+)
 create mode 100644 common/cmd_btr.c
 create mode 100644 fs/btrfs/Makefile
 create mode 100644 fs/btrfs/btrfs.c
 create mode 100644 include/btrfs.h
 create mode 100644 lib/crc32_c.c

diff --git a/Makefile b/Makefile
index 55bd55c..b3da594 100644
--- a/Makefile
+++ b/Makefile
@@ -257,6 +257,7 @@ endif
 LIBS-$(CONFIG_OF_EMBED) += dts/libdts.o
 LIBS-y += arch/$(ARCH)/lib/lib$(ARCH).o
 LIBS-y += fs/libfs.o \
+fs/btrfs/libbtrfs.o \
fs/cbfs/libcbfs.o \
fs/cramfs/libcramfs.o \
fs/ext4/libext4fs.o \
diff --git a/common/Makefile b/common/Makefile
index 719fc23..d1fae56 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -73,6 +73,7 @@ COBJS-$(CONFIG_CMD_BEDBUG) += bedbug.o cmd_bedbug.o
 COBJS-$(CONFIG_CMD_BMP) += cmd_bmp.o
 COBJS-$(CONFIG_CMD_BOOTLDR) += cmd_bootldr.o
 COBJS-$(CONFIG_CMD_BOOTSTAGE) += cmd_bootstage.o
+COBJS-$(CONFIG_CMD_BTR) += cmd_btr.o
 COBJS-$(CONFIG_CMD_CACHE) += cmd_cache.o
 COBJS-$(CONFIG_CMD_CBFS) += cmd_cbfs.o
 COBJS-$(CONFIG_CMD_CONSOLE) += cmd_console.o
diff --git a/common/cmd_btr.c b/common/cmd_btr.c
new file mode 100644
index 000..846c0f1
--- /dev/null
+++ b/common/cmd_btr.c
@@ -0,0 +1,65 @@
+/*
+ * (C) Copyright 2013 Codethink Limited
+ * Btrfs port to Uboot by
+ * Adnan Ali 
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+/*
+ * Boot support
+ */
+#include 
+#include 
+
+char subvolname[BTRFS_MAX_SUBVOL_NAME];
+
+int do_btr_fsload(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+   if (argc > 5)
+   strcpy(subvolname, argv[5]);
+   else
+   strcpy(subvolname, "");
+
+   return do_load(cmdtp, flag, argc, argv, FS_TYPE_BTR, 16);
+}
+
+
+U_BOOT_CMD(
+   btrload,7,  0,  do_btr_fsload,
+   "load binary file from a btr filesystem",
+   " [][subvol_name]\n"
+   "- Load binary file 'filename' from 'dev' on 'interface'\n"
+   "  to address 'addr' from better filesystem.\n"
+   "  the load stops on end of file.\n"
+   "  subvol_name is used read that file from this subvolume.\n"
+   "  All numeric parameters are assumed to be hex."
+);
+
+static int do_btr_ls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+{
+return do_ls(cmdtp, flag, argc, argv, FS_TYPE_BTR);
+}
+
+U_BOOT_CMD(
+btrls,  4,  1,  do_btr_ls,
+"list files in a directory (default /)",
+" [] [directory]\n"
+"- list files from 'dev' on 'interface' in a 'directory'"
+);
+
diff --git a/fs/btrfs/Makefile b/fs/btrfs/Makefile
new file mode 100644
index 000..a9e2021
--- /dev/null
+++ b/fs/btrfs/Makefile
@@ -0,0 +1,51 @@
+#
+# (C) Copyright 2006
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# (C) Copyright 2003
+# Pavel Bartusek, Sysgo Real-Time Solutions AG, p...@sysgo.de
+#
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# ME