Re: [U-Boot] [PATCH v7 22/27] sandbox: eth: Add ability to disable ping reply in sandbox eth driver

2015-03-23 Thread Simon Glass
On 22 March 2015 at 16:09, Joe Hershberger  wrote:
> This is needed to test the netretry functionality (make the command fail
> on a sandbox eth device).
>
> Signed-off-by: Joe Hershberger 
> Reviewed-by: Simon Glass 
>
> ---
>
> Changes in v7: None

Applied to u-boot-dm/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v7 22/27] sandbox: eth: Add ability to disable ping reply in sandbox eth driver

2015-03-22 Thread Joe Hershberger
This is needed to test the netretry functionality (make the command fail
on a sandbox eth device).

Signed-off-by: Joe Hershberger 
Reviewed-by: Simon Glass 

---

Changes in v7: None
Changes in v6:
-Add function comments
-Check array index bounds

Changes in v5:
-Use a function call to change mock driver behavior

Changes in v4:
-Add ability to disable ping reply in sandbox eth driver

Changes in v3: None
Changes in v2: None

 arch/sandbox/include/asm/eth.h | 15 +++
 drivers/net/sandbox.c  | 17 +
 2 files changed, 32 insertions(+)
 create mode 100644 arch/sandbox/include/asm/eth.h

diff --git a/arch/sandbox/include/asm/eth.h b/arch/sandbox/include/asm/eth.h
new file mode 100644
index 000..4b79ede
--- /dev/null
+++ b/arch/sandbox/include/asm/eth.h
@@ -0,0 +1,15 @@
+/*
+ * Copyright (c) 2015 National Instruments
+ *
+ * (C) Copyright 2015
+ * Joe Hershberger 
+ *
+ * SPDX-License-Identifier:GPL-2.0
+ */
+
+#ifndef __ETH_H
+#define __ETH_H
+
+void sandbox_eth_disable_response(int index, bool disable);
+
+#endif /* __ETH_H */
diff --git a/drivers/net/sandbox.c b/drivers/net/sandbox.c
index cb69a95..db115d0 100644
--- a/drivers/net/sandbox.c
+++ b/drivers/net/sandbox.c
@@ -29,6 +29,19 @@ struct eth_sandbox_priv {
int recv_packet_length;
 };
 
+static bool disabled[8] = {false};
+
+/*
+ * sandbox_eth_disable_response()
+ *
+ * index - The alias index (also DM seq number)
+ * disable - If non-zero, ignore sent packets and don't send mock response
+ */
+void sandbox_eth_disable_response(int index, bool disable)
+{
+   disabled[index] = disable;
+}
+
 static int sb_eth_start(struct udevice *dev)
 {
struct eth_sandbox_priv *priv = dev_get_priv(dev);
@@ -48,6 +61,10 @@ static int sb_eth_send(struct udevice *dev, void *packet, 
int length)
 
debug("eth_sandbox: Send packet %d\n", length);
 
+   if (dev->seq >= 0 && dev->seq < ARRAY_SIZE(disabled) &&
+   disabled[dev->seq])
+   return 0;
+
if (ntohs(eth->et_protlen) == PROT_ARP) {
struct arp_hdr *arp = packet + ETHER_HDR_SIZE;
 
-- 
1.7.11.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot