Re: [U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
On Thu, 2019-02-14 at 13:28 +0100, Marek Vasut wrote: > On 2/14/19 12:51 PM, Chee, Tien Fong wrote: > > > > On Wed, 2019-02-13 at 17:11 +0100, Marek Vasut wrote: > > > > > > On 2/13/19 3:18 PM, tien.fong.c...@intel.com wrote: > > > > > > > > > > > > From: Tien Fong Chee > > > > > > > > Adding some function declarations to the header file, so these > > > > functions can be referred by other C files. > > > > > > > > Signed-off-by: Tien Fong Chee > > > > --- > > > > include/image.h | 4 > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/include/image.h b/include/image.h > > > > index 83a2d41..f839443 100644 > > > > --- a/include/image.h > > > > +++ b/include/image.h > > > > @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); > > > > > > > > int fit_conf_find_compat(const void *fit, const void *fdt); > > > > int fit_conf_get_node(const void *fit, const char > > > > *conf_uname); > > > > +int fit_conf_get_prop_node_count(const void *fit, int noffset, > > > > + const char *prop_name); > > > > +int fit_conf_get_prop_node_index(const void *fit, int noffset, > > > > + const char *prop_name, int index); > > > Squash this patch with a patch adding those functions. > > Just to confirm again squashing this patch to the patch calling > > these > > function? > Yes Okay. > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
On 2/14/19 12:51 PM, Chee, Tien Fong wrote: > On Wed, 2019-02-13 at 17:11 +0100, Marek Vasut wrote: >> On 2/13/19 3:18 PM, tien.fong.c...@intel.com wrote: >>> >>> From: Tien Fong Chee >>> >>> Adding some function declarations to the header file, so these >>> functions can be referred by other C files. >>> >>> Signed-off-by: Tien Fong Chee >>> --- >>> include/image.h | 4 >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/include/image.h b/include/image.h >>> index 83a2d41..f839443 100644 >>> --- a/include/image.h >>> +++ b/include/image.h >>> @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); >>> >>> int fit_conf_find_compat(const void *fit, const void *fdt); >>> int fit_conf_get_node(const void *fit, const char *conf_uname); >>> +int fit_conf_get_prop_node_count(const void *fit, int noffset, >>> + const char *prop_name); >>> +int fit_conf_get_prop_node_index(const void *fit, int noffset, >>> + const char *prop_name, int index); >> Squash this patch with a patch adding those functions. > Just to confirm again squashing this patch to the patch calling these > function? Yes -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
On Wed, 2019-02-13 at 17:11 +0100, Marek Vasut wrote: > On 2/13/19 3:18 PM, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > Adding some function declarations to the header file, so these > > functions can be referred by other C files. > > > > Signed-off-by: Tien Fong Chee > > --- > > include/image.h | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/image.h b/include/image.h > > index 83a2d41..f839443 100644 > > --- a/include/image.h > > +++ b/include/image.h > > @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); > > > > int fit_conf_find_compat(const void *fit, const void *fdt); > > int fit_conf_get_node(const void *fit, const char *conf_uname); > > +int fit_conf_get_prop_node_count(const void *fit, int noffset, > > + const char *prop_name); > > +int fit_conf_get_prop_node_index(const void *fit, int noffset, > > + const char *prop_name, int index); > Squash this patch with a patch adding those functions. Just to confirm again squashing this patch to the patch calling these function? > > > > > /** > > * fit_conf_get_prop_node() - Get node refered to by a > > configuration > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
On Wed, 2019-02-13 at 17:11 +0100, Marek Vasut wrote: > On 2/13/19 3:18 PM, tien.fong.c...@intel.com wrote: > > > > From: Tien Fong Chee > > > > Adding some function declarations to the header file, so these > > functions can be referred by other C files. > > > > Signed-off-by: Tien Fong Chee > > --- > > include/image.h | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/include/image.h b/include/image.h > > index 83a2d41..f839443 100644 > > --- a/include/image.h > > +++ b/include/image.h > > @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); > > > > int fit_conf_find_compat(const void *fit, const void *fdt); > > int fit_conf_get_node(const void *fit, const char *conf_uname); > > +int fit_conf_get_prop_node_count(const void *fit, int noffset, > > + const char *prop_name); > > +int fit_conf_get_prop_node_index(const void *fit, int noffset, > > + const char *prop_name, int index); > Squash this patch with a patch adding those functions. Okay. > > > > > /** > > * fit_conf_get_prop_node() - Get node refered to by a > > configuration > > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
On 2/13/19 3:18 PM, tien.fong.c...@intel.com wrote: > From: Tien Fong Chee > > Adding some function declarations to the header file, so these > functions can be referred by other C files. > > Signed-off-by: Tien Fong Chee > --- > include/image.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/image.h b/include/image.h > index 83a2d41..f839443 100644 > --- a/include/image.h > +++ b/include/image.h > @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); > > int fit_conf_find_compat(const void *fit, const void *fdt); > int fit_conf_get_node(const void *fit, const char *conf_uname); > +int fit_conf_get_prop_node_count(const void *fit, int noffset, > + const char *prop_name); > +int fit_conf_get_prop_node_index(const void *fit, int noffset, > + const char *prop_name, int index); Squash this patch with a patch adding those functions. > /** > * fit_conf_get_prop_node() - Get node refered to by a configuration > -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v8 3/8] fit: Add function declarations to the header file
From: Tien Fong Chee Adding some function declarations to the header file, so these functions can be referred by other C files. Signed-off-by: Tien Fong Chee --- include/image.h | 4 1 file changed, 4 insertions(+) diff --git a/include/image.h b/include/image.h index 83a2d41..f839443 100644 --- a/include/image.h +++ b/include/image.h @@ -1041,6 +1041,10 @@ int fit_check_format(const void *fit); int fit_conf_find_compat(const void *fit, const void *fdt); int fit_conf_get_node(const void *fit, const char *conf_uname); +int fit_conf_get_prop_node_count(const void *fit, int noffset, + const char *prop_name); +int fit_conf_get_prop_node_index(const void *fit, int noffset, + const char *prop_name, int index); /** * fit_conf_get_prop_node() - Get node refered to by a configuration -- 2.2.0 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
