Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
Hi Bin, > On Aug 13, 2019, at 9:03 PM, Bin Meng wrote: > > Hi Aiden, > >> On Thu, Aug 8, 2019 at 10:42 PM Bin Meng wrote: >> >> Hi Aiden, >> >>> On Thu, Aug 8, 2019 at 10:35 PM Bin Meng wrote: >>> On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: Add slimbootloader board to run U-boot as a Slim Bootloader payload - Add new board/intel/slimbootloader directory with minimum codes - Add slimbootloader configuration files - Add doc/board/intel/slimbootloader.rst Signed-off-by: Aiden Park Reviewed-by: Bin Meng Reviewed-by: Andy Shevchenko --- Changes in v8: * Add a space between acronym and (definition) Changes in v7: * Adding slimbootloader.rst in index.rst Changes in v6: * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig * Move USB_STORAGE and USB_KEYBOARD to board Kconfig * Convert README to reST doc/board/intel/slimbootloader.rst Changes in v5: * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig Changes in v3: * Remove VENDOR_SLIMBOOTLOADER * Use VENDOR_INTEL * Move slimbootloader under board/intel/ * Enable generic CONFIGs in slimbootloader_defconfig * Add more description in board/intel/slimbootloader/README board/intel/Kconfig | 14 ++ board/intel/slimbootloader/Kconfig | 28 board/intel/slimbootloader/Makefile | 5 + board/intel/slimbootloader/slimbootloader.c | 21 +++ board/intel/slimbootloader/start.S | 9 + configs/slimbootloader_defconfig| 22 +++ doc/board/intel/index.rst | 1 + doc/board/intel/slimbootloader.rst | 174 include/configs/slimbootloader.h| 62 +++ 9 files changed, 336 insertions(+) create mode 100644 board/intel/slimbootloader/Kconfig create mode 100644 board/intel/slimbootloader/Makefile create mode 100644 board/intel/slimbootloader/slimbootloader.c create mode 100644 board/intel/slimbootloader/start.S create mode 100644 configs/slimbootloader_defconfig create mode 100644 doc/board/intel/slimbootloader.rst create mode 100644 include/configs/slimbootloader.h >>> >>> Tested-by: Bin Meng >> >> This time I successfully built the slimbootloader payload by following >> the instructions in the documentation and it succeeded to boot. Thanks >> for the efforts! >> >> However when testing zboot from U-Boot, I got: >> >> Error: Invalid Boot Flag (found 0x5aa5, expected 0xaa55) >> ## Kernel loading failed ... >> zboot - Boot bzImage >> >> The same kernel bzImage boots fine with "qemu-x86_defconfig" target. >> Did you see such issue? >> > > Any comments on this error? > Sorry for late response. I am still on international trip and not not able to connect network except for cellphone. I have verified Yocto Linux image, but will try to replicate the issue with your steps next week once you provides reproduce steps and test image. Thanks for your understanding in advance. >> This is not a show-stopper. I will apply this series soon. > > Regards, > Bin Best Regards, Aiden ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
Hi Aiden, On Thu, Aug 8, 2019 at 10:42 PM Bin Meng wrote: > > Hi Aiden, > > On Thu, Aug 8, 2019 at 10:35 PM Bin Meng wrote: > > > > On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: > > > > > > Add slimbootloader board to run U-boot as a Slim Bootloader payload > > > - Add new board/intel/slimbootloader directory with minimum codes > > > - Add slimbootloader configuration files > > > - Add doc/board/intel/slimbootloader.rst > > > > > > Signed-off-by: Aiden Park > > > Reviewed-by: Bin Meng > > > Reviewed-by: Andy Shevchenko > > > --- > > > Changes in v8: > > > * Add a space between acronym and (definition) > > > > > > Changes in v7: > > > * Adding slimbootloader.rst in index.rst > > > > > > Changes in v6: > > > * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig > > > * Move USB_STORAGE and USB_KEYBOARD to board Kconfig > > > * Convert README to reST doc/board/intel/slimbootloader.rst > > > > > > Changes in v5: > > > * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig > > > > > > Changes in v3: > > > * Remove VENDOR_SLIMBOOTLOADER > > > * Use VENDOR_INTEL > > > * Move slimbootloader under board/intel/ > > > * Enable generic CONFIGs in slimbootloader_defconfig > > > * Add more description in board/intel/slimbootloader/README > > > > > > board/intel/Kconfig | 14 ++ > > > board/intel/slimbootloader/Kconfig | 28 > > > board/intel/slimbootloader/Makefile | 5 + > > > board/intel/slimbootloader/slimbootloader.c | 21 +++ > > > board/intel/slimbootloader/start.S | 9 + > > > configs/slimbootloader_defconfig| 22 +++ > > > doc/board/intel/index.rst | 1 + > > > doc/board/intel/slimbootloader.rst | 174 > > > include/configs/slimbootloader.h| 62 +++ > > > 9 files changed, 336 insertions(+) > > > create mode 100644 board/intel/slimbootloader/Kconfig > > > create mode 100644 board/intel/slimbootloader/Makefile > > > create mode 100644 board/intel/slimbootloader/slimbootloader.c > > > create mode 100644 board/intel/slimbootloader/start.S > > > create mode 100644 configs/slimbootloader_defconfig > > > create mode 100644 doc/board/intel/slimbootloader.rst > > > create mode 100644 include/configs/slimbootloader.h > > > > > > > Tested-by: Bin Meng > > This time I successfully built the slimbootloader payload by following > the instructions in the documentation and it succeeded to boot. Thanks > for the efforts! > > However when testing zboot from U-Boot, I got: > > Error: Invalid Boot Flag (found 0x5aa5, expected 0xaa55) > ## Kernel loading failed ... > zboot - Boot bzImage > > The same kernel bzImage boots fine with "qemu-x86_defconfig" target. > Did you see such issue? > Any comments on this error? > This is not a show-stopper. I will apply this series soon. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
On Thu, Aug 8, 2019 at 10:54 PM Bin Meng wrote: > > On Thu, Aug 8, 2019 at 10:35 PM Bin Meng wrote: > > > > On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: > > > > > > Add slimbootloader board to run U-boot as a Slim Bootloader payload > > > - Add new board/intel/slimbootloader directory with minimum codes > > > - Add slimbootloader configuration files > > > - Add doc/board/intel/slimbootloader.rst > > > > > > Signed-off-by: Aiden Park > > > Reviewed-by: Bin Meng > > > Reviewed-by: Andy Shevchenko > > > --- > > > Changes in v8: > > > * Add a space between acronym and (definition) > > > > > > Changes in v7: > > > * Adding slimbootloader.rst in index.rst > > > > > > Changes in v6: > > > * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig > > > * Move USB_STORAGE and USB_KEYBOARD to board Kconfig > > > * Convert README to reST doc/board/intel/slimbootloader.rst > > > > > > Changes in v5: > > > * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig > > > > > > Changes in v3: > > > * Remove VENDOR_SLIMBOOTLOADER > > > * Use VENDOR_INTEL > > > * Move slimbootloader under board/intel/ > > > * Enable generic CONFIGs in slimbootloader_defconfig > > > * Add more description in board/intel/slimbootloader/README > > > > > > board/intel/Kconfig | 14 ++ > > > board/intel/slimbootloader/Kconfig | 28 > > > board/intel/slimbootloader/Makefile | 5 + > > > board/intel/slimbootloader/slimbootloader.c | 21 +++ > > > board/intel/slimbootloader/start.S | 9 + > > > configs/slimbootloader_defconfig| 22 +++ > > > doc/board/intel/index.rst | 1 + > > > doc/board/intel/slimbootloader.rst | 174 > > > include/configs/slimbootloader.h| 62 +++ > > > 9 files changed, 336 insertions(+) > > > create mode 100644 board/intel/slimbootloader/Kconfig > > > create mode 100644 board/intel/slimbootloader/Makefile > > > create mode 100644 board/intel/slimbootloader/slimbootloader.c > > > create mode 100644 board/intel/slimbootloader/start.S > > > create mode 100644 configs/slimbootloader_defconfig > > > create mode 100644 doc/board/intel/slimbootloader.rst > > > create mode 100644 include/configs/slimbootloader.h > > > > > > > Tested-by: Bin Meng > > applied to u-boot-x86, thanks! The patch missed slimbootloader board MAINTAINERS file that caused gitlab CI failure. I have added the MAINTAINERS to this commit. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
On Thu, Aug 8, 2019 at 10:35 PM Bin Meng wrote: > > On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: > > > > Add slimbootloader board to run U-boot as a Slim Bootloader payload > > - Add new board/intel/slimbootloader directory with minimum codes > > - Add slimbootloader configuration files > > - Add doc/board/intel/slimbootloader.rst > > > > Signed-off-by: Aiden Park > > Reviewed-by: Bin Meng > > Reviewed-by: Andy Shevchenko > > --- > > Changes in v8: > > * Add a space between acronym and (definition) > > > > Changes in v7: > > * Adding slimbootloader.rst in index.rst > > > > Changes in v6: > > * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig > > * Move USB_STORAGE and USB_KEYBOARD to board Kconfig > > * Convert README to reST doc/board/intel/slimbootloader.rst > > > > Changes in v5: > > * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig > > > > Changes in v3: > > * Remove VENDOR_SLIMBOOTLOADER > > * Use VENDOR_INTEL > > * Move slimbootloader under board/intel/ > > * Enable generic CONFIGs in slimbootloader_defconfig > > * Add more description in board/intel/slimbootloader/README > > > > board/intel/Kconfig | 14 ++ > > board/intel/slimbootloader/Kconfig | 28 > > board/intel/slimbootloader/Makefile | 5 + > > board/intel/slimbootloader/slimbootloader.c | 21 +++ > > board/intel/slimbootloader/start.S | 9 + > > configs/slimbootloader_defconfig| 22 +++ > > doc/board/intel/index.rst | 1 + > > doc/board/intel/slimbootloader.rst | 174 > > include/configs/slimbootloader.h| 62 +++ > > 9 files changed, 336 insertions(+) > > create mode 100644 board/intel/slimbootloader/Kconfig > > create mode 100644 board/intel/slimbootloader/Makefile > > create mode 100644 board/intel/slimbootloader/slimbootloader.c > > create mode 100644 board/intel/slimbootloader/start.S > > create mode 100644 configs/slimbootloader_defconfig > > create mode 100644 doc/board/intel/slimbootloader.rst > > create mode 100644 include/configs/slimbootloader.h > > > > Tested-by: Bin Meng applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
Hi Aiden, On Thu, Aug 8, 2019 at 10:35 PM Bin Meng wrote: > > On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: > > > > Add slimbootloader board to run U-boot as a Slim Bootloader payload > > - Add new board/intel/slimbootloader directory with minimum codes > > - Add slimbootloader configuration files > > - Add doc/board/intel/slimbootloader.rst > > > > Signed-off-by: Aiden Park > > Reviewed-by: Bin Meng > > Reviewed-by: Andy Shevchenko > > --- > > Changes in v8: > > * Add a space between acronym and (definition) > > > > Changes in v7: > > * Adding slimbootloader.rst in index.rst > > > > Changes in v6: > > * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig > > * Move USB_STORAGE and USB_KEYBOARD to board Kconfig > > * Convert README to reST doc/board/intel/slimbootloader.rst > > > > Changes in v5: > > * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig > > > > Changes in v3: > > * Remove VENDOR_SLIMBOOTLOADER > > * Use VENDOR_INTEL > > * Move slimbootloader under board/intel/ > > * Enable generic CONFIGs in slimbootloader_defconfig > > * Add more description in board/intel/slimbootloader/README > > > > board/intel/Kconfig | 14 ++ > > board/intel/slimbootloader/Kconfig | 28 > > board/intel/slimbootloader/Makefile | 5 + > > board/intel/slimbootloader/slimbootloader.c | 21 +++ > > board/intel/slimbootloader/start.S | 9 + > > configs/slimbootloader_defconfig| 22 +++ > > doc/board/intel/index.rst | 1 + > > doc/board/intel/slimbootloader.rst | 174 > > include/configs/slimbootloader.h| 62 +++ > > 9 files changed, 336 insertions(+) > > create mode 100644 board/intel/slimbootloader/Kconfig > > create mode 100644 board/intel/slimbootloader/Makefile > > create mode 100644 board/intel/slimbootloader/slimbootloader.c > > create mode 100644 board/intel/slimbootloader/start.S > > create mode 100644 configs/slimbootloader_defconfig > > create mode 100644 doc/board/intel/slimbootloader.rst > > create mode 100644 include/configs/slimbootloader.h > > > > Tested-by: Bin Meng This time I successfully built the slimbootloader payload by following the instructions in the documentation and it succeeded to boot. Thanks for the efforts! However when testing zboot from U-Boot, I got: Error: Invalid Boot Flag (found 0x5aa5, expected 0xaa55) ## Kernel loading failed ... zboot - Boot bzImage The same kernel bzImage boots fine with "qemu-x86_defconfig" target. Did you see such issue? This is not a show-stopper. I will apply this series soon. Regards, Bin ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
On Sat, Aug 3, 2019 at 4:31 PM Park, Aiden wrote: > > Add slimbootloader board to run U-boot as a Slim Bootloader payload > - Add new board/intel/slimbootloader directory with minimum codes > - Add slimbootloader configuration files > - Add doc/board/intel/slimbootloader.rst > > Signed-off-by: Aiden Park > Reviewed-by: Bin Meng > Reviewed-by: Andy Shevchenko > --- > Changes in v8: > * Add a space between acronym and (definition) > > Changes in v7: > * Adding slimbootloader.rst in index.rst > > Changes in v6: > * Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig > * Move USB_STORAGE and USB_KEYBOARD to board Kconfig > * Convert README to reST doc/board/intel/slimbootloader.rst > > Changes in v5: > * Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig > > Changes in v3: > * Remove VENDOR_SLIMBOOTLOADER > * Use VENDOR_INTEL > * Move slimbootloader under board/intel/ > * Enable generic CONFIGs in slimbootloader_defconfig > * Add more description in board/intel/slimbootloader/README > > board/intel/Kconfig | 14 ++ > board/intel/slimbootloader/Kconfig | 28 > board/intel/slimbootloader/Makefile | 5 + > board/intel/slimbootloader/slimbootloader.c | 21 +++ > board/intel/slimbootloader/start.S | 9 + > configs/slimbootloader_defconfig| 22 +++ > doc/board/intel/index.rst | 1 + > doc/board/intel/slimbootloader.rst | 174 > include/configs/slimbootloader.h| 62 +++ > 9 files changed, 336 insertions(+) > create mode 100644 board/intel/slimbootloader/Kconfig > create mode 100644 board/intel/slimbootloader/Makefile > create mode 100644 board/intel/slimbootloader/slimbootloader.c > create mode 100644 board/intel/slimbootloader/start.S > create mode 100644 configs/slimbootloader_defconfig > create mode 100644 doc/board/intel/slimbootloader.rst > create mode 100644 include/configs/slimbootloader.h > Tested-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v9 8/9] board: intel: Add new slimbootloader board
Add slimbootloader board to run U-boot as a Slim Bootloader payload
- Add new board/intel/slimbootloader directory with minimum codes
- Add slimbootloader configuration files
- Add doc/board/intel/slimbootloader.rst
Signed-off-by: Aiden Park
Reviewed-by: Bin Meng
Reviewed-by: Andy Shevchenko
---
Changes in v8:
* Add a space between acronym and (definition)
Changes in v7:
* Adding slimbootloader.rst in index.rst
Changes in v6:
* Select CONFIG_SYS_SLIMBOOTLOADER in board Kconfig
* Move USB_STORAGE and USB_KEYBOARD to board Kconfig
* Convert README to reST doc/board/intel/slimbootloader.rst
Changes in v5:
* Remove X86_LOAD_FROM_32_BIT from slimbootloader_defconfig
Changes in v3:
* Remove VENDOR_SLIMBOOTLOADER
* Use VENDOR_INTEL
* Move slimbootloader under board/intel/
* Enable generic CONFIGs in slimbootloader_defconfig
* Add more description in board/intel/slimbootloader/README
board/intel/Kconfig | 14 ++
board/intel/slimbootloader/Kconfig | 28
board/intel/slimbootloader/Makefile | 5 +
board/intel/slimbootloader/slimbootloader.c | 21 +++
board/intel/slimbootloader/start.S | 9 +
configs/slimbootloader_defconfig| 22 +++
doc/board/intel/index.rst | 1 +
doc/board/intel/slimbootloader.rst | 174
include/configs/slimbootloader.h| 62 +++
9 files changed, 336 insertions(+)
create mode 100644 board/intel/slimbootloader/Kconfig
create mode 100644 board/intel/slimbootloader/Makefile
create mode 100644 board/intel/slimbootloader/slimbootloader.c
create mode 100644 board/intel/slimbootloader/start.S
create mode 100644 configs/slimbootloader_defconfig
create mode 100644 doc/board/intel/slimbootloader.rst
create mode 100644 include/configs/slimbootloader.h
diff --git a/board/intel/Kconfig b/board/intel/Kconfig
index 5131836cb0..7b16ec4dc1 100644
--- a/board/intel/Kconfig
+++ b/board/intel/Kconfig
@@ -73,6 +73,19 @@ config TARGET_MINNOWMAX
Note that PCIE_ECAM_BASE is set up by the FSP so the value used
by U-Boot matches that value.
+config TARGET_SLIMBOOTLOADER
+ bool "slimbootloader"
+ help
+ This target is used for running U-Boot on top of Slim Bootloader
+ boot firmware as a payload. Slim Bootloader does memory initialization
+ and silicon initialization, and it passes necessary information in
+ HOB (Hand Off Block) to a payload. The payload consumes HOB data
+ which is generated by Slim Bootloader for its driver initialization.
+ Slim Bootloader consumes FSP and its HOB, but FSP HOB is cleared
+ Before launching a payload. Instead, Slim Bootloader generates its
+ HOB data such as memory info, serial port info and so on.
+ Refer to doc/board/intel/slimbootloader.rst for the details.
+
endchoice
source "board/intel/bayleybay/Kconfig"
@@ -82,5 +95,6 @@ source "board/intel/crownbay/Kconfig"
source "board/intel/edison/Kconfig"
source "board/intel/galileo/Kconfig"
source "board/intel/minnowmax/Kconfig"
+source "board/intel/slimbootloader/Kconfig"
endif
diff --git a/board/intel/slimbootloader/Kconfig
b/board/intel/slimbootloader/Kconfig
new file mode 100644
index 00..8c7e22cc33
--- /dev/null
+++ b/board/intel/slimbootloader/Kconfig
@@ -0,0 +1,28 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2019 Intel Corporation
+
+if TARGET_SLIMBOOTLOADER
+
+config SYS_BOARD
+ default "slimbootloader"
+
+config SYS_VENDOR
+ default "intel"
+
+config SYS_SOC
+ default "slimbootloader"
+
+config SYS_CONFIG_NAME
+ default "slimbootloader"
+
+config SYS_TEXT_BASE
+ default 0x0010
+
+config BOARD_SPECIFIC_OPTIONS
+ def_bool y
+ select SYS_SLIMBOOTLOADER
+ select USB_STORAGE
+ select USB_KEYBOARD
+
+endif
diff --git a/board/intel/slimbootloader/Makefile
b/board/intel/slimbootloader/Makefile
new file mode 100644
index 00..fd8fa98a8d
--- /dev/null
+++ b/board/intel/slimbootloader/Makefile
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2019 Intel Corporation
+
+obj-y += start.o slimbootloader.o
diff --git a/board/intel/slimbootloader/slimbootloader.c
b/board/intel/slimbootloader/slimbootloader.c
new file mode 100644
index 00..f50eeb823f
--- /dev/null
+++ b/board/intel/slimbootloader/slimbootloader.c
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Intel Corporation
+ */
+
+#include
+
+int board_early_init_r(void)
+{
+ /*
+* Make sure PCI bus is enumerated so that peripherals on the PCI bus
+* can be discovered by their drivers.
+*
+* Slim Bootloader has already done PCI bus enumeration before loading
+* U-Boot, so U-Boot needs to preserve PCI configuration.
+* Therefore, '# CONFIG_PCI_PNP is not set' is included in defconfig.
+*/
