Re: [U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-05 Thread Dinh Nguyen 
On Thu, Apr 5, 2018 at 11:28 AM, Marek Vasut  wrote:
> On 04/05/2018 04:46 PM, Dinh Nguyen wrote:
>>
>>
>> On 04/05/2018 09:12 AM, Dinh Nguyen wrote:
>>> v
>>>
>>> On 04/04/2018 05:56 PM, Marek Vasut wrote:
 On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
> Add a DM compatible reset driver for the SoCFPGA platform.
>
> Signed-off-by: Dinh Nguyen 

 [...]

> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
> +{
> +  debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
> +reset_ctl, reset_ctl->dev, reset_ctl->id);
> +
> +  return 0;
> +}
> +
> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
> +{
> +  debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
> +reset_ctl->dev, reset_ctl->id);
> +
> +  return 0;
> +}

 Is request/free needed at all ? It looks like a useless debug to me.

>>>
>>> I used the code to debug that the i2c driver did hook into the reset
>>> manager driver. Certainly, it can be removed in the final version. I'll
>>> send a V3 shortly with this removed.
>>>
>>
>> I cannot remove the request function as this is needed in the
>> reset-uclass driver.
>
> Fix the driver please.
>
>> Do you want me to remove free? Leaving the code
>> there seems harmless to me.
>
> Do a generic fix and then submit a fix for this driver, so two patches
> in total. I'll apply the V2 for now.
>

Ok...will do.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-05 Thread Marek Vasut 
On 04/05/2018 04:46 PM, Dinh Nguyen wrote:
> 
> 
> On 04/05/2018 09:12 AM, Dinh Nguyen wrote:
>> v
>>
>> On 04/04/2018 05:56 PM, Marek Vasut wrote:
>>> On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
 Add a DM compatible reset driver for the SoCFPGA platform.

 Signed-off-by: Dinh Nguyen 
>>>
>>> [...]
>>>
 +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
 +{
 +  debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
 +reset_ctl, reset_ctl->dev, reset_ctl->id);
 +
 +  return 0;
 +}
 +
 +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
 +{
 +  debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
 +reset_ctl->dev, reset_ctl->id);
 +
 +  return 0;
 +}
>>>
>>> Is request/free needed at all ? It looks like a useless debug to me.
>>>
>>
>> I used the code to debug that the i2c driver did hook into the reset
>> manager driver. Certainly, it can be removed in the final version. I'll
>> send a V3 shortly with this removed.
>>
> 
> I cannot remove the request function as this is needed in the
> reset-uclass driver.

Fix the driver please.

> Do you want me to remove free? Leaving the code
> there seems harmless to me.

Do a generic fix and then submit a fix for this driver, so two patches
in total. I'll apply the V2 for now.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-05 Thread Dinh Nguyen 


On 04/05/2018 09:12 AM, Dinh Nguyen wrote:
> v
> 
> On 04/04/2018 05:56 PM, Marek Vasut wrote:
>> On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
>>> Add a DM compatible reset driver for the SoCFPGA platform.
>>>
>>> Signed-off-by: Dinh Nguyen 
>>
>> [...]
>>
>>> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
>>> +{
>>> +   debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
>>> + reset_ctl, reset_ctl->dev, reset_ctl->id);
>>> +
>>> +   return 0;
>>> +}
>>> +
>>> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
>>> +{
>>> +   debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
>>> + reset_ctl->dev, reset_ctl->id);
>>> +
>>> +   return 0;
>>> +}
>>
>> Is request/free needed at all ? It looks like a useless debug to me.
>>
> 
> I used the code to debug that the i2c driver did hook into the reset
> manager driver. Certainly, it can be removed in the final version. I'll
> send a V3 shortly with this removed.
> 

I cannot remove the request function as this is needed in the
reset-uclass driver. Do you want me to remove free? Leaving the code
there seems harmless to me.

Thanks,
Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-05 Thread Dinh Nguyen 
v

On 04/04/2018 05:56 PM, Marek Vasut wrote:
> On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
>> Add a DM compatible reset driver for the SoCFPGA platform.
>>
>> Signed-off-by: Dinh Nguyen 
> 
> [...]
> 
>> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
>> +{
>> +debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
>> +  reset_ctl, reset_ctl->dev, reset_ctl->id);
>> +
>> +return 0;
>> +}
>> +
>> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
>> +{
>> +debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
>> +  reset_ctl->dev, reset_ctl->id);
>> +
>> +return 0;
>> +}
> 
> Is request/free needed at all ? It looks like a useless debug to me.
> 

I used the code to debug that the i2c driver did hook into the reset
manager driver. Certainly, it can be removed in the final version. I'll
send a V3 shortly with this removed.

Dinh
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-04 Thread Marek Vasut 
On 04/05/2018 12:18 AM, Dinh Nguyen wrote:
> Add a DM compatible reset driver for the SoCFPGA platform.
> 
> Signed-off-by: Dinh Nguyen 

[...]

> +static int socfpga_reset_request(struct reset_ctl *reset_ctl)
> +{
> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
> +   reset_ctl, reset_ctl->dev, reset_ctl->id);
> +
> + return 0;
> +}
> +
> +static int socfpga_reset_free(struct reset_ctl *reset_ctl)
> +{
> + debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
> +   reset_ctl->dev, reset_ctl->id);
> +
> + return 0;
> +}

Is request/free needed at all ? It looks like a useless debug to me.

> +static const struct reset_ops socfpga_reset_ops = {
> + .request = socfpga_reset_request,
> + .free = socfpga_reset_free,
> + .rst_assert = socfpga_reset_assert,
> + .rst_deassert = socfpga_reset_deassert,
> +};

[...]

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCHv2 1/6] reset: socfpga: add reset driver for SoCFPGA platform

2018-04-04 Thread Dinh Nguyen 
Add a DM compatible reset driver for the SoCFPGA platform.

Signed-off-by: Dinh Nguyen 
---
v2: use setbits_le32 and clrbits_le32
---
 drivers/reset/Kconfig |   7 +++
 drivers/reset/Makefile|   1 +
 drivers/reset/reset-socfpga.c | 105 ++
 3 files changed, 113 insertions(+)
 create mode 100644 drivers/reset/reset-socfpga.c

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 3964b9e..90b021f 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -83,4 +83,11 @@ config RESET_ROCKCHIP
  though is that some reset signals, like I2C or MISC reset multiple
  devices.
 
+config RESET_SOCFPGA
+   bool "Reset controller driver for SoCFPGA"
+   depends on DM_RESET && ARCH_SOCFPGA
+   default y
+   help
+ Support for reset controller on SoCFPGA platform.
+
 endmenu
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 7d7e080..6f791ee 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_RESET_BCM6345) += reset-bcm6345.o
 obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
 obj-$(CONFIG_AST2500_RESET) += ast2500-reset.o
 obj-$(CONFIG_RESET_ROCKCHIP) += reset-rockchip.o
+obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
diff --git a/drivers/reset/reset-socfpga.c b/drivers/reset/reset-socfpga.c
new file mode 100644
index 000..466455d
--- /dev/null
+++ b/drivers/reset/reset-socfpga.c
@@ -0,0 +1,105 @@
+/*
+ * Socfpga Reset Controller Driver
+ *
+ * Copyright 2014 Steffen Trumtrar 
+ *
+ * based on
+ * Allwinner SoCs Reset Controller driver
+ *
+ * Copyright 2013 Maxime Ripard
+ *
+ * Maxime Ripard 
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define BANK_INCREMENT 4
+#define NR_BANKS   8
+
+struct socfpga_reset_data {
+   void __iomem *membase;
+};
+
+static int socfpga_reset_assert(struct reset_ctl *reset_ctl)
+{
+   struct socfpga_reset_data *data = dev_get_priv(reset_ctl->dev);
+   int id = reset_ctl->id;
+   int reg_width = sizeof(u32);
+   int bank = id / (reg_width * BITS_PER_BYTE);
+   int offset = id % (reg_width * BITS_PER_BYTE);
+
+   setbits_le32(data->membase + (bank * BANK_INCREMENT), BIT(offset));
+   return 0;
+}
+
+static int socfpga_reset_deassert(struct reset_ctl *reset_ctl)
+{
+   struct socfpga_reset_data *data = dev_get_priv(reset_ctl->dev);
+   int id = reset_ctl->id;
+   int reg_width = sizeof(u32);
+   int bank = id / (reg_width * BITS_PER_BYTE);
+   int offset = id % (reg_width * BITS_PER_BYTE);
+
+   clrbits_le32(data->membase + (bank * BANK_INCREMENT), BIT(offset));
+   return 0;
+}
+
+static int socfpga_reset_request(struct reset_ctl *reset_ctl)
+{
+   debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__,
+ reset_ctl, reset_ctl->dev, reset_ctl->id);
+
+   return 0;
+}
+
+static int socfpga_reset_free(struct reset_ctl *reset_ctl)
+{
+   debug("%s(reset_ctl=%p) (dev=%p, id=%lu)\n", __func__, reset_ctl,
+ reset_ctl->dev, reset_ctl->id);
+
+   return 0;
+}
+
+static const struct reset_ops socfpga_reset_ops = {
+   .request = socfpga_reset_request,
+   .free = socfpga_reset_free,
+   .rst_assert = socfpga_reset_assert,
+   .rst_deassert = socfpga_reset_deassert,
+};
+
+static int socfpga_reset_probe(struct udevice *dev)
+{
+   struct socfpga_reset_data *data = dev_get_priv(dev);
+   const void *blob = gd->fdt_blob;
+   int node = dev_of_offset(dev);
+   u32 modrst_offset;
+
+   data->membase = devfdt_get_addr_ptr(dev);
+
+   modrst_offset = fdtdec_get_int(blob, node, "altr,modrst-offset", 0x10);
+   data->membase += modrst_offset;
+
+   return 0;
+}
+
+static const struct udevice_id socfpga_reset_match[] = {
+   { .compatible = "altr,rst-mgr" },
+   { /* sentinel */ },
+};
+
+U_BOOT_DRIVER(socfpga_reset) = {
+   .name = "socfpga-reset",
+   .id = UCLASS_RESET,
+   .of_match = socfpga_reset_match,
+   .probe = socfpga_reset_probe,
+   .priv_auto_alloc_size = sizeof(struct socfpga_reset_data),
+   .ops = &socfpga_reset_ops,
+};
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot