Re: [U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT

2019-07-11 Thread Tom Rini
On Thu, May 23, 2019 at 07:14:08AM -0400, Tom Rini wrote:

> When we have a FIT image being used by SPL by default that means the
> most common case is that we'll never run into a legacy image.  Disable
> legacy image support by default in that case to reclaim space.
> 
> Signed-off-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT

2019-05-23 Thread Tom Rini
On Thu, May 23, 2019 at 02:18:13PM +0200, Jean-Jacques Hiblot wrote:
> 
> On 23/05/2019 13:14, Tom Rini wrote:
> >When we have a FIT image being used by SPL by default that means the
> >most common case is that we'll never run into a legacy image.  Disable
> >legacy image support by default in that case to reclaim space.
> >
> >Signed-off-by: Tom Rini 
> >---
> >  common/spl/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> >index c7cd34449a52..55dba0d42069 100644
> >--- a/common/spl/Kconfig
> >+++ b/common/spl/Kconfig
> >@@ -101,7 +101,7 @@ config SPL_RAW_IMAGE_SUPPORT
> >  config SPL_LEGACY_IMAGE_SUPPORT
> > bool "Support SPL loading and booting of Legacy images"
> >-default y if !TI_SECURE_DEVICE
> >+default y if !TI_SECURE_DEVICE && !SPL_LOAD_FIT
> > help
> >   SPL will support loading and booting Legacy images when this option
> >   is y. If this is not set, SPL will move on to other available
> 
> reviewed-by and tested-by : Jean-Jacques Hiblot 

Thanks!

> Building for arm, the reduction in size is around 50 bytes

Yup, with gcc-7.3, on the platforms that set SPL_LOAD_FIT it's generally
an 84 bytes savings on aarch64 and 40 bytes on arm32.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT

2019-05-23 Thread Jean-Jacques Hiblot


On 23/05/2019 13:14, Tom Rini wrote:

When we have a FIT image being used by SPL by default that means the
most common case is that we'll never run into a legacy image.  Disable
legacy image support by default in that case to reclaim space.

Signed-off-by: Tom Rini 
---
  common/spl/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index c7cd34449a52..55dba0d42069 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -101,7 +101,7 @@ config SPL_RAW_IMAGE_SUPPORT
  
  config SPL_LEGACY_IMAGE_SUPPORT

bool "Support SPL loading and booting of Legacy images"
-   default y if !TI_SECURE_DEVICE
+   default y if !TI_SECURE_DEVICE && !SPL_LOAD_FIT
help
  SPL will support loading and booting Legacy images when this option
  is y. If this is not set, SPL will move on to other available


reviewed-by and tested-by : Jean-Jacques Hiblot 

Building for arm, the reduction in size is around 50 bytes

JJ

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCHv2 2/2] SPL: Default to disabling legacy image support when using FIT

2019-05-23 Thread Tom Rini
When we have a FIT image being used by SPL by default that means the
most common case is that we'll never run into a legacy image.  Disable
legacy image support by default in that case to reclaim space.

Signed-off-by: Tom Rini 
---
 common/spl/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index c7cd34449a52..55dba0d42069 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -101,7 +101,7 @@ config SPL_RAW_IMAGE_SUPPORT
 
 config SPL_LEGACY_IMAGE_SUPPORT
bool "Support SPL loading and booting of Legacy images"
-   default y if !TI_SECURE_DEVICE
+   default y if !TI_SECURE_DEVICE && !SPL_LOAD_FIT
help
  SPL will support loading and booting Legacy images when this option
  is y. If this is not set, SPL will move on to other available
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot