Re: [U-Boot] [Patch] for drivers/net/phy/smsc.c to support SMSC LAN8741

[Joe Hershberger]

Hi Arno,

On Fri, Feb 16, 2018 at 4:29 PM, Joe Hershberger  wrote:
> Hi Arno,
>
> Welcome.
>
> On Thu, Jan 25, 2018 at 6:08 AM, Arno Steffens  wrote:
>> Hello,
>> Be mild with me - my first patch to u-boot.
>
> Generally this is the type of thing you add after "---" in the message
> body, so that it won't be included in the commit log, only in the
> email.
>
> Please see http://www.denx.de/wiki/U-Boot/Patches
>
> Also, look into patman - a tool in the source tree of U-Boot (
> tools/patman/README ) that helps with some of the mechanics of sending
> patches.
>
>>
>> Signed-off-by: Arno Steffens 
>
> You shouldn't obfuscate your email in the patch itself.
>
>>
>> diff -Nur u-boot-2017.11/drivers/net/phy/smsc.c 
>> u-boot-2017.11_patched/drivers/net/phy/smsc.c
>> --- u-boot-2017.11/drivers/net/phy/smsc.c 2017-11-14 02:08:06.0 +0100
>> +++ u-boot-2017.11_patched/drivers/net/phy/smsc.c 2018-01-24 
>> 12:17:39.326055469 +0100
>> @@ -83,6 +83,16 @@
>> .shutdown = _shutdown,
>> };
>>
>> +static struct phy_driver lan8741_driver = {
>> + .name = "SMSC LAN8741",
>> + .uid = 0x0007c120,
>> + .mask = 0x0,
>> + .features = PHY_BASIC_FEATURES,
>> + .config = _config_aneg,
>> + .startup = _startup,
>> + .shutdown = _shutdown,
>> +};
>> +
>
> The code change itself looks fine!
>
> Cheers,
> -Joe
>
>> static struct phy_driver lan8742_driver = {
>> .name = "SMSC LAN8742",
>> .uid = 0x0007c130,
>> @@ -99,6 +109,7 @@
>> phy_register(_driver);
>> phy_register(_driver);
>> phy_register(_driver);
>> + phy_register(_driver);
>> phy_register(_driver);
>>
>> return 0;

I've reworked the format of your patch to make it apply this time. In
the future, please use patman to send patches.

Thanks,
-Joe

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [Patch] for drivers/net/phy/smsc.c to support SMSC LAN8741

[Joe Hershberger]

Hi Arno,

Welcome.

On Thu, Jan 25, 2018 at 6:08 AM, Arno Steffens  wrote:
> Hello,
> Be mild with me - my first patch to u-boot.

Generally this is the type of thing you add after "---" in the message
body, so that it won't be included in the commit log, only in the
email.

Please see http://www.denx.de/wiki/U-Boot/Patches

Also, look into patman - a tool in the source tree of U-Boot (
tools/patman/README ) that helps with some of the mechanics of sending
patches.

>
> Signed-off-by: Arno Steffens 

You shouldn't obfuscate your email in the patch itself.

>
> diff -Nur u-boot-2017.11/drivers/net/phy/smsc.c 
> u-boot-2017.11_patched/drivers/net/phy/smsc.c
> --- u-boot-2017.11/drivers/net/phy/smsc.c 2017-11-14 02:08:06.0 +0100
> +++ u-boot-2017.11_patched/drivers/net/phy/smsc.c 2018-01-24 
> 12:17:39.326055469 +0100
> @@ -83,6 +83,16 @@
> .shutdown = _shutdown,
> };
>
> +static struct phy_driver lan8741_driver = {
> + .name = "SMSC LAN8741",
> + .uid = 0x0007c120,
> + .mask = 0x0,
> + .features = PHY_BASIC_FEATURES,
> + .config = _config_aneg,
> + .startup = _startup,
> + .shutdown = _shutdown,
> +};
> +

The code change itself looks fine!

Cheers,
-Joe

> static struct phy_driver lan8742_driver = {
> .name = "SMSC LAN8742",
> .uid = 0x0007c130,
> @@ -99,6 +109,7 @@
> phy_register(_driver);
> phy_register(_driver);
> phy_register(_driver);
> + phy_register(_driver);
> phy_register(_driver);
>
> return 0;
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [Patch] for drivers/net/phy/smsc.c to support SMSC LAN8741

[Arno Steffens]

Hello,
Be mild with me - my first patch to u-boot.

Signed-off-by: Arno Steffens 

diff -Nur u-boot-2017.11/drivers/net/phy/smsc.c 
u-boot-2017.11_patched/drivers/net/phy/smsc.c
--- u-boot-2017.11/drivers/net/phy/smsc.c 2017-11-14 02:08:06.0 +0100
+++ u-boot-2017.11_patched/drivers/net/phy/smsc.c 2018-01-24 12:17:39.326055469 
+0100
@@ -83,6 +83,16 @@
.shutdown = _shutdown,
};

+static struct phy_driver lan8741_driver = {
+ .name = "SMSC LAN8741",
+ .uid = 0x0007c120,
+ .mask = 0x0,
+ .features = PHY_BASIC_FEATURES,
+ .config = _config_aneg,
+ .startup = _startup,
+ .shutdown = _shutdown,
+};
+
static struct phy_driver lan8742_driver = {
.name = "SMSC LAN8742",
.uid = 0x0007c130,
@@ -99,6 +109,7 @@
phy_register(_driver);
phy_register(_driver);
phy_register(_driver);
+ phy_register(_driver);
phy_register(_driver);

return 0;
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot