Re: [U-Boot] [RESEND PATCH v2 10/15] riscv: bootm: Pass mhartid CSR value to kernel

2018-09-19 Thread Rick Chen
 > From: Bin Meng [mailto:bmeng...@gmail.com]
 > Sent: Tuesday, September 11, 2018 12:55 PM
 > To: Rick Jian-Zhi Chen(陳建志); U-Boot Mailing List
 > Cc: Lukas Auer
 > Subject: [RESEND PATCH v2 10/15] riscv: bootm: Pass mhartid CSR
value to kernel
 >
 > So far this is hardcoded to zero, and we should read the value from
mhartid CSR
 > and pass it to Linux kernel.
 >
 > Suggested-by: Lukas Auer 
 > Signed-off-by: Bin Meng 
 >
 > ---
 >
 > Changes in v2:
 > - new patch to pass mhartid CSR value to kernel
 >
 >  arch/riscv/lib/bootm.c | 5 +++--
 >  1 file changed, 3 insertions(+), 2 deletions(-)
 >
> > diff --git a/arch/riscv/lib/bootm.c b/arch/riscv/lib/bootm.c index
 > 6893108..a7a9fb9 100644
 > --- a/arch/riscv/lib/bootm.c
 > +++ b/arch/riscv/lib/bootm.c
 > @@ -11,6 +11,7 @@
 >  #include 
 >  #include 
 >  #include 
 > +#include 
 >
 >  DECLARE_GLOBAL_DATA_PTR;
 >
 > @@ -57,9 +58,9 @@ int do_bootm_linux(int flag, int argc, char *argv[],
 > bootm_headers_t *images)
 >   printf("\nStarting kernel ...\n\n");
 >
 >   cleanup_before_linux();
 > - /* TODO: hardcode the hart id to zero for now */
 > +
 >   if (IMAGE_ENABLE_OF_LIBFDT && images->ft_len)
 > - kernel(0, images->ft_addr);
 > + kernel(csr_read(mhartid), images->ft_addr);
 >
 >   /* does not return */
 >

Reviewed-by: Rick Chen 

> > --
 > 2.7.4
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [RESEND PATCH v2 10/15] riscv: bootm: Pass mhartid CSR value to kernel

2018-09-16 Thread Auer, Lukas
On Mon, 2018-09-10 at 21:54 -0700, Bin Meng wrote:
> So far this is hardcoded to zero, and we should read the value from
> mhartid CSR and pass it to Linux kernel.
> 
> Suggested-by: Lukas Auer 
> Signed-off-by: Bin Meng 
> 
> 

Reviewed-by: Lukas Auer 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [RESEND PATCH v2 10/15] riscv: bootm: Pass mhartid CSR value to kernel

2018-09-10 Thread Bin Meng
So far this is hardcoded to zero, and we should read the value from
mhartid CSR and pass it to Linux kernel.

Suggested-by: Lukas Auer 
Signed-off-by: Bin Meng 

---

Changes in v2:
- new patch to pass mhartid CSR value to kernel

 arch/riscv/lib/bootm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/lib/bootm.c b/arch/riscv/lib/bootm.c
index 6893108..a7a9fb9 100644
--- a/arch/riscv/lib/bootm.c
+++ b/arch/riscv/lib/bootm.c
@@ -11,6 +11,7 @@
 #include 
 #include 
 #include 
+#include 
 
 DECLARE_GLOBAL_DATA_PTR;
 
@@ -57,9 +58,9 @@ int do_bootm_linux(int flag, int argc, char *argv[], 
bootm_headers_t *images)
printf("\nStarting kernel ...\n\n");
 
cleanup_before_linux();
-   /* TODO: hardcode the hart id to zero for now */
+
if (IMAGE_ENABLE_OF_LIBFDT && images->ft_len)
-   kernel(0, images->ft_addr);
+   kernel(csr_read(mhartid), images->ft_addr);
 
/* does not return */
 
-- 
2.7.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot