Re: [U-Boot] [RFC PATCH 0/7] Add Driver Model support to network stack

2015-01-27 Thread Simon Glass
Hi Joe,

On 27 January 2015 at 16:27, Joe Hershberger  wrote:
> For now this simply addresses the MAC part of the network hardware.
> The next part to implement is the PHY children.  I wanted to get early
> feedback on what I have so far to make sure I'm going in the direction
> that Simon envisioned.
>

It's great to see this! My comments are against each patch.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [RFC PATCH 0/7] Add Driver Model support to network stack

2015-01-27 Thread Joe Hershberger
For now this simply addresses the MAC part of the network hardware.
The next part to implement is the PHY children.  I wanted to get early
feedback on what I have so far to make sure I'm going in the direction
that Simon envisioned.


Joe Hershberger (7):
  net: Provide a function to get the current MAC address
  net: Rename helper function to be more clear
  net: Remove unneeded "extern" in net.h
  net: Refactor in preparation for driver model
  net: Add basic driver model support to Ethernet stack
  net: Add network support to sandbox
  net: Add ARP and PING response to sandbox driver

 arch/mips/cpu/mips32/au1x00/au1x00_eth.c |   2 +-
 arch/powerpc/cpu/mpc8260/ether_fcc.c |   2 +-
 arch/powerpc/cpu/mpc85xx/ether_fcc.c |   2 +-
 arch/powerpc/cpu/mpc8xx/scc.c|   2 +-
 arch/sandbox/dts/sandbox.dts |   4 +
 common/board_r.c |   4 +-
 common/cmd_bdinfo.c  |   2 +
 drivers/net/Makefile |   2 +
 drivers/net/sandbox.c| 166 +
 include/configs/sandbox.h|  14 +-
 include/dm/uclass-id.h   |   1 +
 include/net.h| 158 +++-
 net/eth.c| 408 +++
 net/net.c|   2 +-
 14 files changed, 649 insertions(+), 120 deletions(-)
 create mode 100644 drivers/net/sandbox.c

-- 
1.7.11.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot