Re: [U-Boot] [RFC PATCH v1 9/9] sparc: Add support for gr712rc-board

2014-10-30 Thread Masahiro Yamada 
Hi Francois,



On Wed, 29 Oct 2014 10:53:07 +0200
Francois Retief fgret...@spaceteq.co.za wrote:

 Add support of the Aeroflex Gaisler GR712RC-BOARD Development Kit.
 
 Signed-off-by: Francois Retief fgret...@spaceteq.co.za
 ---
 

Thanks for your great job!


I am sorry for bothering you work, but please let me
do some cleanups before adding a new board
because you are following the old style coding.
http://patchwork.ozlabs.org/patch/404889/
http://patchwork.ozlabs.org/patch/404887/
http://patchwork.ozlabs.org/patch/404886/
http://patchwork.ozlabs.org/patch/404888/
http://patchwork.ozlabs.org/patch/404890/


 
 diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
 index 74f..21bef85 100644
 --- a/arch/sparc/Kconfig
 +++ b/arch/sparc/Kconfig
 @@ -22,6 +22,9 @@ config TARGET_GR_XC3S_1500
  config TARGET_GRSIM
 bool Support grsim
 
 +config TARGET_GR712RC_BOARD
 +   bool Support gr712rc_board
 +
  endchoice


Perhaps can we use better name?
The current prompts were automatically taken by a tool
and I have to admint they are not very good.

Like this?
http://patchwork.ozlabs.org/patch/404889/





  source board/gaisler/gr_cpci_ax2000/Kconfig
 @@ -29,5 +32,6 @@ source board/gaisler/gr_ep2s60/Kconfig
  source board/gaisler/gr_xc3s_1500/Kconfig
  source board/gaisler/grsim/Kconfig
  source board/gaisler/grsim_leon2/Kconfig
 +source board/gaisler/gr712rc_board/Kconfig
 
  endmenu
 diff --git a/board/gaisler/gr712rc_board/Kconfig 
 b/board/gaisler/gr712rc_board/Kconfig
 new file mode 100644
 index 000..e0af97c
 --- /dev/null
 +++ b/board/gaisler/gr712rc_board/Kconfig
 @@ -0,0 +1,19 @@
 +if TARGET_GR712RC_BOARD
 +
 +config SYS_CPU
 +   string
 +   default leon3
 +
 +config SYS_BOARD
 +   string
 +   default gr712rc_board
 +
 +config SYS_VENDOR
 +   string
 +   default gaisler
 +
 +config SYS_CONFIG_NAME
 +   string
 +   default gr712rc_board
 +
 +endif


I think we can save more lines.
Please check this:
http://patchwork.ozlabs.org/patch/404888/



 diff --git a/board/gaisler/gr712rc_board/MAINTAINERS 
 b/board/gaisler/gr712rc_board/MAINTAINERS
 new file mode 100644
 index 000..329fcf9
 --- /dev/null
 +++ b/board/gaisler/gr712rc_board/MAINTAINERS
 @@ -0,0 +1,6 @@
 +GR712RC BOARD
 +#M:-
 +S: New
 +F: board/gaisler/gr712rc/
 +F: include/configs/gr712rc.h
 +F: configs/gr712rc_defconfig

Please use either Maintained or Orphan for the status field.
In this case Maintained, of course.





 diff --git a/board/gaisler/gr712rc_board/config.mk 
 b/board/gaisler/gr712rc_board/config.mk
 new file mode 100644
 index 000..8594a74
 --- /dev/null
 +++ b/board/gaisler/gr712rc_board/config.mk
 @@ -0,0 +1,15 @@
 +#
 +# (C) Copyright 2014, Denel Spaceteq
 +# Francois Retief fgret...@spaceteq.co.za
 +#
 +# SPDX-License-Identifier: GPL-2.0+
 +#
 +
 +# U-BOOT IN FLASH
 +#CONFIG_SYS_TEXT_BASE = 0x
 +
 +# U-BOOT IN SRAM
 +#CONFIG_SYS_TEXT_BASE = 0x4000
 +
 +# U-BOOT IN SDRAM
 +CONFIG_SYS_TEXT_BASE = 0x6000


Please do not define CONFIG_SYS_TEXT_BASE in config.mk; this is very old style.
Add it in the defconfig, like this:
http://patchwork.ozlabs.org/patch/404890/



Best Regards
Masahiro Yamada

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [RFC PATCH v1 9/9] sparc: Add support for gr712rc-board

2014-10-29 Thread Francois Retief 
Add support of the Aeroflex Gaisler GR712RC-BOARD Development Kit.

Signed-off-by: Francois Retief fgret...@spaceteq.co.za
---

 arch/sparc/Kconfig  |   4 +
 board/gaisler/gr712rc_board/Kconfig |  19 ++
 board/gaisler/gr712rc_board/MAINTAINERS |   6 +
 board/gaisler/gr712rc_board/Makefile|   8 +
 board/gaisler/gr712rc_board/README  |  24 ++
 board/gaisler/gr712rc_board/config.mk   |  15 ++
 board/gaisler/gr712rc_board/gr712rc_board.c | 110 +
 common/cmd_bdinfo.c |   4 +
 configs/gr712rc_board_defconfig |   2 +
 include/configs/gr712rc_board.h | 366 
 10 files changed, 558 insertions(+)
 create mode 100644 board/gaisler/gr712rc_board/Kconfig
 create mode 100644 board/gaisler/gr712rc_board/MAINTAINERS
 create mode 100644 board/gaisler/gr712rc_board/Makefile
 create mode 100644 board/gaisler/gr712rc_board/README
 create mode 100644 board/gaisler/gr712rc_board/config.mk
 create mode 100644 board/gaisler/gr712rc_board/gr712rc_board.c
 create mode 100644 configs/gr712rc_board_defconfig
 create mode 100644 include/configs/gr712rc_board.h

diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index 74f..21bef85 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -22,6 +22,9 @@ config TARGET_GR_XC3S_1500
 config TARGET_GRSIM
bool Support grsim

+config TARGET_GR712RC_BOARD
+   bool Support gr712rc_board
+
 endchoice

 source board/gaisler/gr_cpci_ax2000/Kconfig
@@ -29,5 +32,6 @@ source board/gaisler/gr_ep2s60/Kconfig
 source board/gaisler/gr_xc3s_1500/Kconfig
 source board/gaisler/grsim/Kconfig
 source board/gaisler/grsim_leon2/Kconfig
+source board/gaisler/gr712rc_board/Kconfig

 endmenu
diff --git a/board/gaisler/gr712rc_board/Kconfig 
b/board/gaisler/gr712rc_board/Kconfig
new file mode 100644
index 000..e0af97c
--- /dev/null
+++ b/board/gaisler/gr712rc_board/Kconfig
@@ -0,0 +1,19 @@
+if TARGET_GR712RC_BOARD
+
+config SYS_CPU
+   string
+   default leon3
+
+config SYS_BOARD
+   string
+   default gr712rc_board
+
+config SYS_VENDOR
+   string
+   default gaisler
+
+config SYS_CONFIG_NAME
+   string
+   default gr712rc_board
+
+endif
diff --git a/board/gaisler/gr712rc_board/MAINTAINERS 
b/board/gaisler/gr712rc_board/MAINTAINERS
new file mode 100644
index 000..329fcf9
--- /dev/null
+++ b/board/gaisler/gr712rc_board/MAINTAINERS
@@ -0,0 +1,6 @@
+GR712RC BOARD
+#M:-
+S: New
+F: board/gaisler/gr712rc/
+F: include/configs/gr712rc.h
+F: configs/gr712rc_defconfig
diff --git a/board/gaisler/gr712rc_board/Makefile 
b/board/gaisler/gr712rc_board/Makefile
new file mode 100644
index 000..11861ef
--- /dev/null
+++ b/board/gaisler/gr712rc_board/Makefile
@@ -0,0 +1,8 @@
+#
+# (C) Copyright 2014, Denel Spaceteq
+# Francois Retief fgret...@spaceteq.co.za
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  := gr712rc_board.o
diff --git a/board/gaisler/gr712rc_board/README 
b/board/gaisler/gr712rc_board/README
new file mode 100644
index 000..9deb239
--- /dev/null
+++ b/board/gaisler/gr712rc_board/README
@@ -0,0 +1,24 @@
+
+
+Jumpers for SDRAM:
+  JP12 = C SDCSN0
+  JP13 = C SDCSN1
+  JP24 = C SDDQM0
+  JP25 = C SDDQM1
+  JP48 = C SDCASN
+  JP49 = C SDRASN
+  JP52 = C SDWEN
+  JP53 = C SDDQM2
+  JP54 = C SDDQM3
+
+Jumpers for Ethernet (RMII):
+  JP28 = F RMTXD0
+  JP29 = F RMTXD1
+  JP30 = F RMRXD0
+  JP31 = F RMRXD1
+  JP32 = F RMTXEN
+  JP34 = F RMCRSDV
+  JP35 = F RMMDINT
+  JP36 = F RMMDIO
+  JP37 = F RMMDC
+  JP38 = F RMRFCLK
diff --git a/board/gaisler/gr712rc_board/config.mk 
b/board/gaisler/gr712rc_board/config.mk
new file mode 100644
index 000..8594a74
--- /dev/null
+++ b/board/gaisler/gr712rc_board/config.mk
@@ -0,0 +1,15 @@
+#
+# (C) Copyright 2014, Denel Spaceteq
+# Francois Retief fgret...@spaceteq.co.za
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+# U-BOOT IN FLASH
+#CONFIG_SYS_TEXT_BASE = 0x
+
+# U-BOOT IN SRAM
+#CONFIG_SYS_TEXT_BASE = 0x4000
+
+# U-BOOT IN SDRAM
+CONFIG_SYS_TEXT_BASE = 0x6000
diff --git a/board/gaisler/gr712rc_board/gr712rc_board.c 
b/board/gaisler/gr712rc_board/gr712rc_board.c
new file mode 100644
index 000..5a246e8
--- /dev/null
+++ b/board/gaisler/gr712rc_board/gr712rc_board.c
@@ -0,0 +1,110 @@
+/*
+ * GR712RC-BOARD Developement Kit
+ *
+ * (C) Copyright 2014, Denel Spaceteq
+ * Francois Retief fgret...@spaceteq.co.za
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include common.h
+#include netdev.h
+#include asm/io.h
+#include ambapp.h
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#ifdef CONFIG_BOARD_EARLY_INIT_F
+
+int board_early_init_f(void)
+{
+   gd-ram_size = CONFIG_SYS_SDRAM_SIZE;
+   return 0;
+}
+
+#endif
+
+#ifndef CONFIG_SYS_GENERIC_BOARD
+
+int checkboard(void)
+{
+   puts(Board: GR712RC-BOARD Development Kit\n);
+   return 0;
+}
+
+#endif
+