Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-11-21 Thread Lukasz Majewski 
On Mon, 20 Nov 2017 16:54:51 +0100
"Dr. Philipp Tomsich"  wrote:

> Kever & Eddie,
> 
> > On 2 Oct 2017, at 12:51, Dr. Philipp Tomsich
> >  wrote:
> > 
> > +Kever, +Eddie
> > 
> > Kever & Eddie,
> >   
> >> On 2 Oct 2017, at 12:41, Marek Vasut  wrote:
> >> 
> >> On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote:  
> >>> Lukasz & Marek,
> >>>   
>  On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
>  
>  Hi Dr. Philipp,
>    
> > Hi Lukasz,  
> >> On 12 Sep 2017, at 10:14, Łukasz Majewski 
> >> wrote:
> >> 
> >> Hi Philipp,
> >> 
> >> This patch series is waiting for opening new merge window. It
> >> is already applied to usb-next tree.  
> > Didn’t the new merge window just open yesterday?  
>  
>  I'm sure Marek will send PR shortly.  
> >>> 
> >>> I don’t see this series on u-boot-usb/master … what is the status
> >>> on this? I have multiple dependent series pending in my queue
> >>> that are waiting on this one...  
> >> 
> >> It didn't pass travisci tests, I'm waiting for one which does.
> >> Can you retest and resubmit , so Lukasz can pick it again ?
> >> 
> >> Sorry it takes one more cycle.  
> > 
> > Could you follow up on Marek’s request to retest and resubmit?  
> 
> Any news on this?
> I still have a number of patches blocked (in the rockchip-queue)
> blocked by rockusb not being there yet.

I would love to see the resubmitted patches.

Now is the best time - we are in the middle of merge window.

> 
> > Thanks,
> > Philipp.
> > 
> > ___
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot  
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de


pgp8S9GhKMqqw.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-11-20 Thread Eddie Cai 
I will do it this week

2017-11-20 23:54 GMT+08:00 Dr. Philipp Tomsich
:
> Kever & Eddie,
>
>> On 2 Oct 2017, at 12:51, Dr. Philipp Tomsich 
>>  wrote:
>>
>> +Kever, +Eddie
>>
>> Kever & Eddie,
>>
>>> On 2 Oct 2017, at 12:41, Marek Vasut  wrote:
>>>
>>> On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote:
 Lukasz & Marek,

> On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
>
> Hi Dr. Philipp,
>
>> Hi Lukasz,
>>> On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:
>>>
>>> Hi Philipp,
>>>
>>> This patch series is waiting for opening new merge window. It is 
>>> already applied to usb-next tree.
>> Didn’t the new merge window just open yesterday?
>
> I'm sure Marek will send PR shortly.

 I don’t see this series on u-boot-usb/master … what is the status on this?
 I have multiple dependent series pending in my queue that are waiting on 
 this one...
>>>
>>> It didn't pass travisci tests, I'm waiting for one which does.
>>> Can you retest and resubmit , so Lukasz can pick it again ?
>>>
>>> Sorry it takes one more cycle.
>>
>> Could you follow up on Marek’s request to retest and resubmit?
>
> Any news on this?
> I still have a number of patches blocked (in the rockchip-queue) blocked by 
> rockusb not being there yet.
>
>> Thanks,
>> Philipp.
>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-11-20 Thread Dr. Philipp Tomsich 
Kever & Eddie,

> On 2 Oct 2017, at 12:51, Dr. Philipp Tomsich 
>  wrote:
> 
> +Kever, +Eddie
> 
> Kever & Eddie,
> 
>> On 2 Oct 2017, at 12:41, Marek Vasut  wrote:
>> 
>> On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote:
>>> Lukasz & Marek,
>>> 
 On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
 
 Hi Dr. Philipp,
 
> Hi Lukasz,
>> On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:
>> 
>> Hi Philipp,
>> 
>> This patch series is waiting for opening new merge window. It is already 
>> applied to usb-next tree.
> Didn’t the new merge window just open yesterday?
 
 I'm sure Marek will send PR shortly.
>>> 
>>> I don’t see this series on u-boot-usb/master … what is the status on this?
>>> I have multiple dependent series pending in my queue that are waiting on 
>>> this one...
>> 
>> It didn't pass travisci tests, I'm waiting for one which does.
>> Can you retest and resubmit , so Lukasz can pick it again ?
>> 
>> Sorry it takes one more cycle.
> 
> Could you follow up on Marek’s request to retest and resubmit?

Any news on this?
I still have a number of patches blocked (in the rockchip-queue) blocked by 
rockusb not being there yet.

> Thanks,
> Philipp.
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-10-02 Thread Dr. Philipp Tomsich 
+Kever, +Eddie

Kever & Eddie,

> On 2 Oct 2017, at 12:41, Marek Vasut  wrote:
> 
> On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote:
>> Lukasz & Marek,
>> 
>>> On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
>>> 
>>> Hi Dr. Philipp,
>>> 
 Hi Lukasz,
> On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:
> 
> Hi Philipp,
> 
> This patch series is waiting for opening new merge window. It is already 
> applied to usb-next tree.
 Didn’t the new merge window just open yesterday?
>>> 
>>> I'm sure Marek will send PR shortly.
>> 
>> I don’t see this series on u-boot-usb/master … what is the status on this?
>> I have multiple dependent series pending in my queue that are waiting on 
>> this one...
> 
> It didn't pass travisci tests, I'm waiting for one which does.
> Can you retest and resubmit , so Lukasz can pick it again ?
> 
> Sorry it takes one more cycle.

Could you take follow up on Marek’s request to retest and resubmit?

Thanks,
Philipp.

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-10-02 Thread Marek Vasut 
On 10/02/2017 12:40 PM, Dr. Philipp Tomsich wrote:
> Lukasz & Marek,
> 
>> On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
>>
>> Hi Dr. Philipp,
>>
>>> Hi Lukasz,
 On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:

 Hi Philipp,

 This patch series is waiting for opening new merge window. It is already 
 applied to usb-next tree.
>>> Didn’t the new merge window just open yesterday?
>>
>> I'm sure Marek will send PR shortly.
> 
> I don’t see this series on u-boot-usb/master … what is the status on this?
> I have multiple dependent series pending in my queue that are waiting on this 
> one...

It didn't pass travisci tests, I'm waiting for one which does.
Can you retest and resubmit , so Lukasz can pick it again ?

Sorry it takes one more cycle.

-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-10-02 Thread Dr. Philipp Tomsich 
Lukasz & Marek,

> On 12 Sep 2017, at 10:43, Łukasz Majewski  wrote:
> 
> Hi Dr. Philipp,
> 
>> Hi Lukasz,
>>> On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:
>>> 
>>> Hi Philipp,
>>> 
>>> This patch series is waiting for opening new merge window. It is already 
>>> applied to usb-next tree.
>> Didn’t the new merge window just open yesterday?
> 
> I'm sure Marek will send PR shortly.

I don’t see this series on u-boot-usb/master … what is the status on this?
I have multiple dependent series pending in my queue that are waiting on this 
one...

>> Regards,
>> Philipp.
>>> 
> this patch implement rockusb protocol on the device side. this is based 
> on USB
> download gadget infrastructure. the rockusb function implements the rd, 
> wl, rid
> commands. it can work with rkdeveloptool
> 
> Signed-off-by: Eddie Cai 
> Reviewed-by: Simon Glass 
> 
> Changes in v9:
> -fix compile error
> 
> Changes in v8:
> -none
> 
> Changes in v7:
> -none
> 
> Changes in v6:
> -move some data to f_rockusb structure
> 
> Changes in v5:
> -fix build error when build non-rockchip board
> -fix checkpatch error
> 
> Changes in v4:
> -use enum instead of macro define
> -move some structure define and macro to f_rockusb.h
> -add some function comment as Simon required
> -address other comment from Simon
> -fix build error as Lukasz point out
> ---
>  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
>  drivers/usb/gadget/Kconfig |   8 +
>  drivers/usb/gadget/Makefile|   1 +
>  drivers/usb/gadget/f_rockusb.c | 691 
> +
>  4 files changed, 832 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>  create mode 100644 drivers/usb/gadget/f_rockusb.c
> 
 Acked-by: Philipp Tomsich 
>>> 
>>> 
>>> -- 
>>> Best regards,
>>> 
>>> Lukasz Majewski
>>> 
>>> --
>>> 
>>> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 
>>> 
> 
> 
> -- 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-09-12 Thread Philipp Tomsich 
> this patch implement rockusb protocol on the device side. this is based on USB
> download gadget infrastructure. the rockusb function implements the rd, wl, 
> rid
> commands. it can work with rkdeveloptool
> 
> Signed-off-by: Eddie Cai 
> Reviewed-by: Simon Glass 
> 
> Changes in v9:
>   
> -fix compile error
> 
> Changes in v8:
>   
> -none
> 
> Changes in v7:
> -none
> 
> Changes in v6:
> -move some data to f_rockusb structure
> 
> Changes in v5:
> -fix build error when build non-rockchip board
> -fix checkpatch error
> 
> Changes in v4:
> -use enum instead of macro define
> -move some structure define and macro to f_rockusb.h
> -add some function comment as Simon required
> -address other comment from Simon
> -fix build error as Lukasz point out
> ---
>  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
>  drivers/usb/gadget/Kconfig |   8 +
>  drivers/usb/gadget/Makefile|   1 +
>  drivers/usb/gadget/f_rockusb.c | 691 
> +
>  4 files changed, 832 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>  create mode 100644 drivers/usb/gadget/f_rockusb.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-09-12 Thread Dr. Philipp Tomsich 
Hi Lukasz,

> On 12 Sep 2017, at 10:14, Łukasz Majewski  wrote:
> 
> Hi Philipp,
> 
> This patch series is waiting for opening new merge window. It is already 
> applied to usb-next tree.

Didn’t the new merge window just open yesterday?

Regards,
Philipp.

> 
>>> this patch implement rockusb protocol on the device side. this is based on 
>>> USB
>>> download gadget infrastructure. the rockusb function implements the rd, wl, 
>>> rid
>>> commands. it can work with rkdeveloptool
>>> 
>>> Signed-off-by: Eddie Cai 
>>> Reviewed-by: Simon Glass 
>>> 
>>> Changes in v9:
>>> -fix compile error
>>> 
>>> Changes in v8:
>>> -none
>>> 
>>> Changes in v7:
>>> -none
>>> 
>>> Changes in v6:
>>> -move some data to f_rockusb structure
>>> 
>>> Changes in v5:
>>> -fix build error when build non-rockchip board
>>> -fix checkpatch error
>>> 
>>> Changes in v4:
>>> -use enum instead of macro define
>>> -move some structure define and macro to f_rockusb.h
>>> -add some function comment as Simon required
>>> -address other comment from Simon
>>> -fix build error as Lukasz point out
>>> ---
>>>  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
>>>  drivers/usb/gadget/Kconfig |   8 +
>>>  drivers/usb/gadget/Makefile|   1 +
>>>  drivers/usb/gadget/f_rockusb.c | 691 
>>> +
>>>  4 files changed, 832 insertions(+)
>>>  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>>>  create mode 100644 drivers/usb/gadget/f_rockusb.c
>>> 
>> Acked-by: Philipp Tomsich 
> 
> 
> -- 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-09-12 Thread Łukasz Majewski 

Hi Philipp,

This patch series is waiting for opening new merge window. It is already 
applied to usb-next tree.



this patch implement rockusb protocol on the device side. this is based on USB
download gadget infrastructure. the rockusb function implements the rd, wl, rid
commands. it can work with rkdeveloptool

Signed-off-by: Eddie Cai 
Reviewed-by: Simon Glass 

Changes in v9:
-fix compile error

Changes in v8:
-none

Changes in v7:
-none

Changes in v6:
-move some data to f_rockusb structure

Changes in v5:
-fix build error when build non-rockchip board
-fix checkpatch error

Changes in v4:
-use enum instead of macro define
-move some structure define and macro to f_rockusb.h
-add some function comment as Simon required
-address other comment from Simon
-fix build error as Lukasz point out
---
  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
  drivers/usb/gadget/Kconfig |   8 +
  drivers/usb/gadget/Makefile|   1 +
  drivers/usb/gadget/f_rockusb.c | 691 +
  4 files changed, 832 insertions(+)
  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
  create mode 100644 drivers/usb/gadget/f_rockusb.c



Acked-by: Philipp Tomsich 




--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [U-Boot,V9,1/4] usb: rockchip: add the rockusb gadget

2017-09-11 Thread Philipp Tomsich 
> this patch implement rockusb protocol on the device side. this is based on USB
> download gadget infrastructure. the rockusb function implements the rd, wl, 
> rid
> commands. it can work with rkdeveloptool
> 
> Signed-off-by: Eddie Cai 
> Reviewed-by: Simon Glass 
> 
> Changes in v9:
>   
> -fix compile error
> 
> Changes in v8:
>   
> -none
> 
> Changes in v7:
> -none
> 
> Changes in v6:
> -move some data to f_rockusb structure
> 
> Changes in v5:
> -fix build error when build non-rockchip board
> -fix checkpatch error
> 
> Changes in v4:
> -use enum instead of macro define
> -move some structure define and macro to f_rockusb.h
> -add some function comment as Simon required
> -address other comment from Simon
> -fix build error as Lukasz point out
> ---
>  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +
>  drivers/usb/gadget/Kconfig |   8 +
>  drivers/usb/gadget/Makefile|   1 +
>  drivers/usb/gadget/f_rockusb.c | 691 
> +
>  4 files changed, 832 insertions(+)
>  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>  create mode 100644 drivers/usb/gadget/f_rockusb.c
> 

Acked-by: Philipp Tomsich 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot