Re: [U-Boot] [U-Boot-DM] [PATCH] drivers: serial: lpuart: Enable Little Endian Support
Hi, On Fri, 19 Apr 2019 at 03:34, Marek Vasut wrote: > > On 4/18/19 2:30 PM, Vabhav Sharma wrote: > > Hello Maintainers, > > A gentle reminder to merge the changes. > > Next time, use > $ ./scripts/get_maintainer.pl -f drivers/serial/serial_lpuart.c > and actually CC the maintainers. > > > Regards, > > Vabhav Applied to u-boot-dm, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [U-Boot-DM] [PATCH] drivers: serial: lpuart: Enable Little Endian Support
Hi Vabhav, On Thu, 18 Apr 2019 at 06:30, Vabhav Sharma wrote: > > Hello Maintainers, > A gentle reminder to merge the changes. > > Regards, > Vabhav > > > -Original Message- > > From: Vabhav Sharma > > Sent: Thursday, January 31, 2019 5:38 PM > > To: u-boot@lists.denx.de; u-boot...@lists.denx.de > > Cc: Vabhav Sharma > > Subject: [PATCH] drivers: serial: lpuart: Enable Little Endian Support > > > > By default LPUART driver with compatible string "fsl,ls1021a-lpuart" > > support big-endian mode.On NXP SoC like LS1028A LPUART IP is little- > > endian,Added support to Fetch LPUART IP Endianness from lpuart device- > > tree node. > > > > Signed-off-by: Vabhav Sharma > > --- > > drivers/serial/serial_lpuart.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/serial/serial_lpuart.c > > b/drivers/serial/serial_lpuart.c index > > a357b00..57dd4a7 100644 > > --- a/drivers/serial/serial_lpuart.c > > +++ b/drivers/serial/serial_lpuart.c > > @@ -1,5 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > /* > > + * Copyright 2019 NXP > > * Copyright 2013 Freescale Semiconductor, Inc. > > */ > > > > @@ -502,6 +503,9 @@ static int lpuart_serial_ofdata_to_platdata(struct > > udevice *dev) > > plat->reg = (void *)addr; > > plat->flags = dev_get_driver_data(dev); > > > > +if (fdtdec_get_bool(blob, node, "little-endian")) > > +plat->flags &= ~LPUART_FLAG_REGMAP_ENDIAN_BIG; As Marek says, please cc the maintainers. If you use 'patman' to send your patches, it will be done for you. Reviewed-by: Simon Glass Can I suggest that you change this driver to live-tree instead? (dev_read_bool()). > > + > > if (!fdt_node_check_compatible(blob, node, "fsl,ls1021a-lpuart")) > > plat->devtype = DEV_LS1021A; This should use a compatible array - see lpuart_serial_ids. It seems that this is currently used for flags, but it could use the DEV_... values. > > else if (!fdt_node_check_compatible(blob, node, "fsl,imx7ulp- > > lpuart")) > > -- > > 2.7.4 > > ___ > U-Boot-DM mailing list > u-boot...@lists.denx.de > https://lists.denx.de/listinfo/u-boot-dm Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [U-Boot-DM] [PATCH] drivers: serial: lpuart: Enable Little Endian Support
On 4/18/19 2:30 PM, Vabhav Sharma wrote: > Hello Maintainers, > A gentle reminder to merge the changes. Next time, use $ ./scripts/get_maintainer.pl -f drivers/serial/serial_lpuart.c and actually CC the maintainers. > Regards, > Vabhav > >> -Original Message- >> From: Vabhav Sharma >> Sent: Thursday, January 31, 2019 5:38 PM >> To: u-boot@lists.denx.de; u-boot...@lists.denx.de >> Cc: Vabhav Sharma >> Subject: [PATCH] drivers: serial: lpuart: Enable Little Endian Support >> >> By default LPUART driver with compatible string "fsl,ls1021a-lpuart" >> support big-endian mode.On NXP SoC like LS1028A LPUART IP is little- >> endian,Added support to Fetch LPUART IP Endianness from lpuart device- >> tree node. >> >> Signed-off-by: Vabhav Sharma >> --- >> drivers/serial/serial_lpuart.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/serial/serial_lpuart.c b/drivers/serial/serial_lpuart.c >> index >> a357b00..57dd4a7 100644 >> --- a/drivers/serial/serial_lpuart.c >> +++ b/drivers/serial/serial_lpuart.c >> @@ -1,5 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0+ >> /* >> + * Copyright 2019 NXP >> * Copyright 2013 Freescale Semiconductor, Inc. >> */ >> >> @@ -502,6 +503,9 @@ static int lpuart_serial_ofdata_to_platdata(struct >> udevice *dev) >> plat->reg = (void *)addr; >> plat->flags = dev_get_driver_data(dev); >> >> +if (fdtdec_get_bool(blob, node, "little-endian")) >> +plat->flags &= ~LPUART_FLAG_REGMAP_ENDIAN_BIG; >> + >> if (!fdt_node_check_compatible(blob, node, "fsl,ls1021a-lpuart")) >> plat->devtype = DEV_LS1021A; >> else if (!fdt_node_check_compatible(blob, node, "fsl,imx7ulp- >> lpuart")) >> -- >> 2.7.4 > > ___ > U-Boot-DM mailing list > u-boot...@lists.denx.de > https://lists.denx.de/listinfo/u-boot-dm > -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
