Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-13 Thread Sergei Shtylyov 
Hello.

On 12-01-2011 17:52, seedshope wrote:

 Since SDRAM init function have already change, So the SDRAM
 initial function must be change.

 Signed-off-by: seedshopebocui...@gmail.com

 diff --git a/board/samsung/smdk6400/smdk6400.c
 b/board/samsung/smdk6400/smdk6400.c
 index 35aa40b..52b44a8 100644
 --- a/board/samsung/smdk6400/smdk6400.c
 +++ b/board/samsung/smdk6400/smdk6400.c
 @@ -78,10 +78,18 @@ int board_init(void)
 return 0;
 }

 -int dram_init(void)
 +void dram_init_banksize(void)
 {
 + DECLARE_GLOBAL_DATA_PTR;
 +
 gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
 gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
 +}
 +
 +int dram_init(void)
 +{
 + gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
 + CONFIG_MAX_RAM_BANK_SIZE);

 Please indent that line more to the right, preferrebly start it under
 '(volatile long *)'.

 ok, But I don't know how number tab indent is appropriate. May be the effect
 as following？
 gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
 CONFIG_MAX_RAM_BANK_SIZE);

I've asked you specifically to do this:

gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
CONFIG_MAX_RAM_BANK_SIZE);

 Thanks，
 seedshope

WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-12 Thread Sergei Shtylyov 
Hello.

On 11-01-2011 17:52, seedshope wrote:

 Since SDRAM init function have already change, So the SDRAM
 initial function must be change.

 Signed-off-by: seedshopebocui...@gmail.com

 diff --git a/board/samsung/smdk6400/smdk6400.c 
 b/board/samsung/smdk6400/smdk6400.c
 index 35aa40b..52b44a8 100644
 --- a/board/samsung/smdk6400/smdk6400.c
 +++ b/board/samsung/smdk6400/smdk6400.c
 @@ -78,10 +78,18 @@ int board_init(void)
   return 0;
   }

 -int dram_init(void)
 +void dram_init_banksize(void)
   {
 + DECLARE_GLOBAL_DATA_PTR;
 +
   gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
   gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
 +}
 +
 +int dram_init(void)
 +{
 + gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
 + CONFIG_MAX_RAM_BANK_SIZE);

Please indent that line more to the right, preferrebly start it under 
'(volatile long *)'.

WBR, Sergei
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-12 Thread seedshope 
On 01/12/2011 07:08 PM, Sergei Shtylyov wrote:
 Hello.

 On 11-01-2011 17:52, seedshope wrote:

 Since SDRAM init function have already change, So the SDRAM
 initial function must be change.

 Signed-off-by: seedshopebocui...@gmail.com

 diff --git a/board/samsung/smdk6400/smdk6400.c 
 b/board/samsung/smdk6400/smdk6400.c
 index 35aa40b..52b44a8 100644
 --- a/board/samsung/smdk6400/smdk6400.c
 +++ b/board/samsung/smdk6400/smdk6400.c
 @@ -78,10 +78,18 @@ int board_init(void)
 return 0;
 }

 -int dram_init(void)
 +void dram_init_banksize(void)
 {
 + DECLARE_GLOBAL_DATA_PTR;
 +
 gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
 gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
 +}
 +
 +int dram_init(void)
 +{
 + gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
 + CONFIG_MAX_RAM_BANK_SIZE);

 Please indent that line more to the right, preferrebly start it under 
 '(volatile long *)'.
ok, But I don't know how number tab indent is appropriate. May be the 
effect as following？
gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
CONFIG_MAX_RAM_BANK_SIZE);

Thanks，
seedshope


 WBR, Sergei

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-12 Thread Wolfgang Denk 
Dear seedshope,

In message 4d2dc040.7040...@gmail.com you wrote:
 
 ok, But I don't know how number tab indent is appropriate. May be the
 effect as following?

You should start reading http://www.denx.de/wiki/U-Boot/CodingStyle
(and follow the links shown there).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Oh dear, I think you'll find reality's on the blink again.
- Marvin The Paranoid Android
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-11 Thread seedshope 
Since SDRAM init function have already change, So the SDRAM
initial function must be change.

Signed-off-by: seedshope bocui...@gmail.com

diff --git a/board/samsung/smdk6400/smdk6400.c 
b/board/samsung/smdk6400/smdk6400.c
index 35aa40b..52b44a8 100644
--- a/board/samsung/smdk6400/smdk6400.c
+++ b/board/samsung/smdk6400/smdk6400.c
@@ -78,10 +78,18 @@ int board_init(void)
return 0;
 }
 
-int dram_init(void)
+void dram_init_banksize(void)
 {
+   DECLARE_GLOBAL_DATA_PTR;
+
gd-bd-bi_dram[0].start = PHYS_SDRAM_1;
gd-bd-bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+}
+
+int dram_init(void)
+{
+   gd-ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+   CONFIG_MAX_RAM_BANK_SIZE);
 
return 0;
 }
-- 
1.7.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot