Re: [U-Boot] [PATCH v3 01/11] nand: remove CONFIG_SYS_NAND_PAGE_SIZE
On 08/05/2014 07:16, Tim Harvey wrote: We only need to read in the size of struct image_header and thus don't need to know the page size of the nand device. Cc: Scott Wood scottw...@freescale.com Signed-off-by: Tim Harvey thar...@gateworks.com Acked-by: Stefano Babic sba...@denx.de Acked-by: Scott Wood scottw...@freescale.com --- As discussed : applied to u-boot-imx, thanks. Tim, please remove it in your next post, thanks. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 01/11] nand: remove CONFIG_SYS_NAND_PAGE_SIZE
Hi. On Wed, 7 May 2014 22:16:12 -0700 Tim Harvey thar...@gateworks.com wrote: We only need to read in the size of struct image_header and thus don't need to know the page size of the nand device. Cc: Scott Wood scottw...@freescale.com Signed-off-by: Tim Harvey thar...@gateworks.com Acked-by: Stefano Babic sba...@denx.de Acked-by: Scott Wood scottw...@freescale.com --- v3: - no changes v2: - cc Scott Wood scottw...@freescale.com on this - Acked-by: Stefano Babic sba...@denx.de - Acked-by: Scott Wood scottw...@freescale.com When and by whom will this patch be applied? Since this is not IMX-specific, I'd like this patch to be applied first. Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 01/11] nand: remove CONFIG_SYS_NAND_PAGE_SIZE
Hi Masahiro, On 14/05/2014 10:52, Masahiro Yamada wrote: Hi. On Wed, 7 May 2014 22:16:12 -0700 Tim Harvey thar...@gateworks.com wrote: We only need to read in the size of struct image_header and thus don't need to know the page size of the nand device. Cc: Scott Wood scottw...@freescale.com Signed-off-by: Tim Harvey thar...@gateworks.com Acked-by: Stefano Babic sba...@denx.de Acked-by: Scott Wood scottw...@freescale.com --- v3: - no changes v2: - cc Scott Wood scottw...@freescale.com on this - Acked-by: Stefano Babic sba...@denx.de - Acked-by: Scott Wood scottw...@freescale.com When and by whom will this patch be applied? Since this is not IMX-specific, I'd like this patch to be applied first. It is not iMX specific, but in the last iteration Scott acked it and give us indication to let it in the patchset - plan was to apply the patchset as a whole in one shot, that is by me. I can propose I apply this (and maybe a couple of other patches in this patchset that have already passed the review and they were acked) and this is part of my next pull request to Albert. Or maybe Tom decides to apply it directly to master, and Tim drops it from the patchset. Best regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 01/11] nand: remove CONFIG_SYS_NAND_PAGE_SIZE
We only need to read in the size of struct image_header and thus don't need to know the page size of the nand device. Cc: Scott Wood scottw...@freescale.com Signed-off-by: Tim Harvey thar...@gateworks.com Acked-by: Stefano Babic sba...@denx.de Acked-by: Scott Wood scottw...@freescale.com --- v3: - no changes v2: - cc Scott Wood scottw...@freescale.com on this - Acked-by: Stefano Babic sba...@denx.de - Acked-by: Scott Wood scottw...@freescale.com --- common/spl/spl_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c index 9da0218..062461b 100644 --- a/common/spl/spl_nand.c +++ b/common/spl/spl_nand.c @@ -76,7 +76,7 @@ void spl_nand_load_image(void) #endif /* Load u-boot */ nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS, - CONFIG_SYS_NAND_PAGE_SIZE, (void *)header); + sizeof(*header), (void *)header); spl_parse_image_header(header); nand_spl_load_image(CONFIG_SYS_NAND_U_BOOT_OFFS, spl_image.size, (void *)spl_image.load_addr); -- 1.8.3.2 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
