Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
Hi Kever On Mon, Sep 16, 2019 at 10:45 AM Jagan Teki wrote: > > On Mon, Sep 16, 2019 at 1:54 PM Kever Yang wrote: > > > > Hi Jagan, > > > > On 2019/9/12 上午11:25, Jagan Teki wrote: > > > I have seen this even on v2019.07 release, and the only release that > > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > > > Any idea? here is the log dump. > > > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > > Trying to boot from MMC1 > > > spl: mmc init failed with error: -110 > > > SPL: failed to boot from all boot devices > > > ### ERROR ### Please RESET the board ### > > > > > > Please try with set emmc with 'fifo-mode;' in dts, I can work with this > > update, but no idea about fifo-mode is not working but i can move forward more Michael > > This is sdmmc, do you want us to try the same. > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Mon, Sep 16, 2019 at 1:54 PM Kever Yang wrote: > > Hi Jagan, > > On 2019/9/12 上午11:25, Jagan Teki wrote: > > I have seen this even on v2019.07 release, and the only release that > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > Any idea? here is the log dump. > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > Trying to boot from BOOTROM > > Returning to boot ROM... > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > Trying to boot from MMC1 > > spl: mmc init failed with error: -110 > > SPL: failed to boot from all boot devices > > ### ERROR ### Please RESET the board ### > > > Please try with set emmc with 'fifo-mode;' in dts, I can work with this > update, but no idea about This is sdmmc, do you want us to try the same. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
Hi Jagan, On 2019/9/12 上午11:25, Jagan Teki wrote: I have seen this even on v2019.07 release, and the only release that it got working with on v2019.01 (SPL, BROM_RETURN) Any idea? here is the log dump. U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) Trying to boot from BOOTROM Returning to boot ROM... U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) Trying to boot from MMC1 spl: mmc init failed with error: -110 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### Please try with set emmc with 'fifo-mode;' in dts, I can work with this update, but no idea about the reason now. Thanks, - Kever Jagan. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
Hi Jagan On Sat, Sep 14, 2019 at 2:17 PM Michael Trimarchi wrote: > > On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote: > > On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote: > > > > > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > > > > > > > I have seen this even on v2019.07 release, and the only release that > > > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > > > > > Any idea? here is the log dump. > > > > > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > > > Trying to boot from BOOTROM > > > > Returning to boot ROM... > > > > > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > > > Trying to boot from MMC1 > > > > spl: mmc init failed with error: -110 > > > > SPL: failed to boot from all boot devices > > > > ### ERROR ### Please RESET the board ### > > > > > > Time to run 'git bisect' since you know when it worked last at least? > > > > Look hard to bisect, few of commits in between seems SPL size > > blow-out, doesn't boot etc. May be verify with respect boards might > > help. > > Well I think that ddr should follow the same rule of rk3399, but still > the mmc is not working > We can skip this patch, memory is anyway initialized from TPL. without it Michael > From c457eb849ce31a75db50a9b99e09d2453ee40580 Mon Sep 17 00:00:00 2001 > From: Michael Trimarchi > Date: Sat, 14 Sep 2019 13:34:08 +0200 > Subject: [PATCH 1/2] rockchip: ram: rk3288: Init ram in TPL when is configured > > Init the ddr sdram in TPL instead of SPL, update the code. > > Signed-off-by: Michael Trimarchi > --- > drivers/ram/rockchip/sdram_rk3288.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/ram/rockchip/sdram_rk3288.c > b/drivers/ram/rockchip/sdram_rk3288.c > index 6bb025a851..5775254007 100644 > --- a/drivers/ram/rockchip/sdram_rk3288.c > +++ b/drivers/ram/rockchip/sdram_rk3288.c > @@ -79,7 +79,8 @@ const int ddrconf_table[] = { > #define DQS_GATE_TRAINING_ERROR_RANK0 (1 << 4) > #define DQS_GATE_TRAINING_ERROR_RANK1 (2 << 4) > > -#ifdef CONFIG_SPL_BUILD > +#if defined(CONFIG_TPL_BUILD) || \ > + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) > static void copy_to_reg(u32 *dest, const u32 *src, u32 n) > { > int i; > @@ -1035,7 +1036,8 @@ static int conv_of_platdata(struct udevice *dev) > > static int rk3288_dmc_probe(struct udevice *dev) > { > -#ifdef CONFIG_SPL_BUILD > +#if defined(CONFIG_TPL_BUILD) || \ > + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) > struct rk3288_sdram_params *plat = dev_get_platdata(dev); > struct udevice *dev_clk; > struct regmap *map; > @@ -1044,7 +1046,8 @@ static int rk3288_dmc_probe(struct udevice *dev) > struct dram_info *priv = dev_get_priv(dev); > > priv->pmu = syscon_get_first_range(ROCKCHIP_SYSCON_PMU); > -#ifdef CONFIG_SPL_BUILD > +#if defined(CONFIG_TPL_BUILD) || \ > + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) > #if CONFIG_IS_ENABLED(OF_PLATDATA) > ret = conv_of_platdata(dev); > if (ret) > @@ -,12 +1114,14 @@ U_BOOT_DRIVER(dmc_rk3288) = { > .id = UCLASS_RAM, > .of_match = rk3288_dmc_ids, > .ops = _dmc_ops, > -#ifdef CONFIG_SPL_BUILD > +#if defined(CONFIG_TPL_BUILD) || \ > + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) > .ofdata_to_platdata = rk3288_dmc_ofdata_to_platdata, > #endif > .probe = rk3288_dmc_probe, > .priv_auto_alloc_size = sizeof(struct dram_info), > -#ifdef CONFIG_SPL_BUILD > +#if defined(CONFIG_TPL_BUILD) || \ > + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) > .platdata_auto_alloc_size = sizeof(struct rk3288_sdram_params), > #endif > }; > -- > 2.17.1 > > > ___ > > U-Boot mailing list > > U-Boot@lists.denx.de > > https://lists.denx.de/listinfo/u-boot > > -- > | Michael Nazzareno Trimarchi Amarula Solutions BV | > | COO - Founder Cruquiuskade 47 | > | +31(0)851119172 Amsterdam 1018 AM NL | > | [`as] http://www.amarulasolutions.com | -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote: > On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote: > > > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > > > > > I have seen this even on v2019.07 release, and the only release that > > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > > > Any idea? here is the log dump. > > > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > > Trying to boot from MMC1 > > > spl: mmc init failed with error: -110 > > > SPL: failed to boot from all boot devices > > > ### ERROR ### Please RESET the board ### > > > > Time to run 'git bisect' since you know when it worked last at least? > > Look hard to bisect, few of commits in between seems SPL size > blow-out, doesn't boot etc. May be verify with respect boards might > help. Well I think that ddr should follow the same rule of rk3399, but still the mmc is not working From c457eb849ce31a75db50a9b99e09d2453ee40580 Mon Sep 17 00:00:00 2001 From: Michael Trimarchi Date: Sat, 14 Sep 2019 13:34:08 +0200 Subject: [PATCH 1/2] rockchip: ram: rk3288: Init ram in TPL when is configured Init the ddr sdram in TPL instead of SPL, update the code. Signed-off-by: Michael Trimarchi --- drivers/ram/rockchip/sdram_rk3288.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/ram/rockchip/sdram_rk3288.c b/drivers/ram/rockchip/sdram_rk3288.c index 6bb025a851..5775254007 100644 --- a/drivers/ram/rockchip/sdram_rk3288.c +++ b/drivers/ram/rockchip/sdram_rk3288.c @@ -79,7 +79,8 @@ const int ddrconf_table[] = { #define DQS_GATE_TRAINING_ERROR_RANK0 (1 << 4) #define DQS_GATE_TRAINING_ERROR_RANK1 (2 << 4) -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) static void copy_to_reg(u32 *dest, const u32 *src, u32 n) { int i; @@ -1035,7 +1036,8 @@ static int conv_of_platdata(struct udevice *dev) static int rk3288_dmc_probe(struct udevice *dev) { -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) struct rk3288_sdram_params *plat = dev_get_platdata(dev); struct udevice *dev_clk; struct regmap *map; @@ -1044,7 +1046,8 @@ static int rk3288_dmc_probe(struct udevice *dev) struct dram_info *priv = dev_get_priv(dev); priv->pmu = syscon_get_first_range(ROCKCHIP_SYSCON_PMU); -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) #if CONFIG_IS_ENABLED(OF_PLATDATA) ret = conv_of_platdata(dev); if (ret) @@ -,12 +1114,14 @@ U_BOOT_DRIVER(dmc_rk3288) = { .id = UCLASS_RAM, .of_match = rk3288_dmc_ids, .ops = _dmc_ops, -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) .ofdata_to_platdata = rk3288_dmc_ofdata_to_platdata, #endif .probe = rk3288_dmc_probe, .priv_auto_alloc_size = sizeof(struct dram_info), -#ifdef CONFIG_SPL_BUILD +#if defined(CONFIG_TPL_BUILD) || \ + (!defined(CONFIG_TPL) && defined(CONFIG_SPL_BUILD)) .platdata_auto_alloc_size = sizeof(struct rk3288_sdram_params), #endif }; -- 2.17.1 > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
Hi Tom On Fri, Sep 13, 2019 at 5:47 PM Tom Rini wrote: > > On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote: > > On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote: > > > > > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > > > > > > > I have seen this even on v2019.07 release, and the only release that > > > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > > > > > Any idea? here is the log dump. > > > > > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > > > Trying to boot from BOOTROM > > > > Returning to boot ROM... > > > > > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > > > Trying to boot from MMC1 > > > > spl: mmc init failed with error: -110 > > > > SPL: failed to boot from all boot devices > > > > ### ERROR ### Please RESET the board ### > > > > > > Time to run 'git bisect' since you know when it worked last at least? > > > > Look hard to bisect, few of commits in between seems SPL size > > blow-out, doesn't boot etc. May be verify with respect boards might > > help. > > It certainly sounds like a challenging bisect, yes. I've 'bisect > skip'ed and then 'git stash save' / 'git stash apply' a handful of > work-arounds to narrow down hard cases like this before. It's also > worth keeping in mind that you can insert steps manually into a bisect. > For something like this where v2019.01 works and HEAD doesn't, I'd do: > $ git bisect start > $ git bisect good v2019.01 > $ git bisect bad v2019.10-rc3 > $ git checkout v2019.04 > and see what happens. U-Boot TPL 2019.10-rc3-00307-g87d5b22558-dirty (Sep 13 2019 - 20:06:40) Trying to boot from BOOTROM Returning to boot ROM... U-Boot SPL 2019.10-rc3-00307-g87d5b22558-dirty (Sep 13 2019 - 20:06:40 +0200) Trying to boot from MMC1 Buswidth = 0, clock: 0 Buswidth = 1, clock: 0 Buswidth = 1, clock: 40 Sending CMD0 Sending CMD8 Sending CMD55 Sending CMD41 Sending CMD55 Sending CMD41 Sending CMD2 Sending CMD3 Sending CMD9 Sending CMD7 Sending CMD55 Sending CMD51 dwmci_data_transfer: Timeout waiting for data! wait_for_bit_le32: Timeout (reg= mask=2 wait_set=) dwmci_send_cmd: DWMCI_IDINTEN mask 0x2 timeout. Sending CMD51 dwmci_send_cmd: Response Timeout. Sending CMD51 dwmci_send_cmd: Response Timeout. Sending CMD51 dwmci_send_cmd: Response Timeout. spl: mmc init failed with error: -110 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### It's broken since a lot most of the version does not boot because SPL is too big. This the problem I have in debug CMD51 is get_capabilitis Michael > > -- > Tom > ___ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Fri, Sep 13, 2019 at 08:11:17AM +0530, Jagan Teki wrote: > On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote: > > > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > > > > > I have seen this even on v2019.07 release, and the only release that > > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > > > Any idea? here is the log dump. > > > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > > Trying to boot from MMC1 > > > spl: mmc init failed with error: -110 > > > SPL: failed to boot from all boot devices > > > ### ERROR ### Please RESET the board ### > > > > Time to run 'git bisect' since you know when it worked last at least? > > Look hard to bisect, few of commits in between seems SPL size > blow-out, doesn't boot etc. May be verify with respect boards might > help. It certainly sounds like a challenging bisect, yes. I've 'bisect skip'ed and then 'git stash save' / 'git stash apply' a handful of work-arounds to narrow down hard cases like this before. It's also worth keeping in mind that you can insert steps manually into a bisect. For something like this where v2019.01 works and HEAD doesn't, I'd do: $ git bisect start $ git bisect good v2019.01 $ git bisect bad v2019.10-rc3 $ git checkout v2019.04 and see what happens. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Thu, Sep 12, 2019 at 8:25 PM Tom Rini wrote: > > On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > > > I have seen this even on v2019.07 release, and the only release that > > it got working with on v2019.01 (SPL, BROM_RETURN) > > > > Any idea? here is the log dump. > > > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > > Trying to boot from BOOTROM > > Returning to boot ROM... > > > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > > Trying to boot from MMC1 > > spl: mmc init failed with error: -110 > > SPL: failed to boot from all boot devices > > ### ERROR ### Please RESET the board ### > > Time to run 'git bisect' since you know when it worked last at least? Look hard to bisect, few of commits in between seems SPL size blow-out, doesn't boot etc. May be verify with respect boards might help. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] Tinker-rk3288 SPL broken with MMC timeout
On Thu, Sep 12, 2019 at 08:55:24AM +0530, Jagan Teki wrote: > I have seen this even on v2019.07 release, and the only release that > it got working with on v2019.01 (SPL, BROM_RETURN) > > Any idea? here is the log dump. > > U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) > Trying to boot from BOOTROM > Returning to boot ROM... > > U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) > Trying to boot from MMC1 > spl: mmc init failed with error: -110 > SPL: failed to boot from all boot devices > ### ERROR ### Please RESET the board ### Time to run 'git bisect' since you know when it worked last at least? -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] Tinker-rk3288 SPL broken with MMC timeout
I have seen this even on v2019.07 release, and the only release that it got working with on v2019.01 (SPL, BROM_RETURN) Any idea? here is the log dump. U-Boot TPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36) Trying to boot from BOOTROM Returning to boot ROM... U-Boot SPL 2019.10-rc3-00297-g5ba8b12543 (Sep 12 2019 - 08:50:36 +0530) Trying to boot from MMC1 spl: mmc init failed with error: -110 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ### Jagan. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot