Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Clemens Gruber]

On Tue, Jan 26, 2016 at 10:53:58AM +0800, Peng Fan wrote:
> Yeah. The patch I wrote include fix write_env, and a function prototype in
> header file.
> 
> If the current patch already applied, I can write a follow up patch.
> 
> Thanks,
> Peng.
> 

Hi Peng,

sorry, I did not know there was already a similar patch.

However, now when looking over your patch, it tries to fix read_env and
write_env, which is not necessary, because the device number is stored
in struct mmc.

What's missing though is the function prototype in the header.

Tom, should I send a v2 of the patch or a follow-up? Or do you want to
fix this up, Peng?

Thanks.
Clemens
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Tom Rini]

On Tue, Jan 26, 2016 at 10:52:39AM +0100, Clemens Gruber wrote:
> On Tue, Jan 26, 2016 at 10:53:58AM +0800, Peng Fan wrote:
> > Yeah. The patch I wrote include fix write_env, and a function prototype in
> > header file.
> > 
> > If the current patch already applied, I can write a follow up patch.
> > 
> > Thanks,
> > Peng.
> > 
> 
> Hi Peng,
> 
> sorry, I did not know there was already a similar patch.
> 
> However, now when looking over your patch, it tries to fix read_env and
> write_env, which is not necessary, because the device number is stored
> in struct mmc.
> 
> What's missing though is the function prototype in the header.
> 
> Tom, should I send a v2 of the patch or a follow-up? Or do you want to
> fix this up, Peng?

Ah, yes, a prototype would be good, go ahead and do it, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Tom Rini]

On Wed, Jan 20, 2016 at 03:43:37PM +0100, Clemens Gruber wrote:

> This enables boards to choose where to/from the environment should be
> saved/loaded. They can then for example support using the same device
> (dynamically) from which the bootloader was launched to load and save
> env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.
> 
> In my use case, the environment needs to be on the same device I
> booted from. It can be the eMMC or an optional SD card.
> I therefore would override mmc_get_env_dev in the board code, read the
> CPU registers to determine where we booted from and return the
> corresponding device index.
> 
> Cc: Tom Rini 
> Cc: Stephen Warren 
> Cc: Tim Harvey 
> Cc: Simon Glass 
> Cc: Hans de Goede 
> 
> Signed-off-by: Clemens Gruber 
> Reviewed-by: Stephen Warren 
> Reviewed-by: Tom Rini 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Peng Fan]

On Mon, Jan 25, 2016 at 04:28:55PM -0500, Tom Rini wrote:
>On Wed, Jan 20, 2016 at 03:43:37PM +0100, Clemens Gruber wrote:
>
>> This enables boards to choose where to/from the environment should be
>> saved/loaded. They can then for example support using the same device
>> (dynamically) from which the bootloader was launched to load and save
>> env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.
>> 
>> In my use case, the environment needs to be on the same device I
>> booted from. It can be the eMMC or an optional SD card.
>> I therefore would override mmc_get_env_dev in the board code, read the
>> CPU registers to determine where we booted from and return the
>> corresponding device index.
>> 
>> Cc: Tom Rini 
>> Cc: Stephen Warren 
>> Cc: Tim Harvey 
>> Cc: Simon Glass 
>> Cc: Hans de Goede 
>> 
>> Signed-off-by: Clemens Gruber 
>> Reviewed-by: Stephen Warren 
>> Reviewed-by: Tom Rini 
>
>Applied to u-boot/master, thanks!

Oh. I missed this patch. I have a more complete patch, still in patch work.
https://patchwork.ozlabs.org/patch/558056/.

Regards,
Peng.

>
>-- 
>Tom



>___
>U-Boot mailing list
>U-Boot@lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Tom Rini]

On Tue, Jan 26, 2016 at 09:42:38AM +0800, Peng Fan wrote:
> On Mon, Jan 25, 2016 at 04:28:55PM -0500, Tom Rini wrote:
> >On Wed, Jan 20, 2016 at 03:43:37PM +0100, Clemens Gruber wrote:
> >
> >> This enables boards to choose where to/from the environment should be
> >> saved/loaded. They can then for example support using the same device
> >> (dynamically) from which the bootloader was launched to load and save
> >> env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.
> >> 
> >> In my use case, the environment needs to be on the same device I
> >> booted from. It can be the eMMC or an optional SD card.
> >> I therefore would override mmc_get_env_dev in the board code, read the
> >> CPU registers to determine where we booted from and return the
> >> corresponding device index.
> >> 
> >> Cc: Tom Rini 
> >> Cc: Stephen Warren 
> >> Cc: Tim Harvey 
> >> Cc: Simon Glass 
> >> Cc: Hans de Goede 
> >> 
> >> Signed-off-by: Clemens Gruber 
> >> Reviewed-by: Stephen Warren 
> >> Reviewed-by: Tom Rini 
> >
> >Applied to u-boot/master, thanks!
> 
> Oh. I missed this patch. I have a more complete patch, still in patch work.
> https://patchwork.ozlabs.org/patch/558056/.

Bah.  They look to cover the same areas to me at least.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] env_mmc: support overriding mmc dev from board code

[Peng Fan]

On Mon, Jan 25, 2016 at 09:13:00PM -0500, Tom Rini wrote:
>On Tue, Jan 26, 2016 at 09:42:38AM +0800, Peng Fan wrote:
>> On Mon, Jan 25, 2016 at 04:28:55PM -0500, Tom Rini wrote:
>> >On Wed, Jan 20, 2016 at 03:43:37PM +0100, Clemens Gruber wrote:
>> >
>> >> This enables boards to choose where to/from the environment should be
>> >> saved/loaded. They can then for example support using the same device
>> >> (dynamically) from which the bootloader was launched to load and save
>> >> env data and do not have to define CONFIG_SYS_MMC_ENV_DEV statically.
>> >> 
>> >> In my use case, the environment needs to be on the same device I
>> >> booted from. It can be the eMMC or an optional SD card.
>> >> I therefore would override mmc_get_env_dev in the board code, read the
>> >> CPU registers to determine where we booted from and return the
>> >> corresponding device index.
>> >> 
>> >> Cc: Tom Rini 
>> >> Cc: Stephen Warren 
>> >> Cc: Tim Harvey 
>> >> Cc: Simon Glass 
>> >> Cc: Hans de Goede 
>> >> 
>> >> Signed-off-by: Clemens Gruber 
>> >> Reviewed-by: Stephen Warren 
>> >> Reviewed-by: Tom Rini 
>> >
>> >Applied to u-boot/master, thanks!
>> 
>> Oh. I missed this patch. I have a more complete patch, still in patch work.
>> https://patchwork.ozlabs.org/patch/558056/.
>
>Bah.  They look to cover the same areas to me at least.

Yeah. The patch I wrote include fix write_env, and a function prototype in
header file.

If the current patch already applied, I can write a follow up patch.

Thanks,
Peng.

>
>-- 
>Tom


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot