Re: [PATCH] doc: board: freescale: imx8mp_evk: update to newer versions and change ATF_LOAD_ADDR
Hi Andrey, thanks for the review! On 2021-02-12 19:16, ZHIZHIKIN Andrey wrote: Hello Peter, -Original Message- From: Peter Bergin Sent: Friday, February 12, 2021 2:57 PM To: u-boot@lists.denx.de Cc: Peter Bergin ; ZHIZHIKIN Andrey Subject: [PATCH] doc: board: freescale: imx8mp_evk: update to newer versions and change ATF_LOAD_ADDR Update imx-atf and firmware-imx to latest released versions. Update address of ATF_LOAD_ADDR that has changed to 0x49 in imx-atf commit 48733cb4e773a7584ced601de9d717efa3d73815. Commit message is incorrect, ATF_LOAD_ADDR is actually set to 0x97 Good catch and it is indeed wrong. Add 'O=' to make instructions as one issue has been noticed where it was trouble building directly inside u-boot source dir. Signed-off-by: Peter Bergin Cc: Andrey Zhizhikin --- doc/board/freescale/imx8mp_evk.rst | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/doc/board/freescale/imx8mp_evk.rst b/doc/board/freescale/imx8mp_evk.rst index ccffcf7257..5ca3bb8199 100644 --- a/doc/board/freescale/imx8mp_evk.rst +++ b/doc/board/freescale/imx8mp_evk.rst @@ -18,7 +18,7 @@ Get and Build the ARM Trusted firmware Note: $(srctree) is the U-Boot source directory Get ATF from: https://source.codeaurora.org/external/imx/imx-atf -branch: imx_5.4.47_2.2.0 +branch: imx_5.4.70_2.3.0 .. code-block:: bash @@ -30,13 +30,13 @@ Get the ddr firmware .. code-block:: bash - $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin - $ chmod +x firmware-imx-8.9.bin - $ ./firmware-imx-8.9.bin - $ cp firmware-imx- 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_201904.bin $(srctree)/lpddr4_pmu_train_1d_dmem.bin - $ cp firmware-imx- 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_201904.bin $(srctree)/lpddr4_pmu_train_1d_imem.bin - $ cp firmware-imx- 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_201904.bin $(srctree)/lpddr4_pmu_train_2d_dmem.bin - $ cp firmware-imx- 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_201904.bin $(srctree)/lpddr4_pmu_train_2d_imem.bin + $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.10.bin + $ chmod +x firmware-imx-8.10.bin + $ ./firmware-imx-8.10.bin + $ cp firmware-imx- 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin $(srctree)/lpddr4_pmu_train_1d_dmem.bin + $ cp firmware-imx- 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin $(srctree)/lpddr4_pmu_train_1d_imem.bin + $ cp firmware-imx- 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin $(srctree)/lpddr4_pmu_train_2d_dmem.bin + $ cp + firmware-imx- 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_20200 + 6.bin $(srctree)/lpddr4_pmu_train_2d_imem.bin Build U-Boot @@ -44,15 +44,15 @@ Build U-Boot .. code-block:: bash $ export CROSS_COMPILE=aarch64-poky-linux- - $ make imx8mp_evk_defconfig - $ export ATF_LOAD_ADDR=0x96 - $ make flash.bin + $ make O=build imx8mp_evk_defconfig As a suggestion: maybe it is better to change the order here when `make O=build imx8mp_evk_defconfig` called first, followed by copy of DDR firmware and ATF binary. This would make sure that the ./build folder would already exist at the time copy operations are executed, and should make step-by-step instructions more transparent. Good suggestion. + $ export ATF_LOAD_ADDR=0x97 + $ make O=build flash.bin Burn the flash.bin to the MicroSD card at offset 32KB: .. code-block:: bash - $sudo dd if=flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync + $sudo dd if=build/flash.bin of=/dev/sd[x] bs=1K seek=32 + conv=notrunc; sync Boot -- 2.25.1 Otherwise: Reviewed-by: Andrey Zhizhikin Cheers, Andrey Will update and send a v2 on this. Best regards, /Peter
RE: [PATCH] doc: board: freescale: imx8mp_evk: update to newer versions and change ATF_LOAD_ADDR
Hello Peter, > -Original Message- > From: Peter Bergin > Sent: Friday, February 12, 2021 2:57 PM > To: u-boot@lists.denx.de > Cc: Peter Bergin ; ZHIZHIKIN Andrey > > Subject: [PATCH] doc: board: freescale: imx8mp_evk: update to newer versions > and change ATF_LOAD_ADDR > > Update imx-atf and firmware-imx to latest released versions. > > Update address of ATF_LOAD_ADDR that has changed to 0x49 in imx-atf > commit 48733cb4e773a7584ced601de9d717efa3d73815. Commit message is incorrect, ATF_LOAD_ADDR is actually set to 0x97 > > Add 'O=' to make instructions as one issue has been noticed where it was > trouble > building directly inside u-boot source dir. > > Signed-off-by: Peter Bergin > Cc: Andrey Zhizhikin > --- > doc/board/freescale/imx8mp_evk.rst | 24 > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/doc/board/freescale/imx8mp_evk.rst > b/doc/board/freescale/imx8mp_evk.rst > index ccffcf7257..5ca3bb8199 100644 > --- a/doc/board/freescale/imx8mp_evk.rst > +++ b/doc/board/freescale/imx8mp_evk.rst > @@ -18,7 +18,7 @@ Get and Build the ARM Trusted firmware > > Note: $(srctree) is the U-Boot source directory Get ATF from: > https://source.codeaurora.org/external/imx/imx-atf > -branch: imx_5.4.47_2.2.0 > +branch: imx_5.4.70_2.3.0 > > .. code-block:: bash > > @@ -30,13 +30,13 @@ Get the ddr firmware > > .. code-block:: bash > > - $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.9.bin > - $ chmod +x firmware-imx-8.9.bin > - $ ./firmware-imx-8.9.bin > - $ cp firmware-imx- > 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_201904.bin > $(srctree)/lpddr4_pmu_train_1d_dmem.bin > - $ cp firmware-imx- > 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_201904.bin > $(srctree)/lpddr4_pmu_train_1d_imem.bin > - $ cp firmware-imx- > 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_201904.bin > $(srctree)/lpddr4_pmu_train_2d_dmem.bin > - $ cp firmware-imx- > 8.9/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_201904.bin > $(srctree)/lpddr4_pmu_train_2d_imem.bin > + $ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-8.10.bin > + $ chmod +x firmware-imx-8.10.bin > + $ ./firmware-imx-8.10.bin > + $ cp firmware-imx- > 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_dmem_202006.bin > $(srctree)/lpddr4_pmu_train_1d_dmem.bin > + $ cp firmware-imx- > 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_1d_imem_202006.bin > $(srctree)/lpddr4_pmu_train_1d_imem.bin > + $ cp firmware-imx- > 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_dmem_202006.bin > $(srctree)/lpddr4_pmu_train_2d_dmem.bin > + $ cp > + firmware-imx- > 8.10/firmware/ddr/synopsys/lpddr4_pmu_train_2d_imem_20200 > + 6.bin $(srctree)/lpddr4_pmu_train_2d_imem.bin > > Build U-Boot > > @@ -44,15 +44,15 @@ Build U-Boot > .. code-block:: bash > > $ export CROSS_COMPILE=aarch64-poky-linux- > - $ make imx8mp_evk_defconfig > - $ export ATF_LOAD_ADDR=0x96 > - $ make flash.bin > + $ make O=build imx8mp_evk_defconfig As a suggestion: maybe it is better to change the order here when `make O=build imx8mp_evk_defconfig` called first, followed by copy of DDR firmware and ATF binary. This would make sure that the ./build folder would already exist at the time copy operations are executed, and should make step-by-step instructions more transparent. > + $ export ATF_LOAD_ADDR=0x97 > + $ make O=build flash.bin > > Burn the flash.bin to the MicroSD card at offset 32KB: > > .. code-block:: bash > > - $sudo dd if=flash.bin of=/dev/sd[x] bs=1K seek=32 conv=notrunc; sync > + $sudo dd if=build/flash.bin of=/dev/sd[x] bs=1K seek=32 > + conv=notrunc; sync > > Boot > > -- > 2.25.1 Otherwise: Reviewed-by: Andrey Zhizhikin Cheers, Andrey
