Re: [PATCH] arm: socfpga: Add the terasic de10-standard board
Hi Marek, Thanks for the quick review! > Doesn't the PLL config also come from quartus ? It should all come from > it. See doc/README.socfpga My mistake, I will update the patch using all the files created by the bsp-create-settings. > I think a lot of those board/config-specific copyright messages could > use an update, I think they should be assigned to you. Please do a quick > V2 with that change. Besides that: Please advise what I should do there. For this particular board I adapted the code from the de10-nano board, which already had these copyright messages. Best regards, On Sat, May 21, 2022 at 10:06 PM Marek Vasut wrote: > > On 5/21/22 19:32, Humberto Naves wrote: > > Used the de10-nano files as templates for the de10-standard board. > > Changed the iocsr_config.h and pinmux_config.h based on the handoff > > files generated by quartus. Finally, the pll_config.h was copied > > from the altera cyclone5-socdk board. > > Doesn't the PLL config also come from quartus ? It should all come from > it. See doc/README.socfpga > > > Signed-off-by: Humberto Naves > > Cc: Marek Vasut > > I think a lot of those board/config-specific copyright messages could > use an update, I think they should be assigned to you. Please do a quick > V2 with that change. Besides that: > > Reviewed-by: Marek Vasut
Re: [PATCH] arm: socfpga: Add the terasic de10-standard board
On 5/22/22 17:53, Humberto Naves wrote: Hi Marek, Hi, Thanks for the quick review! Doesn't the PLL config also come from quartus ? It should all come from it. See doc/README.socfpga My mistake, I will update the patch using all the files created by the bsp-create-settings. Thanks I think a lot of those board/config-specific copyright messages could use an update, I think they should be assigned to you. Please do a quick V2 with that change. Besides that: Please advise what I should do there. For this particular board I adapted the code from the de10-nano board, which already had these copyright messages. I'm not a lawyer. Maybe the most safe approach is to keep the original copyright and add your own in addition to it ?
Re: [PATCH] arm: socfpga: Add the terasic de10-standard board
On 5/21/22 19:32, Humberto Naves wrote: Used the de10-nano files as templates for the de10-standard board. Changed the iocsr_config.h and pinmux_config.h based on the handoff files generated by quartus. Finally, the pll_config.h was copied from the altera cyclone5-socdk board. Doesn't the PLL config also come from quartus ? It should all come from it. See doc/README.socfpga Signed-off-by: Humberto Naves Cc: Marek Vasut I think a lot of those board/config-specific copyright messages could use an update, I think they should be assigned to you. Please do a quick V2 with that change. Besides that: Reviewed-by: Marek Vasut
