Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant
On Fri, Nov 17, 2023 at 08:48:00AM -0600, Adam Ford wrote: > On Fri, Nov 17, 2023 at 8:41 AM Tom Rini wrote: > > > > On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > > > > > A new variant of the i.MX8MP System-on-module from Beacon is > > > available which contains 4GB of RAM vs 6GB. The memory > > > timings are slightly different, so a different config is necessary > > > to build the different timing file. > > > > > > Signed-off-by: Adam Ford > > > > Might this be a case for using config fragments instead? > > I didn't realize U-Boot was supporting that. I'll submit a V2 with > the defconfig option removed. Is there an example you can direct me > to that does this already? The beagleplay boards are currently handled via config fragments as well as a few asus platforms (grouper, transformer-t30). I just now noticed the latter places the fragments in a configs subdirectory which is nice I think when there's going to be a number of fragments, but not required. > > thanks! > > adam > > See doc/develop/board_best_practices.rst > > > > -- > > Tom -- Tom signature.asc Description: PGP signature
Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant
On Fri, Nov 17, 2023 at 8:41 AM Tom Rini wrote: > > On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > > > A new variant of the i.MX8MP System-on-module from Beacon is > > available which contains 4GB of RAM vs 6GB. The memory > > timings are slightly different, so a different config is necessary > > to build the different timing file. > > > > Signed-off-by: Adam Ford > > Might this be a case for using config fragments instead? I didn't realize U-Boot was supporting that. I'll submit a V2 with the defconfig option removed. Is there an example you can direct me to that does this already? thanks! adam > See doc/develop/board_best_practices.rst > > -- > Tom
Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant
On Thu, Nov 16, 2023 at 07:31:53PM -0600, Adam Ford wrote: > A new variant of the i.MX8MP System-on-module from Beacon is > available which contains 4GB of RAM vs 6GB. The memory > timings are slightly different, so a different config is necessary > to build the different timing file. > > Signed-off-by: Adam Ford Might this be a case for using config fragments instead? See doc/develop/board_best_practices.rst -- Tom signature.asc Description: PGP signature
Re: [PATCH] arm64: imx: imx8mp-beacon: Add support for 4GB Variant
On Thu, Nov 16, 2023 at 10:32 PM Adam Ford wrote: > > A new variant of the i.MX8MP System-on-module from Beacon is > available which contains 4GB of RAM vs 6GB. The memory > timings are slightly different, so a different config is necessary > to build the different timing file. > > Signed-off-by: Adam Ford Reviewed-by: Fabio Estevam
