Re: [PATCH] env: Remove misuse of env is nowhere driver
Hi Heiko,
Am 29.04.2023 um 06:30 schrieb Heiko Schocher:
Hello Stefan,
On 28.04.23 15:45, Stefan Herbrechtsmeier wrote:
From: Stefan Herbrechtsmeier
When using a list of writeable variables, the initial values come from
the built-in default environment since commit 5ab81058364b
("env: Complete generic support for writable list"). Remove unnecessary
misuse of the env is nowhere driver as default environment.
Signed-off-by: Stefan Herbrechtsmeier
---
board/aristainetos/aristainetos.c| 19 ---
configs/aristainetos2c_defconfig | 1 -
configs/aristainetos2ccslb_defconfig | 1 -
env/env.c| 2 --
4 files changed, 23 deletions(-)
Also you mix up a change in common code and in board code.
I use one commit to avoid a breakage in between the commits but it looks
like all affected boards use one environment source only so that a
separation should be okay.
And grepping in code for ENVL_NOWHERE has much more finds...
Thanks for the hint. I have recheck the code and add two additional boards.
Regards
Stefan
Re: [PATCH] env: Remove misuse of env is nowhere driver
Hello Stefan,
On 29.04.23 06:30, Heiko Schocher wrote:
> Hello Stefan,
>
> On 28.04.23 15:45, Stefan Herbrechtsmeier wrote:
>> From: Stefan Herbrechtsmeier
>>
>> When using a list of writeable variables, the initial values come from
>> the built-in default environment since commit 5ab81058364b
>> ("env: Complete generic support for writable list"). Remove unnecessary
>> misuse of the env is nowhere driver as default environment.
>>
>> Signed-off-by: Stefan Herbrechtsmeier
>>
>> ---
>>
>> board/aristainetos/aristainetos.c| 19 ---
>> configs/aristainetos2c_defconfig | 1 -
>> configs/aristainetos2ccslb_defconfig | 1 -
>> env/env.c| 2 --
>> 4 files changed, 23 deletions(-)
>
> NACK.
Sorry for being to fast with my NACK (I was on thw wrong code
base ...)!
Tested-by: Heiko Schocher
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH] env: Remove misuse of env is nowhere driver
Hello Stefan,
On 28.04.23 15:45, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier
>
> When using a list of writeable variables, the initial values come from
> the built-in default environment since commit 5ab81058364b
> ("env: Complete generic support for writable list"). Remove unnecessary
> misuse of the env is nowhere driver as default environment.
>
> Signed-off-by: Stefan Herbrechtsmeier
> ---
>
> board/aristainetos/aristainetos.c| 19 ---
> configs/aristainetos2c_defconfig | 1 -
> configs/aristainetos2ccslb_defconfig | 1 -
> env/env.c| 2 --
> 4 files changed, 23 deletions(-)
NACK.
You completely break the protected environment functionality
for the aristainetos board when you remove env_get_location()
Does it build anymore?
Also you mix up a change in common code and in board code.
And grepping in code for ENVL_NOWHERE has much more finds...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
