Re: [PATCH 15/16] fdt: Make OF_BOARD a bool option
Hi Sean, On Wed, 13 Oct 2021 at 11:30, Sean Anderson wrote: > > On 10/13/21 12:58 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt > > wrote: > >> > >> > >> > >> On 10/13/21 03:01, Simon Glass wrote: > >>> This should not be a separate option from OF_SEPARATE. It is a run-time > >>> option to override the devicetree, even if present. > >>> > >>> Move the option out of the choice. > >>> > >>> Disable BINMAN_FDT for a few boards which don't actually use it. > >> > >> You only sent patch 6/16 and 15/16 to me. No clue why. Please, send > >> complete patch sets instead of selected patches which cannot be reviewed > >> without the context. > > > > I actually only explicitly cc'd Ilias (who has been working on similar > > things) and Tom. Everyone else came in via maintainer files. Can you > > see the rest in the mailing list, assuming you are subscribed? I can > > add you to the next version. > > > > For the record, here is what patman produced: > > FWIW I have always thought that patman CCs too many people by default. > It is only partially based on MAINTAINERS; the rest of the CCs are from > people who have touched the file recently. This results in many people > being CC'd who have made only minor or unrelated changes to the code > (especially from treewide changes). For this reason, I curate my CCs > manually to hopefully CC only those people who are actually interested > in my patches. Patman uses only the commit tags and get_maintainers, so the fault may live with the latter? Regards, Simon
Re: [PATCH 15/16] fdt: Make OF_BOARD a bool option
On 10/13/21 12:58 PM, Simon Glass wrote: Hi Heinrich, On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt wrote: On 10/13/21 03:01, Simon Glass wrote: This should not be a separate option from OF_SEPARATE. It is a run-time option to override the devicetree, even if present. Move the option out of the choice. Disable BINMAN_FDT for a few boards which don't actually use it. You only sent patch 6/16 and 15/16 to me. No clue why. Please, send complete patch sets instead of selected patches which cannot be reviewed without the context. I actually only explicitly cc'd Ilias (who has been working on similar things) and Tom. Everyone else came in via maintainer files. Can you see the rest in the mailing list, assuming you are subscribed? I can add you to the next version. For the record, here is what patman produced: FWIW I have always thought that patman CCs too many people by default. It is only partially based on MAINTAINERS; the rest of the CCs are from people who have touched the file recently. This results in many people being CC'd who have made only minor or unrelated changes to the code (especially from treewide changes). For this reason, I curate my CCs manually to hopefully CC only those people who are actually interested in my patches. --Sean $ patman -n Cleaned 16 patches ... checkpatch.pl found 0 error(s), 14 warning(s), 0 checks(s) Not sending emails due to errors/warnings Dry run, so not doing much. But I would do this: Send a total of 16 patches with a cover letter. 0001-arm-qemu-Mention-nographic-in-the-docs.patch Cc: Albert Aribaud Cc: Simon Glass Cc: qemu-de...@nongnu.org 0002-arm-qemu-Explain-how-to-extract-the-generate-devicet.patch Cc: Albert Aribaud Cc: Simon Glass Cc: qemu-de...@nongnu.org 0003-riscv-qemu-Explain-how-to-extract-the-generate-devic.patch Cc: Atish Patra Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Rick Chen Cc: Simon Glass Cc: qemu-de...@nongnu.org 0004-arm-qemu-Add-a-devicetree-file-for-qemu_arm.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey Cc: Tuomas Tynkkynen Cc: qemu-de...@nongnu.org 0005-arm-qemu-Add-a-devicetree-file-for-qemu_arm64.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey Cc: Tuomas Tynkkynen Cc: qemu-de...@nongnu.org 0006-riscv-qemu-Add-devicetree-files-for-qemu_riscv32-64.patch Cc: Bin Meng Cc: David Abdurachmanov Cc: Dimitri John Ledkov Cc: Green Wan Cc: Heinrich Schuchardt Cc: Jonathan Balkind Cc: Leo Cc: Padmarao Begari Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tianrui Wei Cc: Zong Li Cc: qemu-de...@nongnu.org 0007-arm-rpi-Add-a-devicetree-file-for-rpi_4.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Matthias Brugger Cc: Neil Armstrong Cc: Peter Robinson Cc: Simon Glass Cc: Stephen Warren Cc: Stephen Warren Cc: Tim Harvey 0008-arm-vexpress-Add-a-devicetree-file-for-juno.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Bin Meng Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Linus Walleij Cc: Liviu Dudau Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey 0009-arm-xenguest_arm64-Add-a-fake-devicetree-file.patch Cc: Albert Aribaud Cc: Anastasiia Lukianenko Cc: Andre Przywara Cc: Bin Meng Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Oleksandr Andrushchenko Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey 0010-arm-octeontx-Add-a-fake-devicetree-file.patch Cc: Aaron Williams Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian
Re: [PATCH 15/16] fdt: Make OF_BOARD a bool option
Hi Heinrich, On Tue, 12 Oct 2021 at 22:22, Heinrich Schuchardt wrote: > > > > On 10/13/21 03:01, Simon Glass wrote: > > This should not be a separate option from OF_SEPARATE. It is a run-time > > option to override the devicetree, even if present. > > > > Move the option out of the choice. > > > > Disable BINMAN_FDT for a few boards which don't actually use it. > > You only sent patch 6/16 and 15/16 to me. No clue why. Please, send > complete patch sets instead of selected patches which cannot be reviewed > without the context. I actually only explicitly cc'd Ilias (who has been working on similar things) and Tom. Everyone else came in via maintainer files. Can you see the rest in the mailing list, assuming you are subscribed? I can add you to the next version. For the record, here is what patman produced: $ patman -n Cleaned 16 patches ... checkpatch.pl found 0 error(s), 14 warning(s), 0 checks(s) Not sending emails due to errors/warnings Dry run, so not doing much. But I would do this: Send a total of 16 patches with a cover letter. 0001-arm-qemu-Mention-nographic-in-the-docs.patch Cc: Albert Aribaud Cc: Simon Glass Cc: qemu-de...@nongnu.org 0002-arm-qemu-Explain-how-to-extract-the-generate-devicet.patch Cc: Albert Aribaud Cc: Simon Glass Cc: qemu-de...@nongnu.org 0003-riscv-qemu-Explain-how-to-extract-the-generate-devic.patch Cc: Atish Patra Cc: Bin Meng Cc: Heinrich Schuchardt Cc: Rick Chen Cc: Simon Glass Cc: qemu-de...@nongnu.org 0004-arm-qemu-Add-a-devicetree-file-for-qemu_arm.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey Cc: Tuomas Tynkkynen Cc: qemu-de...@nongnu.org 0005-arm-qemu-Add-a-devicetree-file-for-qemu_arm64.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey Cc: Tuomas Tynkkynen Cc: qemu-de...@nongnu.org 0006-riscv-qemu-Add-devicetree-files-for-qemu_riscv32-64.patch Cc: Bin Meng Cc: David Abdurachmanov Cc: Dimitri John Ledkov Cc: Green Wan Cc: Heinrich Schuchardt Cc: Jonathan Balkind Cc: Leo Cc: Padmarao Begari Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tianrui Wei Cc: Zong Li Cc: qemu-de...@nongnu.org 0007-arm-rpi-Add-a-devicetree-file-for-rpi_4.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Matthias Brugger Cc: Neil Armstrong Cc: Peter Robinson Cc: Simon Glass Cc: Stephen Warren Cc: Stephen Warren Cc: Tim Harvey 0008-arm-vexpress-Add-a-devicetree-file-for-juno.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Bin Meng Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Linus Walleij Cc: Liviu Dudau Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey 0009-arm-xenguest_arm64-Add-a-fake-devicetree-file.patch Cc: Albert Aribaud Cc: Anastasiia Lukianenko Cc: Andre Przywara Cc: Bin Meng Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Oleksandr Andrushchenko Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Tim Harvey 0010-arm-octeontx-Add-a-fake-devicetree-file.patch Cc: Aaron Williams Cc: Albert Aribaud Cc: Andre Przywara Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang Cc: Neil Armstrong Cc: Peter Robinson Cc: Rick Chen Cc: Sean Anderson Cc: Simon Glass Cc: Stefan Roese Cc: Tero Kristo Cc: Tim Harvey 0011-arm-xilinx_versal_virt-Add-a-devicetree-file.patch Cc: Albert Aribaud Cc: Andre Przywara Cc: Ashok Reddy Soma Cc: Christian Hewitt Cc: Fabio Estevam Cc: Heiko Schocher Cc: Jagan Teki Cc: Kever Yang
Re: [PATCH 15/16] fdt: Make OF_BOARD a bool option
On 10/13/21 03:01, Simon Glass wrote: This should not be a separate option from OF_SEPARATE. It is a run-time option to override the devicetree, even if present. Move the option out of the choice. Disable BINMAN_FDT for a few boards which don't actually use it. You only sent patch 6/16 and 15/16 to me. No clue why. Please, send complete patch sets instead of selected patches which cannot be reviewed without the context. Best regards Heinrich Signed-off-by: Simon Glass --- configs/qemu-ppce500_defconfig | 1 + configs/qemu-riscv32_spl_defconfig | 2 ++ configs/qemu-riscv64_spl_defconfig | 1 + dts/Kconfig| 9 + 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/configs/qemu-ppce500_defconfig b/configs/qemu-ppce500_defconfig index 5bf3e8de37a..66411f73a11 100644 --- a/configs/qemu-ppce500_defconfig +++ b/configs/qemu-ppce500_defconfig @@ -54,4 +54,5 @@ CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_NET=y CONFIG_VIRTIO_BLK=y CONFIG_ADDR_MAP=y +# CONFIG_BINMAN_FDT is not set CONFIG_PANIC_HANG=y diff --git a/configs/qemu-riscv32_spl_defconfig b/configs/qemu-riscv32_spl_defconfig index 3909c9a15ad..4621afb1a87 100644 --- a/configs/qemu-riscv32_spl_defconfig +++ b/configs/qemu-riscv32_spl_defconfig @@ -6,6 +6,7 @@ CONFIG_DEFAULT_DEVICE_TREE="qemu-virt32" CONFIG_SPL=y CONFIG_TARGET_QEMU_VIRT=y CONFIG_RISCV_SMODE=y +# CONFIG_OF_BOARD_FIXUP is not set CONFIG_DISTRO_DEFAULTS=y CONFIG_SYS_LOAD_ADDR=0x8020 CONFIG_FIT=y @@ -18,3 +19,4 @@ CONFIG_OF_BOARD=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_DM_MTD=y CONFIG_SYSRESET_SBI=y +# CONFIG_BINMAN_FDT is not set diff --git a/configs/qemu-riscv64_spl_defconfig b/configs/qemu-riscv64_spl_defconfig index 34d88da41b0..6f8ff91df9e 100644 --- a/configs/qemu-riscv64_spl_defconfig +++ b/configs/qemu-riscv64_spl_defconfig @@ -19,3 +19,4 @@ CONFIG_OF_BOARD=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_DM_MTD=y CONFIG_SYSRESET_SBI=y +# CONFIG_BINMAN_FDT is not set diff --git a/dts/Kconfig b/dts/Kconfig index 313b9e5d70b..6be5710df7d 100644 --- a/dts/Kconfig +++ b/dts/Kconfig @@ -104,7 +104,6 @@ choice config OF_SEPARATE bool "Separate DTB for DT control" - depends on !SANDBOX help If this option is enabled, the device tree will be built and placed as a separate u-boot.dtb file alongside the U-Boot image. @@ -117,14 +116,16 @@ config OF_EMBED and development only and is not recommended for production devices. Boards in the mainline U-Boot tree should not use it. +endchoice + config OF_BOARD bool "Provided by the board (e.g a previous loader) at runtime" help If this option is enabled, the device tree will be provided by - the board at runtime if the board supports it, instead of being - bundled with the image. + the board at runtime if the board supports it. The device tree bundled + with the image (if any) will be overridden / ignored. -endchoice + A device tree file must be provided in the tree. config DEFAULT_DEVICE_TREE string "Default Device Tree for DT control"
